On Tue, 12 Oct 2021 17:04:27 GMT, Fernando Guallini
wrote:
> This patch improves code coverage on the following classes:
> -
> com.sun.org.apache.xml.internal.security.algorithms.implementations.IntegrityHmac
> - com.sun.org.apache.xml.internal.security.utils.
On Wed, 13 Oct 2021 16:17:37 GMT, Rajan Halade wrote:
>> Fernando Guallini has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> throw RuntimeException
>
> test/jdk/com/sun/org/apache/xml/internal/security/Sig
;
> The new tests exercise code blocks that are not currently covered by other
> tests.
Fernando Guallini has updated the pull request incrementally with one
additional commit since the last revision:
throw RuntimeException
-
Changes:
- all: https://git.openjdk.java.net/jdk
This patch improves code coverage on the following classes:
-
com.sun.org.apache.xml.internal.security.algorithms.implementations.IntegrityHmac
- com.sun.org.apache.xml.internal.security.utils.ElementProxy
- com.sun.org.apache.xml.internal.security.keys.KeyInfo
The new tests exercise code blocks
On Thu, 2 Sep 2021 13:33:30 GMT, Fernando Guallini
wrote:
> This trivial change fixes the case 2 in test
> sun/security/pkcs11/rsa/TestP11KeyFactoryGetRSAKeySpec, the method
> testKeySpec is expecting a class object of type KeySpec as second argument in
> order to be reusable
This trivial change fixes the case 2 in test
sun/security/pkcs11/rsa/TestP11KeyFactoryGetRSAKeySpec, the method testKeySpec
is expecting a class object of type KeySpec as second argument in order to be
reusable for multiple test scenarios, but then instead of using that argument
the
On Wed, 4 Aug 2021 13:56:17 GMT, Fernando Guallini
wrote:
> The following test has been seen to fail intermittently on Windows platform:
> sun/security/ssl/DHKeyExchange/LegacyDHEKeyExchange.java
> with the exception:
> java.net.SocketException: An established connection
On Wed, 4 Aug 2021 14:16:55 GMT, Fernando Guallini
wrote:
>> The following test has been seen to fail intermittently on Windows platform:
>> sun/security/ssl/DHKeyExchange/LegacyDHEKeyExchange.java
>> with the exception:
>> java.net.SocketException: An establishe
> The test seems to be suffering from some race condition in occasions that
> should be handled to avoid instability
Fernando Guallini has updated the pull request incrementally with one
additional commit since the last revision:
avoid other types of SSLExceptions
-
The following test has been seen to fail intermittently on Windows platform:
sun/security/ssl/DHKeyExchange/LegacyDHEKeyExchange.java
with the exception:
java.net.SocketException: An established connection was aborted by the
software in your host machine
The test seems to be suffering from some
On Thu, 15 Jul 2021 11:05:08 GMT, Fernando Guallini
wrote:
> This change converts security/JavaDotSecurity/ifdefs.sh to java equivalent
This pull request has now been integrated.
Changeset: 97110337
Author: Fernando Guallini
Committer: Rajan Halade
URL:
ht
This change converts security/JavaDotSecurity/ifdefs.sh to java equivalent
-
Commit messages:
- refactored to java
Changes: https://git.openjdk.java.net/jdk/pull/4791/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=4791=00
Issue:
test/jdk/javax/net/ssl/compatibility/JdkInfo is a helper class for the
compatibility tests. It is verifying whether a protocol or cipher suite is
supported/enabled by setting all the allowed values as a string, and then
invoking String contains() to return whether a specific version is
On Wed, 16 Jun 2021 14:24:31 GMT, Fernando Guallini
wrote:
> The following test: javax/net/ssl/SSLSession/TestEnabledProtocols.java, is
> failing intermittently because the client side is expecting a SocketException
> only if it is wrapped into a SSLException, but it should al
The following test: javax/net/ssl/SSLSession/TestEnabledProtocols.java, is
failing intermittently because the client side is expecting a SocketException
only if it is wrapped into a SSLException, but it should also expect a
SocketException when there is no exception chaining.
-
On Wed, 2 Jun 2021 14:03:57 GMT, Fernando Guallini
wrote:
> The test `SSLSocketImplThrowsWrongExceptions` is failing intermittently after
> the change: [JDK-8259662: Don't wrap SocketExceptions into SSLExceptions in
> SSLSocketImpl](https://bugs.openjdk.java.net/browse/JDK-8259662)
&
On Wed, 2 Jun 2021 17:29:51 GMT, Clive Verghese wrote:
> Thank you @fguallini for fixing this test.
>
> Should the SocketException be expected by the client logic as well?
>
The test `SSLSocketImplThrowsWrongExceptions` is failing intermittently after
the change: [JDK-8259662: Don't wrap SocketExceptions into SSLExceptions in
SSLSocketImpl](https://bugs.openjdk.java.net/browse/JDK-8259662)
Since SocketExceptions are not wrapped into SSLException, also need to be
On Tue, 18 May 2021 13:19:53 GMT, Fernando Guallini
wrote:
> Refactor the following shell tests to Java:
> - security/pkcs11/KeyStore/Basic.sh
> - security/pkcs11/KeyStore/ClientAuth.sh
> - security/pkcs11/KeyStore/SecretKeysBasic.sh
> - security/pkcs11/Provider/Config
On Fri, 28 May 2021 15:50:23 GMT, Fernando Guallini
wrote:
>> Refactor the following shell tests to Java:
>> - security/pkcs11/KeyStore/Basic.sh
>> - security/pkcs11/KeyStore/ClientAuth.sh
>> - security/pkcs11/KeyStore/SecretKeysBasic.sh
>> - security/pkcs11/
one has expired.
>
> - Basic: Remove redundant X509Certificate casting
>
> - SecretKeysBasic: it was already in the problem list since it reproduces the
> open bug JDK-8209398 and fails. Test is refactored to java and still
> reproduces the issue.
>
> All the mentioned tests
On Thu, 27 May 2021 09:55:10 GMT, Sibabrata Sahoo wrote:
>> Refactor the following shell tests to Java:
>> - security/pkcs11/KeyStore/Basic.sh
>> - security/pkcs11/KeyStore/ClientAuth.sh
>> - security/pkcs11/KeyStore/SecretKeysBasic.sh
>> - security/pkcs11/Provider/ConfigQuotedString.sh
>> -
On Tue, 18 May 2021 13:19:53 GMT, Fernando Guallini
wrote:
> Refactor the following shell tests to Java:
> - security/pkcs11/KeyStore/Basic.sh
> - security/pkcs11/KeyStore/ClientAuth.sh
> - security/pkcs11/KeyStore/SecretKeysBasic.sh
> - security/pkcs11/Provider/Config
Refactor the following shell tests to Java:
- security/pkcs11/KeyStore/Basic.sh
- security/pkcs11/KeyStore/ClientAuth.sh
- security/pkcs11/KeyStore/SecretKeysBasic.sh
- security/pkcs11/Provider/ConfigQuotedString.sh
- security/pkcs11/Provider/Login.sh
- security/pkcs11/Config/ReadConfInUTF16Env.sh
On Tue, 4 May 2021 15:12:39 GMT, Fernando Guallini
wrote:
> test sun/security/ssl/SSLSocketImpl/CloseSocket.java verifies the behavior
> when a server closes the socket connection during a handshake. The server was
> waiting a fixed 100ms before closing it, but there was no
On Mon, 10 May 2021 11:00:34 GMT, Julia Boes wrote:
> @fguallini I'm happy to sponsor this change once it's been reviewed by
> someone from security.
Thank you for sponsoring!. Rajan has reviewed the PR, it should be ready for
integration.
-
PR:
ng that time frame
>
> With this changeset, the server is checking whether the client thread has
> initiated handshake, and retrying if needed after waiting a short time. In
> addition, the test is now reusing SSLSocketTemplate to simplify sockets
> configuration and client/serve
On Mon, 10 May 2021 15:40:49 GMT, Rajan Halade wrote:
>> OK
>
> Can you please add this as a comment in a test file for clientThread
> variable? I am sure we will have (failed) try to convert it to CountDownLatch
> in future.
@rhalade sure comment included
-
PR:
On Tue, 4 May 2021 16:07:42 GMT, Daniel Fuchs wrote:
>> Fernando Guallini has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> var volatile
>
> test/jdk/sun/security/ssl/SSLSocketImpl/CloseSocket.java l
ng that time frame
>
> With this changeset, the server is checking whether the client thread has
> initiated handshake, and retrying if needed after waiting a short time. In
> addition, the test is now reusing SSLSocketTemplate to simplify sockets
> configuration and client/serve
test sun/security/ssl/SSLSocketImpl/CloseSocket.java verifies the behavior when
a server closes the socket connection during a handshake. The server was
waiting a fixed 100ms before closing it, but there was no guarantee that the
client started the handshake before or during that time frame
On Thu, 22 Apr 2021 11:41:40 GMT, Fernando Guallini
wrote:
> Test DHKeyExchange/LegacyDHEKeyExchange.java has been seen to fail
> intermittently. There is a thread synchronisation issue that is fixed by:
>
> - Using SSLSocketTemplate that handles client/server socket c
Test DHKeyExchange/LegacyDHEKeyExchange.java has been seen to fail
intermittently. There is a thread synchronisation issue that is fixed by:
- Using SSLSocketTemplate that handles client/server socket configuration and
synchronisation before connection
- Making use of a CountDownLatch and
On Tue, 13 Apr 2021 13:19:17 GMT, Fernando Guallini
wrote:
> test/jdk/javax/net/ssl/DTLS/RespondToRetransmit.java has been seen to fail
> intermittently.
> The server side is binding to the wildcard/localhost address which has been a
> source of instability in many tests. Binding
test/jdk/javax/net/ssl/DTLS/RespondToRetransmit.java has been seen to fail
intermittently.
The server side is binding to the wildcard/localhost address which has been a
source of instability in many tests. Binding to loopback address fixes the
intermittent failures.
In addition, other changes
On Fri, 26 Mar 2021 15:31:43 GMT, Fernando Guallini
wrote:
> Occasional interop tests failures may occur when making use of the
> test/jdk/javax/net/ssl/TLSCommon/interop framework since there is no
> assurance the selected available port it is still free at the time a server
On Mon, 29 Mar 2021 18:45:47 GMT, Rajan Halade wrote:
>> Fernando Guallini has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Improve JdkServer::close and Utilities::waitFor methods
>
> test/jdk/j
d second session creation time to validate session
> resumption
Fernando Guallini has updated the pull request incrementally with one
additional commit since the last revision:
add max_retries count, move shell methods to ProcUtils and add win methods
-
Changes:
- all: https://g
On Mon, 29 Mar 2021 17:31:59 GMT, Fernando Guallini
wrote:
>> Occasional interop tests failures may occur when making use of the
>> test/jdk/javax/net/ssl/TLSCommon/interop framework since there is no
>> assurance the selected available port it is still free at the time
d second session creation time to validate session
> resumption
Fernando Guallini has updated the pull request incrementally with one
additional commit since the last revision:
Improve JdkServer::close and Utilities::waitFor methods
-
Changes:
- all: https://git.openjdk.jav
d second session creation time to validate session
> resumption
Fernando Guallini has updated the pull request incrementally with one
additional commit since the last revision:
no need to check if alive while iterating during accept
-
Changes:
- all: https://git.openjdk.jav
Occasional interop tests failures may occur when making use of the
test/jdk/javax/net/ssl/TLSCommon/interop framework since there is no assurance
the selected available port it is still free at the time a server using the
framework starts up, for instance, by command line. To mitigate
On Wed, 3 Mar 2021 12:23:00 GMT, Fernando Guallini
wrote:
> Certain JVM tools may access and initialise InetAddress class and its static
> fields during start up resulting in a NameService implementation being
> already set to the default **PlatformNameService**, causing int
at a
> [NameService](https://github.com/openjdk/jdk/blob/382e38dd246596ec94a1f1ce0e0f9e87f53366c7/src/java.base/share/classes/java/net/InetAddress.java#L1155)
> is created
Fernando Guallini has updated the pull request incrementally with one
additional commit since the last revision:
On Thu, 4 Mar 2021 13:42:57 GMT, Aleksei Efimov wrote:
>> Fernando Guallini has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> move set env properties to header
>
> test/jdk/sun/security/krb5/canonicali
On Mon, 22 Feb 2021 16:39:56 GMT, Fernando Guallini
wrote:
> Kerberos new replay cache format released in 1.18 (installed in OL8.3) is
> causing the tests failures:
> `https://web.mit.edu/kerberos/www/krb5-latest/doc/formats/rcache_file_format.html`
>
> New and old format are
On Tue, 23 Feb 2021 22:43:09 GMT, Rajan Halade wrote:
>> Fernando Guallini has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> remove native lib test with MD5
>
> test/jdk/sun/security/krb5/auto/ReplayCacheTes
a own
> implementation API only.
>
> If there is a decision to support the new format in the future, tests will be
> revisited accordingly.
Fernando Guallini has updated the pull request incrementally with one
additional commit since the last revision:
add comment when scen
a own
> implementation API only.
>
> If there is a decision to support the new format in the future, tests will be
> revisited accordingly.
Fernando Guallini has updated the pull request incrementally with one
additional commit since the last revision:
remove native lib test wi
On Tue, 23 Feb 2021 18:13:24 GMT, Weijun Wang wrote:
>> Fernando Guallini has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> remove native lib test with MD5
>
> test/jdk/sun/security/krb5/auto/ReplayCac
Kerberos new replay cache format released in 1.18 (installed in OL8.3) is
causing the tests failures:
`https://web.mit.edu/kerberos/www/krb5-latest/doc/formats/rcache_file_format.html`
New and old format are not compatible, that means they cannot share a rcache
file. Since there is no
On Thu, 4 Feb 2021 13:00:47 GMT, Fernando Guallini
wrote:
> The server side is binding to the wildcard address which has been a source of
> instability in many networking tests due to javax.net.ssl.SSLException:
> Connection reset. Changing the following tests to bind to loopbac
On Thu, 11 Feb 2021 12:17:41 GMT, Daniel Fuchs wrote:
>> Fernando Guallini has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> check exception type
>
> test/jdk/javax/net/ssl/SSLSession/TestEnabledProt
fore the client
> is done during handshake. That race condition cannot be completely removed in
> this test, thus is now handled and logged.
Fernando Guallini has updated the pull request incrementally with one
additional commit since the last revision:
refactor isConnectionReset method
On Wed, 10 Feb 2021 12:24:15 GMT, Daniel Fuchs wrote:
>> Fernando Guallini has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> narrow down connection reset handling
>
> test/jdk/javax/net/ssl/SSLSession/Test
fore the client
> is done during handshake. That race condition cannot be completely removed in
> this test, thus is now handled and logged.
Fernando Guallini has updated the pull request incrementally with one
additional commit since the last revision:
check exception type
On Fri, 5 Feb 2021 17:45:45 GMT, Rajan Halade wrote:
>> test/jdk/javax/net/ssl/SSLSession/TestEnabledProtocols.java line 145:
>>
>>> 143: // The server side may have closed the socket.
>>> 144: System.out.println("Client SSLException:");
>>> 145:
fore the client
> is done during handshake. That race condition cannot be completely removed in
> this test, thus is now handled and logged.
Fernando Guallini has updated the pull request incrementally with one
additional commit since the last revision:
narrow down connection reset ha
On Thu, 4 Feb 2021 15:11:39 GMT, Daniel Fuchs wrote:
>> Fernando Guallini has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Merge branch '8241372' of github.com:fguallini/jdk into 8241372
>> - remove not
fore the client
> is done during handshake. That race condition cannot be completely removed in
> this test, thus is now handled and logged.
Fernando Guallini has updated the pull request incrementally with two
additional commits since the last revision:
- Merge branch '8241372' of github.c
On Thu, 4 Feb 2021 14:50:24 GMT, Daniel Fuchs wrote:
>> Fernando Guallini has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Merge branch '8241372' of github.com:fguallini/jdk into 8241372
>> - remove not
On Wed, 3 Feb 2021 13:29:54 GMT, Fernando Guallini
wrote:
> The following tests have been split based on lower/higher key sizes in order
> to reduce individual execution time and run in parallel with jtreg
> sun/security/provider/DSA/SupportedDSAParamGen.java
> sun/security/provid
xponent.
> That redundancy is removed. This speeds up the execution from ~54s to ~25s on
> average
Fernando Guallini has updated the pull request incrementally with one
additional commit since the last revision:
add short description regarding test split.
-
Changes:
- all: http
On Wed, 3 Feb 2021 22:30:02 GMT, Weijun Wang wrote:
>> Fernando Guallini has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> add key itself to signature verification
>
> test/jdk/s
The server side is binding to the wildcard address which has been a source of
instability in many networking tests due to javax.net.ssl.SSLException:
Connection reset. Changing the following tests to bind to loopback address
fixes intermittent failures:
On Thu, 4 Feb 2021 13:00:47 GMT, Fernando Guallini
wrote:
> The server side is binding to the wildcard address which has been a source of
> instability in many networking tests due to javax.net.ssl.SSLException:
> Connection reset. Changing the following tests to bind to loopbac
xponent.
> That redundancy is removed. This speeds up the execution from ~54s to ~25s on
> average
Fernando Guallini has updated the pull request incrementally with one
additional commit since the last revision:
add key itself to signature verification
-
Changes:
- all: http
On Wed, 3 Feb 2021 19:50:02 GMT, Weijun Wang wrote:
>> That is right, PSSKeyCompatibility already explicitly proves they both are
>> equal and there are other tests that generates both manually and using
>> KeyFactory. In addition, this test focuses on signature verification rather
>> than
xponent.
> That redundancy is removed. This speeds up the execution from ~54s to ~25s on
> average
Fernando Guallini has updated the pull request incrementally with one
additional commit since the last revision:
prove factory key spec and manual instantiated key spec are equal
-
On Wed, 3 Feb 2021 15:06:37 GMT, Weijun Wang wrote:
>> The following tests have been split based on lower/higher key sizes in order
>> to reduce individual execution time and run in parallel with jtreg
>> sun/security/provider/DSA/SupportedDSAParamGen.java
>>
The following tests have been split based on lower/higher key sizes in order to
reduce individual execution time and run in parallel with jtreg
sun/security/provider/DSA/SupportedDSAParamGen.java
sun/security/provider/NSASuiteB/TestDSAGenParameterSpec.java
On Mon, 25 Jan 2021 17:08:45 GMT, Fernando Guallini
wrote:
> Fixing manual Test
> "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java".
> It was not handling "weak algorithm" warning during jarsigner output
> verification
This pull
On Mon, 25 Jan 2021 22:57:04 GMT, Hai-May Chao wrote:
>> Fernando Guallini has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> add bugid and missing space
>
> Change copyright year to 2021
Thanks for the re
> Fixing manual Test
> "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java".
> It was not handling "weak algorithm" warning during jarsigner output
> verification
Fernando Guallini has updated the pull request incrementally with one
Fixing manual Test
"ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java".
It was not handling "weak algorithm" warning during jarsigner output
verification
-
Commit messages:
- rename method
- handle warning for SHA-1 weak algorithm
Changes:
On Thu, 21 Jan 2021 11:15:20 GMT, Fernando Guallini
wrote:
> test/jdk/javax/net/ssl/TLSCommon/CipherSuite.java only indicates which TLS
> protocols support a cipher suite.
> It should also indicate which DTLS protocols support a cipher suite.
This pull request has been closed with
test/jdk/javax/net/ssl/TLSCommon/CipherSuite.java only indicates which TLS
protocols support a cipher suite.
It should also indicate which DTLS protocols support a cipher suite.
-
Commit messages:
- remove not used protocols
- rename vars
- Merge branch 'master' into 8244411
-
On Fri, 6 Nov 2020 12:04:20 GMT, Fernando Guallini
wrote:
> This patch is to add code coverage to the following methods
> - javax.smartcardio.CardPermission::**implies** (1)
> - javax.smartcardio.ResponseAPDU::**toString** (2)
>
> Tests are added following the expected imple
On Fri, 6 Nov 2020 12:04:20 GMT, Fernando Guallini
wrote:
> This patch is to add code coverage to the following methods
> - javax.smartcardio.CardPermission::**implies** (1)
> - javax.smartcardio.ResponseAPDU::**toString** (2)
>
> Tests are added following the expected imple
This patch is to add code coverage to the following methods
- javax.smartcardio.CardPermission::**implies** (1)
- javax.smartcardio.ResponseAPDU::**toString** (2)
Tests are added following the expected implementation given in the methods
specifications
(1)
80 matches
Mail list logo
