Re: RFR: 8217408: Reduce storage of duplicate identifiers in TLS vectors in SunJSSE [v4]

2021-07-09 Thread Jack Hartstein
On Fri, 9 Jul 2021 20:04:40 GMT, Xue-Lei Andrew Fan wrote: >> Jack Hartstein has updated the pull request incrementally with one >> additional commit since the last revision: >> >> import cleanup in SupportedGroupsExtension > > src/java.base/share/classes/sun/s

Re: RFR: 8217408: Reduce storage of duplicate identifiers in TLS vectors in SunJSSE [v4]

2021-06-23 Thread Jack Hartstein
> 8217408: Reduce storage of duplicate identifiers in TLS vectors in SunJSSE Jack Hartstein has updated the pull request incrementally with one additional commit since the last revision: import cleanup in SupportedGroupsExtension - Changes: - all: https://git.openjdk.java.

Re: RFR: 8217408: Reduce storage of duplicate identifiers in TLS vectors in SunJSSE [v3]

2021-06-23 Thread Jack Hartstein
> 8217408: Reduce storage of duplicate identifiers in TLS vectors in SunJSSE Jack Hartstein has updated the pull request incrementally with one additional commit since the last revision: Delete CheckDuplicateCipherSuites.java Does not test final implementation. - Chan

Re: RFR: 8217408: Reduce storage of duplicate identifiers in TLS vectors in SunJSSE [v2]

2021-06-23 Thread Jack Hartstein
> 8217408: Reduce storage of duplicate identifiers in TLS vectors in SunJSSE Jack Hartstein has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains

RFR: 8217408: Reduce storage of duplicate identifiers in TLS vectors in SunJSSE

2021-06-23 Thread Jack Hartstein
8217408: Reduce storage of duplicate identifiers in TLS vectors in SunJSSE - Commit messages: - 8217408: Reduce storage of duplicate identifiers in TLS vectors in SunJSSE - Changed ClientHello compression consumer loop to index by 1 instead of 2 (bytes vs shorts), and SupportedVers

Re: RFR: 8209092: Remove outdated wording from RC5ParameterSpec [v3]

2021-06-09 Thread Jack Hartstein
supplied by RSA Security LLC, or any parties authorized by RSA > Security." should be removed. We don't generally include information about > 3rd-party JCA providers in the standard javadocs. Also the "authorized" part > was probably referring to the RC5 patent bu

Re: RFR: 8209092: Remove outdated wording from RC5ParameterSpec [v2]

2021-06-09 Thread Jack Hartstein
supplied by RSA Security LLC, or any parties authorized by RSA > Security." should be removed. We don't generally include information about > 3rd-party JCA providers in the standard javadocs. Also the "authorized" part > was probably referring to the RC5 patent bu

Re: RFR: 8209092: Remove outdated wording from RC5ParameterSpec [v2]

2021-06-09 Thread Jack Hartstein
On Wed, 9 Jun 2021 20:48:29 GMT, Bradford Wetmore wrote: >> Jack Hartstein has updated the pull request incrementally with one >> additional commit since the last revision: >> >> added line break > > src/java.base/share/classes/javax/crypto/spec/RC5Parame

RFR: 8209092: Remove outdated wording from RC5ParameterSpec

2021-06-09 Thread Jack Hartstein
The RC5ParameterSpec class description contains the following sentence: "This class can be used to initialize a Cipher object that implements the RC5 algorithm as supplied by RSA Security LLC, or any parties authorized by RSA Security." The part "as supplied by RSA Security LLC, or any parties

Integrated: 8240997: Remove more "hack" word in security codes

2021-06-08 Thread Jack Hartstein
On Fri, 21 May 2021 18:37:12 GMT, Jack Hartstein wrote: > This change is part of a larger code cleanup effort and removes the term > "hack" out of several files in the jdk. > JBS: [](https://bugs.openjdk.java.net/browse/JDK-8240997 ) This pull request has now been int

RFR: 8240997: Remove more "hack" word in security codes

2021-06-08 Thread Jack Hartstein
This change is part of a larger code cleanup effort and removes the term "hack" out of several files in the jdk. JBS: [](https://bugs.openjdk.java.net/browse/JDK-8240997 ) - Commit messages: - 8240997: Remove more hack word in security codes Changes: https://git.openjdk.java.net/j