Looks ok to me. Thanks.
-kto
On Dec 7, 2012, at 2:39 AM, Weijun Wang wrote:
> The native JGSS provider on Mac is not ready yet. Disable the native lib
> creation. Please review the code changes at
>
> http://cr.openjdk.java.net/~weijun/8004235/webrev.00/
>
> *build-dev*: I don't know how t
It seems fine with me.
But I think someone from the security team should chime in on this.
-kto
On Sep 18, 2012, at 7:39 AM, Andrew Hughes wrote:
> This is an issue that has been with us for a while. See:
>
> https://bugs.openjdk.java.net/show_bug.cgi?id=100062
> http://bugs.sun.com/bugdatabas
Looks ok to me.
-kto
On Aug 30, 2011, at 12:34 AM, Weijun Wang wrote:
> Hi All
>
> 7083664: test hard code of using c:/temp but this dir might not exist
>
> Webrev is at --
>
> http://cr.openjdk.java.net/~weijun/7083664/webrev.00/
>
> Some of our regression tests set TMP variables on diffe
On Aug 26, 2011, at 7:08 AM, Chris Hegarty wrote:
> On 08/26/11 02:45 PM, Sean Mullan wrote:
>> On 8/26/11 9:42 AM, Weijun Wang wrote:
>>>
>>>
>>> On 08/26/2011 09:15 PM, Sean Mullan wrote:
Looks fine though you missed updating the copyright date on the test.
>>>
>>> Recently I form a new
On Aug 4, 2011, at 11:06 AM, Weijun Wang wrote:
>> Max, if we can get an agree, would you please update the Makefile to
>> run JSSE in othervm mode in your fix? So that we don't have to fill
>> a new CR.
>
> There are two ways to do this:
>
> 1. Add "@run main/othervm" to all JSSE tests. This
Looks good to me.
-kto
On Mar 7, 2011, at 11:39 AM, Rama Pulavarthi wrote:
> Thanks for the review. We had to make additional changes to run the
> tests. Hopefully this is the final webrev for this issue.
>
> Please review this new webrev which also has changes to
> jdk/test/Makefile to run th
On Jan 21, 2011, at 7:08 AM, Vincent Ryan wrote:
On 21/01/2011 14:42, Alan Bateman wrote:
Vincent Ryan wrote:
Hello Alan,
Please review the following webrev which removes 100's of nuisance
compiler
warnings generated by our ECC code:
http://rialto.ireland.sun.com/~vinnie/webrevs/jdk7/698
On Dec 23, 2010, at 6:17 PM, Brad Wetmore wrote:
On 12/23/2010 12:58 PM, Mandy Chung wrote:
On 12/23/10 12:40 PM, Stuart Marks wrote:
On 12/22/10 6:17 PM, Brad Wetmore wrote:
You need to update the Copyright updates on these files to
include 2010.
Is this the standard, to update the copy
Andrew John Hughes wrote:
2009/12/4 :
Changeset: 1755493c5774
Author:darcy
Date: 2009-12-03 18:19 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1755493c5774
6907177: Update jdk tests to remove unncessary -source and -target options
Reviewed-by: ohair
! test/demo/jvmti/
