Looks good to me.
- Kurchi
On 7/18/2012 1:55 PM, Dan Xu wrote:
Security code reviewers,
Please review the fix of bug 7185051. Its webrev can be checked at
http://cr.openjdk.java.net/~dxu/7185051/webrev/. This commit is to
remove the TestProviderLeak.java test from the test problem list as i
Hi Brad,
This looks fine to me.
Thanks,
Kurchi
On 6/15/2012 5:25 PM, Brad Wetmore wrote:
This test has started failing in JDK nightly. We were working on it
this week, but test approach may need alteration. Putting this test
on ProblemList.txt for the time being to quiet the test noise.
ppress warnings in the method parseKeyBits()
level?
+@SuppressWarnings("deprecation")
protected void parseKeyBits() throws InvalidKeyException {
Otherwise, looks fine to me.
Thanks for the cleanup.
Xuelei
On 9/20/2011 11:27 PM, Kurchi Hazra wrote:
Hi Xuelei,
Can you plea
ngs at the places I had to cast.
Thanks,
Kurchi
On 9/21/2011 7:58 AM, Sean Mullan wrote:
On 9/20/11 5:34 PM, Kurchi Hazra wrote:
* MessageDigestAlgorithm.java
[74-5] This is preferable:
static ThreadLocal> instances=new
ThreadLocal>() {
protected Map initialize()...
Th
On 9/19/2011 12:23 PM, Sean Mullan wrote:
On 09/16/2011 06:34 PM, Kurchi Hazra wrote:
Hi Sean,
Can you please review these changes?
Summary: * Small changes to Java files in
src/share/classes/com/sun/org/apache/xml/internal/security and its
subpackages to remove build warnings.
* Small
Hi Xuelei,
Can you please review these changes?
Summary:
1. Small changes to Java files, mostly in src/share/classes/javax/security and
its subpackages to remove build warnings.
2. Small changes to relevant makefiles to prevent
reintroduction of removed warnings. Added a new makefile to preve
Hi Sean,
Can you please review these changes?
Summary: * Small changes to Java files in
src/share/classes/com/sun/org/apache/xml/internal/security and its
subpackages to remove build warnings.
* Small changes to relevant makefiles to prevent
reintroduction of removed warnin
Hi Sean,
Can you please review these changes?
Summary: * Small changes to Java files in
src/share/classes/com/sun/org/apache/xml/internal/security and its
subpackages to remove build warnings.
* Small changes to relevant makefiles to prevent
reintroduction of removed warning
