Request for review : 8032573 - CertificateFactory.getInstance("X.509").generateCertificates(InputStream) does not throw CertificateException for invalid input

2014-12-23 Thread mala bankal
HI Jamil, All, Request your review for backport of bug# 8032573 to 7u-dev. https://bugs.openjdk.java.net/browse/JDK-8032573 webrev: http://cr.openjdk.java.net/~mbankal/8032573/webrev.00/ rgds mala

Request for review : 7196009-SunPkcs11 provider fails to parse config path containing parenthesis

2014-12-23 Thread mala bankal
HI Valerie, All, Request your review for backport of bug 7196009 to 7u-dev. https://bugs.openjdk.java.net/browse/JDK-7196009 webrev: http://cr.openjdk.java.net/~mbankal/7196009/webrev.00/ rgds mala

Request for review : 8037591 - Still seeing Invalid Padding length SSL errors after the fix for JDK-8014618

2014-09-23 Thread mala bankal
HI Brad, All, Request your review for bug # 8037591 https://bugs.openjdk.java.net/browse/JDK-8037591 Solaris mechanisms trims out the leading zeros due to which the Invalid Padding length errors are to be seen. The fix disables the mechanisms in the sunpkcs11-solaris.cfg. webrev : http://cr.o

Request for review : 8054817: File ccache only recognizes Linux and Solaris defaults

2014-09-02 Thread mala bankal
HI Max, All, Request to review the changes for the backport of 8054817 to jdk7u-dev. webrev : http://cr.openjdk.java.net/~mbankal/8054817/webrev.00/ JDK9 changeset : http://hg.openjdk.java.net/jdk9/dev/jdk/rev/ec98f141c757 JDK8 changeset : http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/ec98f141c7

Review Request : JDK-7197159 : accept different kvno if there no match

2014-08-25 Thread mala bankal
HI Max, Request your review for backport of bug# JDK-7197159 : accept different kvno if there no match , to 7u-dev webrev : http://cr.openjdk.java.net/~mbankal/7197159/webrev.00/ regression tests : http://nightsvr.us.oracle.com/export5/users/mbankal/7u80/testing/7197159/JTreport/html/index.h

Re: Request for review : backport of bug# 8031046 to 7u-dev

2014-08-05 Thread mala bankal
HI Max, Thanks for the review. Yes it means no extra code changes. :) rgds mala On 8/6/2014 6:53 AM, Weijun Wang wrote: Hi Mala Code change looks fine. When you say "Direct backport", is it equivalent to "applying the same patch with no conflict"? :-) Thanks Max On

Request for review : backport of bug# 8031046 to 7u-dev

2014-08-05 Thread mala bankal
HI, Request review for the direct backport of bug# 8031046 to 7u-dev. http://cr.openjdk.java.net/~mbankal/8031046/webrev.00/ JDK9 Changeset : http://hg.openjdk.java.net/jdk9/dev/jdk/rev/ab914c760352 JDK8 Changeset : http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/b32e9aba4888 Regression tes

Request review for backport of bug#8036709 to 7u-dev

2014-07-24 Thread mala bankal
Hi, Request review for the direct backport of bug#8036709 from 9/8 to 7u-dev. http://cr.openjdk.java.net/~mbankal/8036709/webrev.00/ JDK9 changeset : http://hg.openjdk.java.net/jdk9/dev/jdk/rev/d1978cf32bc1 JDK8 changeset : http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/2aa925ce9852 Thanks

Re: JPSE-J2SE Code Review Request-JDK-7192392-jdk150_u39#4897, due by 12/8/12_8:29_PM

2012-12-03 Thread mala bankal
t I need a confirm in case of any mis-understanding from my side. Thanks, Xuelei On 12/4/2012 12:51 PM, mala bankal wrote: HI Andrew, No it is not based on previous integration. I brought over a fresh wses after Dave's rollback and made all changes again. Made the changes and built the wses again.

Re: JPSE-J2SE Code Review Request-JDK-7192392-jdk150_u39#4897, due by 12/8/12_8:29_PM

2012-12-03 Thread mala bankal
HI Andrew, No it is not based on previous integration. I brought over a fresh wses after Dave's rollback and made all changes again. Made the changes and built the wses again. It took me more time but i did it right. Now before final integration i checked if changes are present in MASTER ws. rg

Request for approval (7157903 : JSSE client sockets are very slow) for 6-open

2012-07-11 Thread Mala Bankal
HI, Request approval for : 7157903 JSSE client sockets are very slow for 6-open webrev : http://cr.openjdk.java.net/~mbankal/7157903/webrev.00/ Nagle Algorithm (TCP_NODELAY) which affects small packets is false by default. As a result, the kernel was throttling the JSSE output waiting for the

hg: jdk8/tl/jdk: 2 new changesets

2011-09-14 Thread mala . bankal
Changeset: 52bc200b14e5 Author:mbankal Date: 2011-09-14 21:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/52bc200b14e5 7049963: DISTINGUISHED NAMES FOR CERT ARE ESCAPED IN JROCKIT 1.6(NOT COMPATIBLE WITH JROC Reviewed-by: mullan ! src/share/classes/sun/security/x509/AVA.

Re: request for reviews for bug# 7049963

2011-09-14 Thread Mala Bankal
HI Sean, Yes i have done a successful build and tests, i can point you to the builds and tests. rgds mala On 9/14/2011 1:22 AM, Sean Mullan wrote: On 9/13/11 12:53 PM, Mala Bankal wrote: HI Sean, Request for review : bug# 7049963 - DISTINGUISHED NAMES FOR CERT ARE ESCAPED IN JROCKIT 1.6

request for reviews for bug# 7049963

2011-09-13 Thread Mala Bankal
HI Sean, Request for review : bug# 7049963 - DISTINGUISHED NAMES FOR CERT ARE ESCAPED IN JROCKIT 1.6(NOT COMPATIBLE WITH JROC For jdk8 http://cr.openjdk.java.net/~mbankal/7049963/webrev_jdk8.00/ for jdk7u2 http://cr.openjdk.java.net/~mbankal/7049963/webrev.00/ Since the testcase will be in