Re: RFR: 8255739: x509Certificate returns � for invalid subjectAlternativeNames [v2]

2022-01-27 Thread Masanori Yano
On Fri, 14 Jan 2022 11:18:23 GMT, Masanori Yano wrote: >> Could you please review the JDK-8255739 bug fix? >> >> I think sun.security.x509.SubjectAlternativeNameExtension() should throw an >> exception for incorrect SubjectAlternativeNames instead of returning the &

Re: RFR: 8255739: x509Certificate returns � for invalid subjectAlternativeNames

2022-01-17 Thread Masanori Yano
On Thu, 6 Jan 2022 20:28:22 GMT, Sean Mullan wrote: >> Could you please review the JDK-8255739 bug fix? >> >> I think sun.security.x509.SubjectAlternativeNameExtension() should throw an >> exception for incorrect SubjectAlternativeNames instead of returning the >> substituted characters, which

Re: RFR: 8255739: x509Certificate returns � for invalid subjectAlternativeNames [v2]

2022-01-14 Thread Masanori Yano
On Fri, 14 Jan 2022 11:18:23 GMT, Masanori Yano wrote: >> Could you please review the JDK-8255739 bug fix? >> >> I think sun.security.x509.SubjectAlternativeNameExtension() should throw an >> exception for incorrect SubjectAlternativeNames instead of returning the &

Re: RFR: 8255739: x509Certificate returns � for invalid subjectAlternativeNames [v2]

2022-01-14 Thread Masanori Yano
eadStringInternal(). So I added a test with -Djava.security.debug=x509 to > confirm that. Masanori Yano has updated the pull request incrementally with one additional commit since the last revision: 8255739: x509Certificate returns � for invalid subjectAlternativeNames --

Re: RFR: 8255739: x509Certificate returns � for invalid subjectAlternativeNames

2022-01-05 Thread Masanori Yano
On Thu, 23 Dec 2021 11:59:18 GMT, Masanori Yano wrote: > Could you please review the JDK-8255739 bug fix? > > I think sun.security.x509.SubjectAlternativeNameExtension() should throw an > exception for incorrect SubjectAlternativeNames instead of returning the > substituted ch

RFR: 8255739: x509Certificate returns � for invalid subjectAlternativeNames

2021-12-23 Thread Masanori Yano
Could you please review the JDK-8255739 bug fix? I think sun.security.x509.SubjectAlternativeNameExtension() should throw an exception for incorrect SubjectAlternativeNames instead of returning the substituted characters, which is explained in the description of BugDB. I modified DerValue.readS