On Thu, 4 Mar 2021 10:35:35 GMT, Daniel Fuchs wrote:
>> Evan Whelan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8262438: Removed custom socket handling logic
>
> I don't see any specific issue with what you are proposing from a netwo
..11.0.3-oracle represents the Oracle JDK release scheduled for April 2019
as you correctly note.
-Rob
On 21/11/18 16:13, Rob McKenna wrote:
> Hi Goetz,
>
> The CPUXX_YY-critical-request indicates that the engineer is attempting
> to get this fix approved for inclusion in 11.0
Hi Goetz,
The CPUXX_YY-critical-request indicates that the engineer is attempting
to get this fix approved for inclusion in 11.0.2. This may or may not
be successful (though the SQE-OK label indicates it has overcome one of
the bigger hurdles) If approval is secured the fix will be pushed to the
s
Hi folks,
This test appears to be timing out. The main culprit looks to be the
fact that the 100ms sleep isn't enough for the server to respond (on a
busy test machine) so that timeout has been bumped and some new logging
has been added to make it obvious whats happening should the problem
occur a
I can never recall off the top of my head but I wrote a test that might be
helpful:
http://t4.ie.oracle.com/home/robm/files/webrev/8177806/webrev.02/raw_files/new/test/javax/naming/Name/LdapEscapeTest.java
This didn't require pushing in the end but I should hang onto it as its a
simple way of c
/2017 4:32 PM, Xuelei Fan wrote:
> >On 9/15/2017 8:22 AM, Rob McKenna wrote:
> >>This test calls close directly. (3rd last line in the stack)
> >>
> >>I believe this is the only possible stack (with the new parameter) once
> >>autoclose is set to
On 15/09/17 07:55, Xuelei Fan wrote:
> On 9/15/2017 7:41 AM, Rob McKenna wrote:
> >On 15/09/17 07:07, Xuelei Fan wrote:
> >>On 9/15/2017 7:00 AM, Rob McKenna wrote:
> >>>When we call close() on the SSLSocket that calls close() on the
> >>>underlying java So
Xuelei Fan wrote:
> On 9/15/2017 7:44 AM, Rob McKenna wrote:
> >Perhaps I'm misunderstanding you here. Can you illustrate this a bit
> >further?
> >
> The basic point is simple: removing the closing blocking even receiving
> timeout is not set.
>
> >Applicat
On 15/09/17 07:32, Xuelei Fan wrote:
> On 9/15/2017 7:16 AM, Rob McKenna wrote:
> >On 13/09/17 03:52, Xuelei Fan wrote:
> >>
> >>
> >>On 9/13/2017 8:52 AM, Rob McKenna wrote:
> >>>Hi Xuelei,
> >>>
> >>>This beh
tely)
-Rob
On 15/09/17 07:23, Xuelei Fan wrote:
> On 9/15/2017 7:07 AM, Rob McKenna wrote:
> >But they are inextricably linked regardless.
> >
> >When we close an SSLSocket it performs a readReply which is subject to
> >the read timeout. So if no read timeout is spe
On 15/09/17 07:07, Xuelei Fan wrote:
> On 9/15/2017 7:00 AM, Rob McKenna wrote:
> >When we call close() on the SSLSocket that calls close() on the
> >underlying java Socket which closes the native socket.
> >
> Sorry, I did not get the point. Please see the close() imple
On 13/09/17 03:52, Xuelei Fan wrote:
>
>
> On 9/13/2017 8:52 AM, Rob McKenna wrote:
> >Hi Xuelei,
> >
> >This behaviour is already exposed via the autoclose boolean in:
> >
> >https://docs.oracle.com/javase/8/docs/api/javax/net/ssl/SSLSocketFa
On 9/13/2017 8:52 AM, Rob McKenna wrote:
> >W.r.t. a separate timeout, the underlying mechanics of a close already
> >depend on the readTimeout in this situation.
> That's a concerns of mine. In order to work for your countermeasure,
> applications have to set receiving tim
gt;slow, surely there will be other issues with connecting and reading, why is
> >closing any different.
> >
> >-Chris.
> >
> >>On 13 Sep 2017, at 16:52, Rob McKenna wrote:
> >>
> >>Hi Xuelei,
> >>
> >>This behaviour is already exposed
grant
> to be gracefully.
>
> What do you think?
>
> BTW, please file a CSR as this update is introducing an external system
> property.
>
> Thanks,
> Xuelei
>
> On 9/11/2017 3:29 PM, Rob McKenna wrote:
> >Hi folks,
> >
> >In high latency envi
Hi folks,
In high latency environments a client SSLSocket with autoClose set to false
can hang indefinitely if it does not correctly recieve a close_notify
from the server.
In order to rectify this situation I would like to suggest that we
implement an integer JDK property (jdk.tls.closeRetries)
Hi folks,
Looking for a codereview and push approval for the following:
bug: https://bugs.openjdk.java.net/browse/JDK-8163304
9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/7a25dbe45e61
8 webrev: http://cr.openjdk.java.net/~robm/8163304/webrev.02/
Thanks,
-Rob
Apologies folks, managed to overwrite a changeset when pushing 8064330 a
few minutes ago. Looking to rectify asap:
http://cr.openjdk.java.net/~robm/8147931/webrev.01/
-Rob
Hi folks,
SunJSSE enables SHA224 as an available signature and hash algorithm of
TLS 1.2 connections. However, the current implementation of SunMSCAPI
does not support SHA224 yet, and the private key in SunMSCAPI cannot
work together with other providers. This may cause problems if
applicatio
Apologies folks,
I managed to push a change for
https://bugs.openjdk.java.net/browse/JDK-8064330 along with
https://bugs.openjdk.java.net/browse/JDK-7130985
I'd like to revert that particular portion of the change:
http://cr.openjdk.java.net/~robm/8146105/webrev.01/
-Rob
Hi Daniel,
Thanks for the report, I'm cc'ing the security-dev alias.
-Rob
On 22/04/15 13:10, Daniel Jones wrote:
Hi all,
Apologies if this is the wrong mailing list - please direct me to the
correct one if so.
I believe I've found a bug in OpenJDK 1.8.0_40, introduced in commit
d777e2918
normally don't use single
line "{"".
- 159InetAddress.getByName(ipAddress)))
- 160 {
+ 159InetAddress.getByName(ipAddress))) {
Please add a "noreg-" tag if no plan to add a new regression test.
Thanks,
Xuelei
On 1/29/2015 12:10 AM
Ping?
-Rob
On 28/01/15 16:10, Rob McKenna wrote:
Hi folks,
There is a problem in sun/security/util/HostnameChecker.java matchIP
method. When comparing an ipv6 address with its abbreviated
counterpart the comparison will fail. I'm open to a more efficient way
of comparing
Hi folks,
There is a problem in sun/security/util/HostnameChecker.java matchIP
method. When comparing an ipv6 address with its abbreviated counterpart
the comparison will fail. I'm open to a more efficient way of comparing
these addresses (perhaps a utility method to abbreviate an ipv6 string)
Gah, apologies, forgot about your note:
Removal of change to java.security.spec.MGF1ParameterSpec to avoid
introducing a new public variable.
No CCC needed.
-Rob
On 23/12/14 16:56, Rob McKenna wrote:
Actually, another kink: this requires ccc approval for a backport to 7.
-Rob
Actually, another kink: this requires ccc approval for a backport to 7.
-Rob
On 23/12/14 16:52, dalibor.to...@oracle.com wrote:
Considering that the issue was a P3 RFE rather than a high priority bug fix,
it's not clear to me why it would be necessary to backport it into 7u80, at
the end
2014 9:37 PM, Rob McKenna wrote:
Hi folks,
A simple change to use SSLHandshakeException instead of
RuntimeException
in getAgreedSecret in DHCrypt and ECDHCrypt. This will prevent these
RuntimeExceptions from propagating to the application and allow
application programmers to handl
Hi folks,
When repeatedly gathering small amounts of random data the SUN provider
is quicker ucrypto / pkcs11. This proposed fix from Brad allows ucrypto
/ pkcs11 leverage the SUN SHA1 provider for SHA1PRNG. This allows us to
avoid the overhead of calling into the native level repeatedly for s
Hi folks,
A simple change to use SSLHandshakeException instead of RuntimeException
in getAgreedSecret in DHCrypt and ECDHCrypt. This will prevent these
RuntimeExceptions from propagating to the application and allow
application programmers to handle them as SSLHandshakeExceptions.
http://cr.
Thanks Sean, will do.
-Rob
On 16/05/14 17:52, Sean Mullan wrote:
Looks ok to me. While you are in there, can you fix the typo a couple
lines above that:
s/Retuns/Returns
You also need to add an appropriate "noreg" label to the bug.
--Sean
On 05/16/2014 10:29 AM, Rob McKenna
Hi folks,
The synopsis says it all really. There is an unsynchronized code path
from javax.crypto.Cipher to the WeakHashMap used by JceSecurity to store
codebase mappings. While this bug is extremely unlikely to manifest we
have a couple of reports of it in the wild.
As you can see from the
Changeset: da4b0962ad11
Author:robm
Date: 2014-02-10 14:35 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da4b0962ad11
7152892: some jtreg tests fail with permission denied
Reviewed-by: coffeys
! test/java/lang/ClassLoader/Assert.sh
! test/java/rmi/registry/readTest/readTest
Changeset: 72ea199e3e1b
Author:robm
Date: 2013-12-05 16:19 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/72ea199e3e1b
8029525: java/lang/ProcessBuilder/Basic.java fails intermittently
Reviewed-by: alanb, chegar
Contributed-by: roger.ri...@oracle.com
! test/java/lang/Process
Changeset: 63b696dafc8a
Author:robm
Date: 2013-11-19 15:36 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/63b696dafc8a
8022206: Intermittent test failures in java/lang/ProcessBuilder/Basic.java
Reviewed-by: chegar, alanb
! test/java/lang/ProcessBuilder/Basic.java
Changeset: e2ec05b2ed94
Author:igerasim
Date: 2013-10-23 15:37 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e2ec05b2ed94
8024521: (process) Async close issues with Process InputStream
Reviewed-by: psandoz, martin, alanb, robm
! src/solaris/classes/java/lang/UNIXProcess.jav
Changeset: 8d1d5a5aeb41
Author:robm
Date: 2013-10-18 16:28 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d1d5a5aeb41
8024660: TEST_BUG: java/lang/ProcessBuilder/*IOHandle.java leaving hotspot.log
open in fastdebug builds
Reviewed-by: alanb
Contributed-by: pavel.pune...@ora
Changeset: d8eec0e3a023
Author:robm
Date: 2013-10-16 15:06 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d8eec0e3a023
8026245: InetAddress.getLocalHost crash if IPv6 disabled (macosx)
Reviewed-by: chegar, alanb
! src/solaris/native/java/net/Inet4AddressImpl.c
! src/solaris/
Changeset: f1e31376f419
Author:robm
Date: 2013-10-09 00:10 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f1e31376f419
7180557: InetAddress.getLocalHost throws UnknownHostException on java7u5 on OSX
webbugs
Reviewed-by: chegar, dsamersoff
! src/solaris/native/java/net/Inet4
Changeset: a4b0be7341ef
Author:robm
Date: 2013-08-13 19:10 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a4b0be7341ef
5049299: (process) Use posix_spawn, not fork, on S10 to avoid swap exhaustion
Reviewed-by: alanb, dholmes, martin, erikj, coffeys
! make/java/java/Exportedf
Changeset: 607fa1ff3de2
Author:bpb
Date: 2013-07-09 11:26 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/607fa1ff3de2
6178739: (fmt) Formatter.format("%0.4f\n", 56789.456789) generates
MissingFormatWidthException
Summary: Change the field width specification to require a pos
Changeset: 2707f600a096
Author:robm
Date: 2013-06-15 09:26 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/2707f600a096
8016701: JAXP Build failure
Reviewed-by: darcy, wetmore, alanb, chegar
! src/com/sun/org/apache/xalan/internal/xsltc/runtime/BasisLibrary.java
Changeset: d28f802ce914
Author:robm
Date: 2013-06-06 22:22 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d28f802ce914
8016063: getFinalAttributes should use FindClose
Reviewed-by: alanb
! src/windows/native/java/io/WinNTFileSystem_md.c
Changeset: b16a8b4ae6b4
Author:robm
Date: 2013-05-28 16:35 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b16a8b4ae6b4
7038105: File.isHidden() should return true for pagefile.sys and hiberfil.sys
Reviewed-by: alanb
! src/windows/native/java/io/WinNTFileSystem_md.c
! test/ja
Changeset: 3f8fbb0ab155
Author:robm
Date: 2013-03-21 17:33 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f8fbb0ab155
8009251: Add proxy handling and keep-alive fixes to jsse
Reviewed-by: chegar
! src/share/classes/sun/net/www/http/HttpClient.java
!
src/share/classes/sun/n
Changeset: f5c85c0a9af0
Author:robm
Date: 2013-03-14 00:21 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f5c85c0a9af0
8009650: HttpClient available() check throws SocketException when connection
has been closed
Reviewed-by: chegar, khazra, dsamersoff
Contributed-by: sdoug..
Changeset: 44d6cabc9a3f
Author:robm
Date: 2013-01-15 19:58 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/44d6cabc9a3f
8005618: TEST_BUG: java/lang/ProcessBuilder/Basic.java failing intermittently
Reviewed-by: alanb, martin, dholmes
! test/java/lang/ProcessBuilder/Basic.java
Changeset: 68374c6e65c1
Author:robm
Date: 2012-12-12 15:57 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/68374c6e65c1
8004337: java/sql tests aren't run in test/Makefile
Reviewed-by: lancea, alanb
! test/Makefile
Changeset: 40311b5f478f
Author:robm
Date: 2012-11-28 00:47 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/40311b5f478f
8003597: TEST_BUG: Eliminate dependency on javaweb from closed net tests
Reviewed-by: chegar
+ test/java/net/ResponseCache/Test.java
+ test/java/net/Socket/
Changeset: c0736b62160e
Author:robm
Date: 2012-10-15 22:34 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c0736b62160e
8000487: Java JNDI connection library on ldap conn is not honoring configured
timeout
Reviewed-by: vinnie
! src/share/classes/com/sun/jndi/ldap/Connection.
Changeset: 7c2f5e52863c
Author:robm
Date: 2012-10-11 18:24 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7c2f5e52863c
7152183: TEST_BUG: java/lang/ProcessBuilder/Basic.java failing intermittently
[sol]
Reviewed-by: alanb, martin, dholmes
! test/java/lang/ProcessBuilder/Bas
Changeset: bba370caafad
Author:robm
Date: 2012-10-04 19:53 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bba370caafad
7184932: Remove the temporary Selector usage in the NIO socket adapters
Reviewed-by: alanb
! make/java/nio/mapfile-bsd
! make/java/nio/mapfile-linux
! make/
Changeset: b3c7a3138c5d
Author:robm
Date: 2012-09-28 04:39 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b3c7a3138c5d
7199219: Proxy-Connection headers set incorrectly when a HttpClient is
retrieved from the Keep Alive Cache
Reviewed-by: chegar
! src/share/classes/sun/net/
Changeset: 11a5da68673c
Author:robm
Date: 2012-09-27 22:35 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11a5da68673c
7199862: Make sure that a connection is still alive when retrieved from
KeepAliveCache in certain cases
Reviewed-by: chegar
! src/share/classes/sun/net/www
Changeset: 59aa7660ade4
Author:robm
Date: 2012-08-20 14:52 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/59aa7660ade4
7191777: test/java/lang/ProcessBuilder/Basic.java failing intermittently due to
additions for 4244896
Reviewed-by: dholmes, alanb
! test/java/lang/ProcessB
Changeset: da14e2c90bcb
Author:robm
Date: 2012-08-15 22:46 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da14e2c90bcb
6931128: (spec) File attribute tests fail when run as root.
Reviewed-by: alanb
! src/share/classes/java/io/File.java
! test/java/io/File/Basic.java
! test/j
Changeset: 516e0c884af2
Author:robm
Date: 2012-07-09 22:26 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/516e0c884af2
7179305: (fs) Method name sun.nio.fs.UnixPath.getPathForExecptionMessage is
misspelled
Reviewed-by: dholmes, chegar
! src/solaris/classes/sun/nio/fs/LinuxU
Changeset: ecc5dd3790a1
Author:robm
Date: 2012-07-02 19:32 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ecc5dd3790a1
7174887: Deadlock in jndi ldap connection cleanup
Reviewed-by: xuelei
! src/share/classes/com/sun/jndi/ldap/Connection.java
! src/share/classes/com/sun/jndi
Changeset: ff0da4ea08a2
Author:robm
Date: 2012-06-26 13:27 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ff0da4ea08a2
4244896: (process) Provide System.getPid(), System.killProcess(String pid)
Reviewed-by: alanb
! src/share/classes/java/lang/Process.java
! src/solaris/class
Changeset: a7895dc61088
Author:robm
Date: 2012-06-08 18:23 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a7895dc61088
7161881: (dc) DatagramChannel.bind(null) fails if IPv4 socket and running with
preferIPv6Addresses=true
Reviewed-by: alanb, chegar
! src/share/classes/sun/
Changeset: 178c480998b1
Author:robm
Date: 2012-05-17 22:42 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/178c480998b1
7168110: Misleading jstack error message
Reviewed-by: alanb, dsamersoff
! src/windows/native/sun/tools/attach/WindowsVirtualMachine.c
Changeset: b26c04717735
Author:robm
Date: 2012-05-07 13:34 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b26c04717735
7166687: InetAddress.getLocalHost().getHostName() returns FQDN
Reviewed-by: chegar
! src/solaris/native/java/net/Inet6AddressImpl.c
Changeset: b700f85a8f29
Author:robm
Date: 2012-04-17 07:14 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b700f85a8f29
7118373: (se) Potential leak file descriptor when deregistrating at around the
same time as an async close
Reviewed-by: alanb
! src/share/classes/sun/nio/c
Changeset: f642c9ec81a0
Author:robm
Date: 2010-11-15 10:46 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/f642c9ec81a0
6277781: Serialization of Enums over IIOP is broke.
Summary: Reviewed by Ken Cavanaugh
Reviewed-by: coffeys
! src/share/classes/com/sun/corba/se/impl/io/I
63 matches
Mail list logo
