Re: 7194075: Various classes of sunec.jar are duplicated in rt.jar

2013-01-15 Thread Stephen Flores
Sean, Here are the changes for the final version (as outlined in my comments below): http://cr.openjdk.java.net/~sflores/7194075/webrev-2/ Steve. On 12/19/2012 07:23 PM, Stephen Flores wrote: Sorry, for the delayed response, I have been working in another area. Comments below: On 11/29

Re: 7194075: Various classes of sunec.jar are duplicated in rt.jar

2012-12-19 Thread Stephen Flores
rSpec(Provider p, String name) For named curves, is it possible to make methods like this one to be provider independent? Again, a calling class will have already obtained the EC provider they intend to use. Steve. Regards, Xuelei On 11/27/2012 11:21 AM, Stephen Flores wrote: Vincent,

Re: 7194075: Various classes of sunec.jar are duplicated in rt.jar

2012-12-19 Thread Stephen Flores
--Sean On 11/26/2012 10:21 PM, Stephen Flores wrote: Vincent, Sean, Please review the fix for: CR 7194075: Various classes of sunec.jar are duplicated in rt.jar http://cr.openjdk.java.net/~sflores/7194075/webrev-1/ Changes: *Changed/renamed any of methods that did not support the

7194075: Various classes of sunec.jar are duplicated in rt.jar

2012-11-26 Thread Stephen Flores
Vincent, Sean, Please review the fix for: CR 7194075: Various classes of sunec.jar are duplicated in rt.jar http://cr.openjdk.java.net/~sflores/7194075/webrev-1/ Changes: *Changed/renamed any of methods that did not support the public API to package private. *Moved the decode and encode p

Re: 7194449: String resources for Key Tool and Policy Tool should be in their respective packages

2012-10-05 Thread Stephen Flores
f the Resources* classes. Send me the latest patch when you are ready and I will push it for you. --Sean On 9/20/12 9:49 PM, Stephen Flores wrote: Max, Sean, Alan, Please review this webrev: http://cr.openjdk.java.net/~sflores/7194449/webrev-0/ Note: I will respond to any comments when

Re: 7194449: String resources for Key Tool and Policy Tool should be in their respective packages

2012-10-03 Thread Stephen Flores
On 10/02/2012 06:32 AM, Alan Bateman wrote: On 02/10/2012 03:57, Stephen Flores wrote: : Alan, I am going to take you advice and push back on feature creep, I need to stick plan we agreed to and that I put in the CR, so I can move back to complete sun.security.ec decoupling work and I

Re: 7194449: String resources for Key Tool and Policy Tool should be in their respective packages

2012-10-01 Thread Stephen Flores
On 09/21/2012 06:29 AM, Alan Bateman wrote: On 21/09/2012 02:49, Stephen Flores wrote: Max, Sean, Alan, Please review this webrev: http://cr.openjdk.java.net/~sflores/7194449/webrev-0/ Note: I will respond to any comments when I get back from vacation on Monday Oct. 1. Changes: Moved

Re: 7194449: String resources for Key Tool and Policy Tool should be in their respective packages

2012-10-01 Thread Stephen Flores
1/2012 09:49 AM, Stephen Flores wrote: Max, Sean, Alan, Please review this webrev: http://cr.openjdk.java.net/~sflores/7194449/webrev-0/ Note: I will respond to any comments when I get back from vacation on Monday Oct. 1. Changes: Moved jarsigner and keytool into their own packages as was done for p

Re: 7194449: String resources for Key Tool and Policy Tool should be in their respective packages

2012-10-01 Thread Stephen Flores
already figured out all cases. Thanks Max On 09/21/2012 09:49 AM, Stephen Flores wrote: Max, Sean, Alan, Please review this webrev: http://cr.openjdk.java.net/~sflores/7194449/webrev-0/ Note: I will respond to any comments when I get back from vacation on Monday Oct. 1. Changes: Move

7194449: String resources for Key Tool and Policy Tool should be in their respective packages

2012-09-20 Thread Stephen Flores
Max, Sean, Alan, Please review this webrev: http://cr.openjdk.java.net/~sflores/7194449/webrev-0/ Note: I will respond to any comments when I get back from vacation on Monday Oct. 1. Changes: Moved jarsigner and keytool into their own packages as was done for policytool. Unit tests and

Re: Code review request: 7197245: Eliminate sun.security.ssl.JsseJce dependency on sun.security.ec

2012-09-12 Thread Stephen Flores
Vincent, It seems like we are work on same area, except I have a larger scope. The JSSE is not the only package to have sun.security.ec dependencies, PKCS 11 has them plus the Public and private key class and the EC unit test. I have same type of changes in mind so I can remove the duplicate

Re: 6995421: Eliminate the static dependency to sun.security.ec.ECKeyFactory

2012-07-31 Thread Stephen Flores
look good. Thanks. On 20/07/2012 21:18, Stephen Flores wrote: Please review the following webrev: http://cr.openjdk.java.net/~sflores/6995421/ for bug: 6995421 Eliminate the static dependency to sun.security.ec.ECKeyFactory Description of the problem: sun.security.x509.AlgorithmId and

6995421: Eliminate the static dependency to sun.security.ec.ECKeyFactory

2012-07-20 Thread Stephen Flores
Please review the following webrev: http://cr.openjdk.java.net/~sflores/6995421/ for bug: 6995421 Eliminate the static dependency to sun.security.ec.ECKeyFactory Description of the problem: sun.security.x509.AlgorithmId and sun.security.pkcs11.P11ECKeyFactory depend on an public static fiel