[9] RFR:8178083 Remove intermittent key from java/security/SignedObject/Chain.java

2017-04-13 Thread Tim Du
Hi All, Would you help to review the path for "8178083:Remove intermittent key from java/security/SignedObject/Chain.java"? JDK-8136842 has been closed, @key intermittent can be removed.Thanks. JBS: https://bugs.openjdk.java.net/browse/JDK-8178083 webrev: http://cr.openjdk.java.net/~tidu/8178

[9] RFR:8168769: javax/net/ssl/TLSv12/DisabledShortRSAKeys.java timed out

2016-12-22 Thread Tim Du
Hi All: Would like help to review the code change for javax/net/ssl/TLSv12/DisabledShortRSAKeys.java? The test case failed with synchronization test issue between client and server intermittently, use advantage of SSLSocketSample.java to make stable and get rid of duplicate codes.Thanks. JB

[9] RFR JDK-8157529 : Remove intermittent key from javax/net/ssl/DTLS/CipherSuite.java

2016-11-30 Thread Tim Du
Hi , Would you help to review the path for "8157529:Remove intermittent key from javax/net/ssl/DTLS/CipherSuite.java" , the intermittently failed issue was fixed by JDK-8167680 , '@key intermittent ' can be removed.Thanks. JBS: https://bugs.openjdk.java.net/browse/JDK-8157529 webrev: http://c

Re: [9] RFR: JDK-8164322: sun/security/pkcs11/PKCS11Test.java shall be updated to run on ARM platforms

2016-09-30 Thread Tim Du
Thanks Xuelei review it. Latest webrev available here :http://cr.openjdk.java.net/~tidu/8164322/webrev.02/ ,Please help to review it. Thanks Regards Tim On 2016/9/29 18:16, Xuelei Fan wrote: On 9/29/2016 5:36 PM, Tim Du wrote: Thank you for reviewing the codes. Remove the codes which throw

Re: [9] RFR: JDK-8164322: sun/security/pkcs11/PKCS11Test.java shall be updated to run on ARM platforms

2016-09-29 Thread Tim Du
Thank you for reviewing the codes. Remove the codes which throw exception and add codes could show machine not installed NSS library information. The latest code is here: http://cr.openjdk.java.net/~tidu/8164322/webrev.01/ ,please help to review it. For whether throw exception caused by OS/ma

[9] RFR: JDK-8164322: sun/security/pkcs11/PKCS11Test.java shall be updated to run on ARM platforms

2016-09-27 Thread Tim Du
Hi All: Would you help to review the patch for sun/security/pkcs11/PKCS11Test.java? The test keep pass on not supported platforms, it will make nobody notice the test was skipped,which is not our expected. Update case to show failure, when platform not supported. And add the support for Linux

Re: [9] RFR:8160337 Remove intermittent key from sun/security/pkcs11/rsa/TestKeyPairGenerator.java

2016-07-21 Thread Tim Du
a key "randomness" should be retained. Thanks, Rajan On 7/6/16 1:04 AM, Tim Du wrote: Hi All, Would you help to review the path for "8160337:Remove intermittent key from sun/security/pkcs11/rsa/TestKeyPairGenerator.java"? JDK-8074580 has been fixed, @key intermittent can be rem

Re: [9] RFR: JDK-7052815 Change tests that remove or add providers to run in othervm mode

2016-07-07 Thread Tim Du
Updated copyright , new webrev here: http://cr.openjdk.java.net/~tidu/7052815/webrev.02/ Please help to review them ,Thanks. Regards Tim On 2016/7/8 1:30, Rajan Halade wrote: Hi Tim, Please also update the copyright year to 2016 wherever applicable. Thanks, Rajan On 7/7/16 2:11 AM, Tim Du

Re: [9] RFR: JDK-7052815 Change tests that remove or add providers to run in othervm mode

2016-07-07 Thread Tim Du
oviders.java: 28 * @run main/othrevm RemoveProviders s/othrevm/othervm/ --Sean On 07/05/2016 08:11 AM, Tim Du wrote: Hi , Please help to review the path for "JDK-7052815 :Finish checking of 7052537" . A few test are using removedProvider() to removed the security provider,like JDK-7

[9] RFR:8160337 Remove intermittent key from sun/security/pkcs11/rsa/TestKeyPairGenerator.java

2016-07-06 Thread Tim Du
Hi All, Would you help to review the path for "8160337:Remove intermittent key from sun/security/pkcs11/rsa/TestKeyPairGenerator.java"? JDK-8074580 has been fixed, @key intermittent can be removed.Thanks. JBS: https://bugs.openjdk.java.net/browse/JDK-8160337 webrev: http://cr.openjdk.java.net

[9] RFR:8160339 Remove intermittent key from javax/net/ssl/templates/SSLSocketSSLEngineTemplate.java

2016-07-06 Thread Tim Du
Hi, Please help to review the path for "8160339:Remove intermittent key from javax/net/ssl/templates/SSLSocketSSLEngineTemplate.java ", JDK-8049314 has been fixed, and no bug is tracking issue on this test, @key intermittent can be removed.Thanks. JBS: https://bugs.openjdk.java.net/browse/JD

[9] RFR: JDK-7052815 Finish checking of 7052537

2016-07-05 Thread Tim Du
Hi , Please help to review the path for "JDK-7052815 :Finish checking of 7052537" . A few test are using removedProvider() to removed the security provider,like JDK-7052537, If the tests not in othervm,it will affect other tests. Checking tests which are using removedProvider() for security

[9] RFR:8160333:Remove intermittent key from javax/net/ssl/TLSv12/ShortRSAKey512.java

2016-07-04 Thread Tim Du
Hi, Please help to review the path for javax/net/ssl/TLSv12/ShortRSAKey512.java , JDK-8159501 has been fixed, and no bug is tracking issue on this test, @key intermittent can be removed.Thanks. JBS: https://bugs.openjdk.java.net/browse/JDK-8160333 webrev: http://cr.openjdk.java.net/~tidu/816

[9] RFR 8160415:Mark sun/security/tools/keytool/standard.sh as intermittently failing

2016-06-29 Thread Tim Du
Hi , May I request to review for marking test sun/security/tools/keytool/standard.sh with key intermittent, it has been seen intermittently failed JDK-8144806 . bug: https://bugs.openjdk.java.net/browse/JDK-8160415 webrev: http://cr.openjdk.java.net/~tidu/8160415/webrev.00/ diff -r 73e1dc203

Re: [9] RFR 8146393:sun/security/tools/jarsigner/ts.sh failed on OEL Linux 7 with ar_SA Locale

2016-06-22 Thread Tim Du
. Regards Tim Thanks Max On Jun 22, 2016, at 2:50 PM, Tim Du wrote: Hi, Would you please review the path for following bug? bug: https://bugs.openjdk.java.net/browse/JDK-8146393 webrev: http://cr.openjdk.java.net/~tidu/8146393/webrev.00/ The test failed when using String.format() to format the

[9] RFR 8146393:sun/security/tools/jarsigner/ts.sh failed on OEL Linux 7 with ar_SA Locale

2016-06-21 Thread Tim Du
Hi, Would you please review the path for following bug? bug: https://bugs.openjdk.java.net/browse/JDK-8146393 webrev: http://cr.openjdk.java.net/~tidu/8146393/webrev.00/ The test failed when using String.format() to format the server port on ar_SA Locale, Adding Locale.ROOT arguments to avoid

Re: [9] RFR:JDK-8143305:sun/security/ec/TestEC.java fails intermittently

2016-06-03 Thread Tim Du
6/3 4:38, Sean Mullan wrote: On 06/02/2016 06:16 AM, Tim Du wrote: Hi, Please help to review the path for JDK-8143305 TestEC.java test for ECC algorithms in SSL/TLS with different cipher suites. It failed with javax.net.ssl.SSLException: Unsupported or unrecognized SSL message intermittently.

[9] RFR:JDK-8143305:sun/security/ec/TestEC.java fails intermittently

2016-06-02 Thread Tim Du
Hi, Please help to review the path for JDK-8143305 TestEC.java test for ECC algorithms in SSL/TLS with different cipher suites. It failed with javax.net.ssl.SSLException: Unsupported or unrecognized SSL message intermittently. The exception was threw at step of handshaking, I was not able to

Re: [9] RFR 8134487:updated sun/security/ssl/StatusStapling/* to work with modules

2016-02-17 Thread Tim Du
On 2/17/2016 11:40 PM, Alan Bateman wrote: On 17/02/2016 09:57, Tim Du wrote: Sure. I am aslo updated java.base/sun/security/testlibrary to test/java/security/testlibrary/ , so that keep the testlibrary files could be reused by other tests. Re-generate the latest webrev is http

Re: [9] RFR 8134487:updated sun/security/ssl/StatusStapling/* to work with modules

2016-02-17 Thread Tim Du
On 2/17/2016 4:23 PM, Alan Bateman wrote: On 17/02/2016 08:19, Tim Du wrote: Follow you suggestion, I updated the code as below: 1.Create java.base/sun/security/ssl under test/sun/security/ssl/StatusStapling/, move all test files and dependency class into java.base/sun/security/ssl ,removed

Re: [9] RFR 8134487:updated sun/security/ssl/StatusStapling/* to work with modules

2016-02-17 Thread Tim Du
Hi Alan: On 2/16/2016 7:25 PM, Alan Bateman wrote: On 16/02/2016 11:05, Tim Du wrote: Hi Alan: I tried @compile/module to fix this issue before, but it does not work ,Use CertStatusReqExtensionTests.java as example, the process as below: 1. Create java.base/sun/security/ssl folder in

Re: [9] RFR 8134487:updated sun/security/ssl/StatusStapling/* to work with modules

2016-02-16 Thread Tim Du
va Build and run CertStatusReqExtensionTest.java by a wrapper could work , and I saw some existing tests were written in this way.So I think this is a valid solution.Thanks. Regards Tim On 2/16/2016 3:47 PM, Alan Bateman wrote: On 16/02/2016 03:31, Tim Du wrote: Hi All: Please help to revi

[9] RFR 8134487:updated sun/security/ssl/StatusStapling/* to work with modules

2016-02-15 Thread Tim Du
Hi All: Please help to review the fix for Jigsaw test bug.Thanks. Bug: https://bugs.openjdk.java.net/browse/JDK-8134487 Webrev: http://cr.openjdk.java.net/~tidu/8134487/webrev.01/ The test to access non-public class.To workaround the issue , I create the test wrapper to compile test class into

Re: FYI.... Fwd: Re: [9] RFR:JDK-8076359:Test Task: Develop new tests for Leverage CPU Instructions for GHASH and RSA

2015-11-10 Thread Tim Du
suggest renaming to "PreferredProviderNegativeTest". s/negativeProvier/negativeProvider --Sean The changes look good to me. I assume these tests pass? thanks Tony On 11/05/2015 12:22 AM, Tim Du wrote: Hi Tony: Thanks for reviewing the codes. Updated them follow your suggestion here: http://cr.openj

Re: [9] RFR:JDK-8076359:Test Task: Develop new tests for Leverage CPU Instructions for GHASH and RSA

2015-11-05 Thread Tim Du
execution. If so,Could I plan to push the code into openjdk repo? Thanks Regards Tim thanks Tony On 11/05/2015 12:22 AM, Tim Du wrote: Hi Tony: Thanks for reviewing the codes. Updated them follow your suggestion here: http://cr.openjdk.java.net/~fyuan/tim/8076359/webrev.01/ ,please help to

Re: [9] RFR:JDK-8076359:Test Task: Develop new tests for Leverage CPU Instructions for GHASH and RSA

2015-11-05 Thread Tim Du
Hi Tony: Thanks for reviewing the codes. Updated them follow your suggestion here: http://cr.openjdk.java.net/~fyuan/tim/8076359/webrev.01/ ,please help to review again. Regards Tim On 11/5/2015 6:19 AM, Anthony Scarpino wrote: On 11/03/2015 05:55 PM, Tim Du wrote: Hi All: Please help to

[9] RFR:JDK-8076359:Test Task: Develop new tests for Leverage CPU Instructions for GHASH and RSA

2015-11-03 Thread Tim Du
Hi All: Please help to review testing Preferred provider configuration feature for JCE . JBS: https://bugs.openjdk.java.net/browse/JDK-8076359 https://bugs.openjdk.java.net/browse/JDK-8133151 webrev: http://cr.openjdk.java.net/~fyuan/tim/8076359/webrev.00/ Thank you very much. Regards Tim

[9] RFR:JDK-8077806:mismatch comment and code in CipherSuite.java

2015-10-16 Thread Tim Du
Hi All: Please help to review for fixing one comments issue: webrev: http://cr.openjdk.java.net/~fyuan/tim/8077806/webrev/ Issue: https://bugs.openjdk.java.net/browse/JDK-8077806 Thank you very much. Regards Tim