Re: RFR: 8284209: Replace remaining usages of 'a the' in source code

On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > It's the last issue in the series, and it still touches different areas of > the code. javac and javadoc changes look OK

Integrated: JDK-8286348: incorrect use of `@serial`

On Sat, 7 May 2022 01:04:03 GMT, Jonathan Gibbons wrote: > Please review a fix to remove incorrect use of the `@serial` tag from the doc > comments for methods such as `readObject` and `readResolve`. The tag has no > effect in this position other than to trigger warnings from the

Re: RFR: JDK-8286348: incorrect use of `@serial` [v3]

odule, there > is one outlier, in `java.security.Provider`. Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision: Fix whitespace (blank lines) after merge - Changes: - all: https://git.openjdk.java.net/j

Re: RFR: JDK-8286348: incorrect use of `@serial` [v2]

odule, there > is one outlier, in `java.security.Provider`. Jonathan Gibbons has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge with upstream/master - JDK-8286348: incorrect use of `@serial` - Changes:

Re: RFR: JDK-8286348: incorrect use of `@serial`

On Sun, 8 May 2022 02:19:09 GMT, Phil Race wrote: > Jon, all of the changes in java.desktop are already underway in > https://github.com/openjdk/jdk/pull/8432/files and > have been approved and even have an approved CSR .. just waiting for > @alisenchung to type /integrate .. Thanks for the

RFR: JDK-8286348: incorrect use of `@serial`

Please review a fix to remove incorrect use of the `@serial` tag from the doc comments for methods such as `readObject` and `readResolve`. The tag has no effect in this position other than to trigger warnings from the standard doclet when running javadoc. There is no change to the generated

Re: RFR: JDK-8285676: Add missing @param tags for type parameters on classes and interfaces

On Tue, 26 Apr 2022 22:24:26 GMT, Joe Darcy wrote: > To enable more complete doclint checking (courtesy @jonathan-gibbons), please > review this PR to add type-level @param tags where they are missing. > > To the maintainers of java.util.concurrent, those changes could be sepa

Re: RFR: 8257733: Move module-specific data from make to respective module [v13]

On Mon, 21 Mar 2022 16:29:25 GMT, Magnus Ihse Bursie wrote: >> A lot (but not all) of the data in make/data is tied to a specific module. >> For instance, the publicsuffixlist is used by java.base, and fontconfig by >> java.desktop. (A few directories, like mainmanifest, is *actually* used by

Re: RFR: 8279918: Fix various doc typos [v2]

On Thu, 13 Jan 2022 14:01:04 GMT, Pavel Rappo wrote: >> - Most of the typos are of a trivial kind: missing whitespace. >> - If any of the typos should be fixed in the upstream projects instead, >> please say so; I will drop those typos from the patch. >> - As I understand it, ` ` in

Re: RFR: 8279918: Fix various doc typos [v2]

On Thu, 13 Jan 2022 11:40:20 GMT, Lance Andersen wrote: >> OK, so lines 264, 295, 329, 364, 431 are arguably wrong as well? >> Separating the [] completely looks quite rare. >> I'll leave it up to you. 8-) > > I think that can be a follow on clean up. The strange formatting of `long

Re: RFR: 8263105: security-libs doclint cleanup

On Sat, 6 Mar 2021 07:31:09 GMT, Bradford Wetmore wrote: > Fix various things pointed out by the most recent doclint run in the > security-libs area. > > This is docs only: I will be checking doccheck/doclint, and will be running > tier1/tier2 tests. Minor spot checks on generated files.

Integrated: JDK-8263104: fix warnings for empty paragraphs

On Fri, 5 Mar 2021 19:36:13 GMT, Jonathan Gibbons wrote: > Please review some simple cleanup for empty `` tags. > > Two of the tags are completely redundant, and simply deleted. > > The other three, in _package.html_ files are generally undesirable. Although > the presumed

RFR: JDK-8262875: doccheck: empty paragraphs, etc in java.base module

Please review some minor doc fixes, for issues found by _doccheck_.There are two kinds of errors that are addressed. 1. Incorrect use of ``. In HTML, `` marks the *beginning* of a paragraph. It is not a terminator, to mark the end of a paragraph, or a separator to mark the boundary between

Re: RFR: 8257733: Move module-specific data from make to respective module [v2]

On Mon, 7 Dec 2020 14:27:45 GMT, Magnus Ihse Bursie wrote: >> A lot (but not all) of the data in make/data is tied to a specific module. >> For instance, the publicsuffixlist is used by java.base, and fontconfig by >> java.desktop. (A few directories, like mainmanifest, is *actually* used by

Integrated: JDK-8255262: Remove use of legacy custom @spec tag

On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote: > The change is (just) to remove legacy usages of a JDK-private custom tag. This pull request has now been integrated. Changeset: 0aa3c925 Author: Jonathan Gibbons URL: https://git.openjdk.java.net/jdk/commit/0aa3c925 St

RFR: JDK-8255262: Remove use of legacy custom @spec tag

The change is (just) to remove legacy usages of a JDK-private custom tag. - Commit messages: - JDK-8255262: Remove use of legacy custom @spec tag Changes: https://git.openjdk.java.net/jdk/pull/814/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=814=00 Issue:

Re: RFR: 8252999: Cleanup: replace .equals("") with .isEmpty() within all codebase

On Thu, 10 Sep 2020 12:04:48 GMT, Dmitriy Dumanskiy wrote: > I have in mind dozens of improvements all over the code like this one. That sounds scary. Broad updates like these cause unnecessary churn in the codebase, and can make merging and back porting harder. Changes should be discussed

Re: Fix for Javadoc errors in java.base

On 8/13/20 10:13 AM, Sean Mullan wrote: On 8/13/20 11:05 AM, Julia Boes wrote: Hi Vipin, Thanks for providing this fix, I'm happy to sponsor your change. To complete the review, we still need someone to green light the remaining changes below. I'm looping in net-dev and security-dev to

FYI: new javadoc tag to document system properties

This is an FYI to announce some initial, long-overdue support in javadoc for documenting system properties (JDK-5076751). Currently, system properties are just documented using ad-hoc narrative text, which is fine if you know where to look for any given property. JDK 12 introduces a new

Re: RFR [12]: 8211878: Bad/broken links in docs/api/java.xml.crypto/javax/xml/crypto/dsig/Reference.html

Looks good to me. -- Jon On 10/10/18 9:33 AM, Sean Mullan wrote: Please review this trivial fix to correct a couple of broken hyperlinks: diff --git a/src/java.xml.crypto/share/classes/javax/xml/crypto/dsig/Reference.java

Re: RFR: JDK-8210274: Source Launcher should work with a security manager

On 09/11/2018 12:53 PM, Sean Mullan wrote: I have looked over the changes and they look reasonable, though I am not very familiar with this code. I was wondering, when running with the PermissiveTestSecurityManager did you also have to enable security debugging (ex:

Re: RFR: JDK-8210274: Source Launcher should work with a security manager

Alan, Thanks for all the feedback. I'll add the extra test case you suggest. -- Jon On 09/11/2018 12:34 PM, Alan Bateman wrote: On 11/09/2018 19:42, Jonathan Gibbons wrote: : As regards the interaction between Source Launcher and the use of a security manager, I see 3 possibilities: 1

Re: RFR: JDK-8210274: Source Launcher should work with a security manager

On 9/11/18 12:58 AM, Alan Bateman wrote: On 10/09/2018 21:37, Jonathan Gibbons wrote: Please review a patch to have the Source Launcher be able to work when a security manager is enabled. It's not clear to me that this is an interesting use-case but in any case I think you've got two

RFR: JDK-8210274: Source Launcher should work with a security manager

Please review a patch to have the Source Launcher be able to work when a security manager is enabled. There are 4 parts to the work: an update to the default policy file, an update to the source launcher itself, updates to tests, and a custom security manager to help with testing. 1.

Re: RFR: JDK-8186160 Fix a11y issues in java.security package

Wetmore wrote: Changes look good to me, although I'm not an HTML expert nor an expert in our current documentation style. I did compare the output, and can see the effects. (Striped, scope (row vs col), style) Brad On 8/11/2017 5:01 PM, Jonathan Gibbons wrote: Please review the following small

RFR: JDK-8186160 Fix a11y issues in java.security package

Please review the following small fix for some accessibility issues in the java.security package. 3 tables are converted to the de-facto JDK standard for row-oriented tables, and updated with appropriate scope=row|col attributes to identify the header cell in each row or column. You can see

Re: RFR: 8184208: update class="striped" tables for accessibility

On 07/11/2017 04:02 PM, Brian Burkhalter wrote: On Jul 11, 2017, at 2:39 PM, Jonathan Gibbons <jonathan.gibb...@oracle.com <mailto:jonathan.gibb...@oracle.com>> wrote: Please review this auto-generated update to improve the accessibility of many of the tables in

RFR: 8184208: update class="striped" tables for accessibility

Please review this auto-generated update to improve the accessibility of many of the tables in the API docs for the java.base module. The changes are just to the HTML markup for selected tables; there is no change to the wording of any documentation. This update was generated by a utility

Re: RFR: [Updated] Update tables in java.base to be HTML5-friendly.

Martin, I've worked with Bhavesh to sort out these issues. The inconsistency in the syntax has been fixed. The CSS could be more compact ... if we did not have to deal with nested tables. It was also a goal to simplify the use for the doc comment author, such that it was possible to put

Re: RFR: [Updated] Update tables in java.base to be HTML5-friendly.

-8179592/8179479/webrev.01/ jdk (changes to java.base): http://cr.openjdk.java.net/~jjg/8179479-8179592/8179592/webrev.01/ API showing the combined effect of these cahnges: http://cr.openjdk.java.net/~jjg/8179479-8179592/api.01/java.base-summary.html -- Jon On 05/03/2017 03:06 PM, Jonathan

RFR: [Updated] Update tables in java.base to be HTML5-friendly.

, Jonathan Gibbons wrote: This is a review request for two co-dependent fixes. JDK-8179592: Update tables in java.base to be HTML 5-friendly. JDK-8179479: Add new styles to enable HTML 5 tables In doc comments, some of the HTML 4.01 attributes for tables are no longer available in HTML 5, and CSS

Re: RFR: Update tables in java.base to be HTML5-friendly.

On 5/3/17 7:49 PM, Martin Buchholz wrote: --- Yes, "striped" is a much better name than "altrows". "striped-tables" as you suggest may be better. Choose your names carefully - we can't change them in the future. --- Well, we can, ... but ... A goal of creating specification(s) for

Re: RFR: Update tables in java.base to be HTML5-friendly.

On 5/3/17 7:49 PM, Martin Buchholz wrote: w3.org doc seems to suggest we should only be defining table styles with borders. https://www.w3.org/TR/html5/tabular-data.html#attr-table-border """Tables should not be used as layout aids. """ """User agents, especially those

Re: RFR: Update tables in java.base to be HTML5-friendly.

appy for you to own the html5 style for the entire javadoc; consistency wins; my comments are only suggestions and I'm no html or css expert. On Wed, May 3, 2017 at 5:03 PM, Jonathan Gibbons <jonathan.gibb...@oracle.com <mailto:jonathan.gibb...@oracle.com>> wrote: O

Re: RFR: Update tables in java.base to be HTML5-friendly.

On 05/03/2017 04:39 PM, Martin Buchholz wrote: Thanks, Jon. For the Deque/Queue tables - * + * I expected that we would modify these to which rendered alright and is compliant (although "border" is a weird boolean) and makes the "border intent" clear to humans and to browsers. THIS IS

RFR: Update tables in java.base to be HTML5-friendly.

This is a review request for two co-dependent fixes. JDK-8179592: Update tables in java.base to be HTML 5-friendly. JDK-8179479: Add new styles to enable HTML 5 tables In doc comments, some of the HTML 4.01 attributes for tables are no longer available in HTML 5, and CSS should be used

Re: RFR: 8179370: Replace use of , and tags in java.base

e ... and so it is inappropriate to use {@code} for that instance. -- Jon On 04/26/2017 06:09 PM, Jonathan Gibbons wrote: Joe, Yes, there are occurrences here that require instead of {@code}, because of the presence of HTML entities. It's about 50/50. I'd prefer to stay with mechanical upda

Re: RFR: 8179370: Replace use of , and tags in java.base

changeset in its current form too. Cheers, -Joe On 4/26/2017 5:50 PM, Jonathan Gibbons wrote: Please review these mostly simple changes to replace HTML tags which are not valid in HTML 5 in public doc comments in java.base. As with the previous changes, the changes were done mechanically,

RFR: 8179370: Replace use of , and tags in java.base

Please review these mostly simple changes to replace HTML tags which are not valid in HTML 5 in public doc comments in java.base. As with the previous changes, the changes were done mechanically, using the following sed script: s|||g s|||g s|<\\/tt>|<\\/code>|g s|\(]*\)>\([^<]*\)|\1

Re: RFR: 8158670: Fix @modules in java/lang/SecurityManager/CheckSecurityProvider.java

The test can also report which providers it is testing and/or skipping, so that anyone checking the .jtr file can verify the behavior. Maybe it fails if expected modules or providers are not found. -- Jon On 06/29/2016 10:50 AM, Mandy Chung wrote: Valerie’s suggestion is a good one. The

Re: JDK 9 RFR of JDK-8151763; Use more informative format for problem list

On 03/11/2016 07:28 PM, joe darcy wrote: Hello, As Jon Gibbons has noted off-list, the problem list entries can directly include the bug number associated with the test in question, enabling better reporting. This format should be used rather than the current convention of putting the bug

hg: jdk8/tl/langtools: 8028318: [doclint] doclint will reject existing user-written doc comments using custom tags that follow the recommended rules

Changeset: a78f51d6bd5e Author:jjg Date: 2013-11-25 17:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a78f51d6bd5e 8028318: [doclint] doclint will reject existing user-written doc comments using custom tags that follow the recommended rules Reviewed-by: darcy !

hg: jdk8/tl/langtools: 2 new changesets

Changeset: 351d6808c1a5 Author:jjg Date: 2013-10-22 17:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/351d6808c1a5 8027119: Cleanup javadoc comments for taglet API Reviewed-by: mduigou ! src/share/classes/com/sun/javadoc/Tag.java Changeset: 41d3ffca22ff Author:

hg: jdk8/tl/langtools: 8025109: Better encapsulation for AnnotatedType

Changeset: e5d3cd43c85e Author:jjg Date: 2013-10-20 12:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e5d3cd43c85e 8025109: Better encapsulation for AnnotatedType Reviewed-by: jjg Contributed-by: wdi...@gmail.com !

hg: jdk8/tl/langtools: 8026791: wrong type_path encoded for method_return on an inner class constructor

Changeset: ae4f5cb78ebd Author:jjg Date: 2013-10-20 12:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ae4f5cb78ebd 8026791: wrong type_path encoded for method_return on an inner class constructor Reviewed-by: jjg Contributed-by: wdi...@gmail.com !

hg: jdk8/tl/langtools: 8026749: Missing LV table in lambda bodies

Changeset: 7de97abc4a5c Author:jjg Date: 2013-10-18 15:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7de97abc4a5c 8026749: Missing LV table in lambda bodies Reviewed-by: vromero, jlahoda ! src/share/classes/com/sun/tools/javac/code/Flags.java !

hg: jdk8/tl/langtools: 8026704: Build failure with --enable-debug

Changeset: d7e155f874a7 Author:jjg Date: 2013-10-16 10:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d7e155f874a7 8026704: Build failure with --enable-debug Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/code/Flags.java !

hg: jdk8/tl/langtools: 8025998: Missing LV table in lambda bodies

Changeset: 09a414673570 Author:jjg Date: 2013-10-14 23:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/09a414673570 8025998: Missing LV table in lambda bodies Reviewed-by: vromero ! src/share/classes/com/sun/tools/javac/code/Flags.java !

hg: jdk8/tl/langtools: 8026564: import changes from type-annotations forest

Changeset: b0c086cd4520 Author:jjg Date: 2013-10-15 15:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b0c086cd4520 8026564: import changes from type-annotations forest Reviewed-by: jjg Contributed-by: wdi...@gmail.com, steve.si...@oracle.com ! make/build.properties

hg: jdk8/tl/langtools: 8026368: doclint does not report empty tags when tag closed implicitly

Changeset: b024fe427d24 Author:jjg Date: 2013-10-14 12:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b024fe427d24 8026368: doclint does not report empty tags when tag closed implicitly Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/Checker.java !

hg: jdk8/tl/langtools: 8026371: tidy issues in langtools/src/**/*.html files

Changeset: b9e3b55a908c Author:jjg Date: 2013-10-14 16:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b9e3b55a908c 8026371: tidy issues in langtools/src/**/*.html files Reviewed-by: darcy + src/share/classes/com/sun/javadoc/package-info.java -

hg: jdk8/tl/langtools: 8025693: recent javadoc changes cause com/sun/javadoc/testLinkOption/TestLinkOption.java to fail

Changeset: 7d266a2b31b2 Author:jjg Date: 2013-10-14 22:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7d266a2b31b2 8025693: recent javadoc changes cause com/sun/javadoc/testLinkOption/TestLinkOption.java to fail Reviewed-by: darcy !

hg: jdk8/tl/langtools: 8026294: 8025633 breaks langtools/test/com/sun/javadoc/testRepeatedAnnotations/TestRepeatedAnnotations.java

Changeset: f068d235c4f7 Author:jjg Date: 2013-10-10 17:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f068d235c4f7 8026294: 8025633 breaks langtools/test/com/sun/javadoc/testRepeatedAnnotations/TestRepeatedAnnotations.java Reviewed-by: darcy !

hg: jdk8/tl/langtools: 8022163: javac exits with 0 status and no messages on error to construct an ann-procesor

Changeset: 2fa6ced325cc Author:jjg Date: 2013-10-04 13:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2fa6ced325cc 8022163: javac exits with 0 status and no messages on error to construct an ann-procesor Reviewed-by: darcy !

hg: jdk8/tl/langtools: 6525408: DiagnosticListener should receive MANDATORY_WARNING in standard compiler mode

Changeset: 515d54c1b063 Author:jjg Date: 2013-10-04 14:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/515d54c1b063 6525408: DiagnosticListener should receive MANDATORY_WARNING in standard compiler mode Reviewed-by: darcy !

hg: jdk8/tl/langtools: 8025970: Spurious characters in JavaCompiler

Changeset: 3e3c321710be Author:jjg Date: 2013-10-04 15:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3e3c321710be 8025970: Spurious characters in JavaCompiler Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java

hg: jdk8/tl/langtools: 8025407: TypeAnnotations does not use Context

Changeset: 5043e7056be8 Author:jjg Date: 2013-09-25 11:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5043e7056be8 8025407: TypeAnnotations does not use Context Reviewed-by: jfranck ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java !

hg: jdk8/tl/langtools: 8025412: Add legal header and comments to test/tools/doclint/tidy/util/Main.java

Changeset: 3d61984b077c Author:jjg Date: 2013-09-25 14:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3d61984b077c 8025412: Add legal header and comments to test/tools/doclint/tidy/util/Main.java Reviewed-by: bpatel ! test/tools/doclint/tidy/util/Main.java !

hg: jdk8/tl/langtools: 8025050: Doclint doesn't recognize dfn tag

Changeset: 96dcb66e6b0a Author:jjg Date: 2013-09-24 10:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/96dcb66e6b0a 8025050: Doclint doesn't recognize dfn tag Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclint/HtmlTag.java !

hg: jdk8/tl/langtools: 8025246: [doclint] doclint is showing error on anchor already defined when it's not

Changeset: 503338f16d2b Author:jjg Date: 2013-09-24 10:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/503338f16d2b 8025246: [doclint] doclint is showing error on anchor already defined when it's not Reviewed-by: bpatel !

hg: jdk8/tl/langtools: 8025272: doclint needs to check for valid usage of @value tag

Changeset: 6a05a713450d Author:jjg Date: 2013-09-24 11:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6a05a713450d 8025272: doclint needs to check for valid usage of @value tag Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclint/Checker.java !

hg: jdk8/tl/langtools: 8002154: [doclint] doclint should check for issues which are errors in javadoc

Changeset: 3ae62331a56f Author:jjg Date: 2013-09-24 13:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3ae62331a56f 8002154: [doclint] doclint should check for issues which are errors in javadoc Reviewed-by: bpatel !

hg: jdk8/tl/langtools: 8024609: sjavac assertion fails during call to BuildState.collectArtifacts

Changeset: 0cfd5baa7154 Author:ohrstrom Date: 2013-09-19 08:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0cfd5baa7154 8024609: sjavac assertion fails during call to BuildState.collectArtifacts Reviewed-by: jjg !

hg: jdk8/tl/langtools: 8024538: -Xdoclint + -Xprefer:source + incremental compilation == FAIL

Changeset: fdfbc5f0c4ed Author:jjg Date: 2013-09-17 14:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fdfbc5f0c4ed 8024538: -Xdoclint + -Xprefer:source + incremental compilation == FAIL Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/DocLint.java !

hg: jdk8/tl/langtools: 8019521: Enhanced rethrow disabled in lambdas

Changeset: 77d395862700 Author:jlahoda Date: 2013-09-09 23:13 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/77d395862700 8019521: Enhanced rethrow disabled in lambdas Summary: Fixing effectively final detection inside lambdas, small cleanup related to thrown types

hg: jdk8/tl/langtools: 8006972: jtreg test fails: test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.java

Changeset: 7439356a7dc5 Author:jjg Date: 2013-09-09 17:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7439356a7dc5 8006972: jtreg test fails: test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.java Reviewed-by: darcy !

hg: jdk8/tl/langtools: 8024434: problem running javadoc tests in samevm mode on Windows

Changeset: 64328fe5e4a6 Author:jjg Date: 2013-09-06 15:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/64328fe5e4a6 8024434: problem running javadoc tests in samevm mode on Windows Reviewed-by: darcy !

hg: jdk8/tl/langtools: 8001669: javadoc internal DocletAbortException should set cause when appropriate

Changeset: 0e6577980181 Author:jjg Date: 2013-08-29 11:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0e6577980181 8001669: javadoc internal DocletAbortException should set cause when appropriate Reviewed-by: darcy !

hg: jdk8/tl/langtools: 8023833: Replace direct use of AnnotatedType in javadoc code

Changeset: 23f0f3c9c44a Author:jjg Date: 2013-08-29 19:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/23f0f3c9c44a 8023833: Replace direct use of AnnotatedType in javadoc code Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/AnnotatedTypeImpl.java !

hg: jdk8/tl/langtools: 8010310: [javadoc] Error processing sources with -private

Changeset: 189942cdf585 Author:jjg Date: 2013-08-28 15:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/189942cdf585 8010310: [javadoc] Error processing sources with -private Reviewed-by: vromero, mcimadamore ! src/share/classes/com/sun/tools/javac/code/Symbol.java !

hg: jdk8/tl/langtools: 8023701: Fix badly named test

Changeset: 60f156c653d3 Author:jjg Date: 2013-08-26 11:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/60f156c653d3 8023701: Fix badly named test Reviewed-by: bpatel - test/com/sun/javadoc/testNavagation/TestNavagation.java -

hg: jdk8/tl/langtools: 8023768: Use the unannotatedType in cyclicity checks.

Changeset: 7bf6313e1ced Author:jjg Date: 2013-08-26 15:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7bf6313e1ced 8023768: Use the unannotatedType in cyclicity checks. Reviewed-by: jjg Contributed-by: wdi...@gmail.com !

hg: jdk8/tl/langtools: 8022173: Relax some warnings in doclint

Changeset: b77381d99056 Author:jjg Date: 2013-08-22 12:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b77381d99056 8022173: Relax some warnings in doclint Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/HtmlTag.java !

hg: jdk8/tl/langtools: 8023515: import type-annotations updates

Changeset: 7de231613e4a Author:jjg Date: 2013-08-21 16:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7de231613e4a 8023515: import type-annotations updates Reviewed-by: jjg Contributed-by: wdi...@gmail.com ! src/share/classes/com/sun/source/tree/MethodTree.java !

hg: jdk8/tl/langtools: 8022287: javac.sym.Profiles uses a static Map when it should not

Changeset: 57e1266527dd Author:jjg Date: 2013-08-21 17:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/57e1266527dd 8022287: javac.sym.Profiles uses a static Map when it should not Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/sym/Profiles.java +

hg: jdk8/tl/langtools: 8020663: Restructure some properties to facilitate better translation

Changeset: a76dc1b4c299 Author:jjg Date: 2013-08-20 14:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a76dc1b4c299 8020663: Restructure some properties to facilitate better translation Reviewed-by: darcy !

hg: jdk8/tl/langtools: 8022080: javadoc generates invalid HTML in Turkish locale

Changeset: 79e341614c50 Author:jjg Date: 2013-08-20 14:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/79e341614c50 8022080: javadoc generates invalid HTML in Turkish locale Reviewed-by: bpatel !

hg: jdk8/tl/langtools: 8013887: In class use, some tables are randomly unsorted

Changeset: 720992953d43 Author:jjg Date: 2013-08-20 15:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/720992953d43 8013887: In class use, some tables are randomly unsorted Reviewed-by: bpatel !

hg: jdk8/tl/langtools: 8017191: Javadoc is confused by @link to imported classes outside of the set of generated packages

Changeset: 14faef2b51eb Author:jjg Date: 2013-08-14 16:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/14faef2b51eb 8017191: Javadoc is confused by @link to imported classes outside of the set of generated packages Reviewed-by: bpatel !

hg: jdk8/tl/langtools: 8020556: doclint does not check type variables for @throws

Changeset: 2fbe77c38802 Author:jjg Date: 2013-07-24 17:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2fbe77c38802 8020556: doclint does not check type variables for @throws Reviewed-by: mcimadamore ! src/share/classes/com/sun/source/util/DocTrees.java !

hg: jdk8/tl/langtools: 8021215: javac gives incorrect doclint warnings on normal package statements

Changeset: 129751018061 Author:jjg Date: 2013-07-23 16:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/129751018061 8021215: javac gives incorrect doclint warnings on normal package statements Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/Checker.java

hg: jdk8/tl/langtools: 8020664: doclint gives incorrect warnings on normal package statements

Changeset: 1476d54fdc61 Author:jjg Date: 2013-07-17 19:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1476d54fdc61 8020664: doclint gives incorrect warnings on normal package statements Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/doclint/DocLint.java

hg: jdk8/tl/langtools: 8020313: doclint doesn't reset HTML anchors correctly

Changeset: 1e533c1bfb01 Author:jjg Date: 2013-07-17 19:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1e533c1bfb01 8020313: doclint doesn't reset HTML anchors correctly Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/doclint/Checker.java +

hg: jdk8/tl/langtools: 8020278: NPE in javadoc

Changeset: 37031963493e Author:jjg Date: 2013-07-12 13:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/37031963493e 8020278: NPE in javadoc Reviewed-by: mcimadamore, vromero ! src/share/classes/com/sun/tools/doclint/DocLint.java !

hg: jdk8/tl/langtools: 8015720: since tag isn't copied while generating JavaFX documentation

Changeset: 26437287529d Author:janvalenta Date: 2013-06-27 17:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/26437287529d 8015720: since tag isn't copied while generating JavaFX documentation Reviewed-by: jjg !

hg: jdk8/tl/langtools: 8014137: Update test/tools/javac/literals/UnderscoreLiterals to add testcases with min/max values

Changeset: 3b2e10524627 Author:jjg Date: 2013-06-26 18:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3b2e10524627 8014137: Update test/tools/javac/literals/UnderscoreLiterals to add testcases with min/max values Reviewed-by: jjg, darcy Contributed-by:

hg: jdk8/tl/langtools: 8016193: Fix OAC issue in langtools docs

Changeset: fd31bf97340f Author:jjg Date: 2013-06-07 15:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fd31bf97340f 8016193: Fix OAC issue in langtools docs Reviewed-by: darcy ! src/share/classes/com/sun/javadoc/Tag.java

hg: jdk8/tl/langtools: 8004643: Reduce javac space overhead introduced with compiler support for repeating annotations

Changeset: 8fb68f73d4b1 Author:jjg Date: 2013-06-04 14:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8fb68f73d4b1 8004643: Reduce javac space overhead introduced with compiler support for repeating annotations Reviewed-by: mcimadamore, jfranck !

hg: jdk8/tl/langtools: 8006615: [doclint] move remaining messages into resource bundle

Changeset: 242bcad5be74 Author:jjg Date: 2013-06-03 17:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/242bcad5be74 8006615: [doclint] move remaining messages into resource bundle Reviewed-by: mcimadamore, vromero !

hg: jdk8/tl/langtools: 8007687: javadoc -X does not include -Xdoclint

Changeset: 019063968164 Author:jjg Date: 2013-06-03 17:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/019063968164 8007687: javadoc -X does not include -Xdoclint Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java !

hg: jdk8/tl/langtools: 8006879: Detection of windows in sjavac fails.

Changeset: 445b8b5ae9f4 Author:jjg Date: 2013-05-15 10:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/445b8b5ae9f4 8006879: Detection of windows in sjavac fails. Reviewed-by: jjg Contributed-by: erik.joels...@oracle.com !

hg: jdk8/tl/langtools: 8014461: genstubs creates default native methods

Changeset: 46b9c25f7024 Author:jjg Date: 2013-05-14 12:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/46b9c25f7024 8014461: genstubs creates default native methods Reviewed-by: alanb ! make/tools/genstubs/GenStubs.java

hg: jdk8/tl/langtools: 8014557: Mutable static field in HtmlDocletWriter

Changeset: 0384683c64be Author:jjg Date: 2013-05-14 13:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0384683c64be 8014557: Mutable static field in HtmlDocletWriter Reviewed-by: ksrini ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java

hg: jdk8/tl/langtools: 8013852: update reference impl for type-annotations

Changeset: ddb4a2bfcd82 Author:jjg Date: 2013-05-14 15:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ddb4a2bfcd82 8013852: update reference impl for type-annotations Reviewed-by: jjg Contributed-by: wdi...@gmail.com, steve.si...@oracle.com, joel.fra...@oracle.com,

hg: jdk8/tl/langtools: 8013163: Convert 4 tools multicatch tests to jtreg format

Changeset: 53b389eb39c1 Author:sogoel Date: 2013-05-14 18:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/53b389eb39c1 8013163: Convert 4 tools multicatch tests to jtreg format Reviewed-by: jjg + test/tools/javac/multicatch/Pos11.java +

hg: jdk8/tl/langtools: 8014323: Add VariableTree.getNameExpression

Changeset: 529fb3ed5d2a Author:jjg Date: 2013-05-14 21:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/529fb3ed5d2a 8014323: Add VariableTree.getNameExpression Reviewed-by: darcy ! src/share/classes/com/sun/source/tree/VariableTree.java !

hg: jdk8/tl/langtools: 8012929: Trees.getElement should work not only for declaration trees, but also for use-trees

Changeset: 8dd528992c15 Author:jlahoda Date: 2013-05-10 15:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8dd528992c15 8012929: Trees.getElement should work not only for declaration trees, but also for use-trees Reviewed-by: jjg Contributed-by: Dusan Balek

hg: jdk8/tl/langtools: 8014363: javac test class ToolTester handles classpath incorrectly

Changeset: e39669aea0bd Author:jjg Date: 2013-05-12 18:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e39669aea0bd 8014363: javac test class ToolTester handles classpath incorrectly Reviewed-by: ksrini ! test/tools/javac/api/6406133/T6406133.java !

hg: jdk8/tl/langtools: 8004082: test/tools/javac/plugin/showtype/Test.java fails on windows: jtreg can't delete plugin.jar

Changeset: 43c2f7cb9c76 Author:jjg Date: 2013-05-07 14:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/43c2f7cb9c76 8004082: test/tools/javac/plugin/showtype/Test.java fails on windows: jtreg can't delete plugin.jar Reviewed-by: vromero, mcimadamore !

hg: jdk8/tl/langtools: 8009724: Enhance the DocTree API with DocTreePath

Changeset: a7ff36d06fa2 Author:jlahoda Date: 2013-05-06 16:22 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a7ff36d06fa2 8009724: Enhance the DocTree API with DocTreePath Summary: Adding DocTreePath and DocTreePathScanner similar to TreePath and TreePathScanner,

  1   2   3   4   5   >