Re: OpenJDK11u: Backward incompatible behavior

2020-03-16 Thread Kumar Srinivasan
Hi Alexey - I was trying to understand the fix for the "Unexpected number of plaintext bytes” issue. But it appears that the earlier iterations of the webrevs have disappeared, only webrev.5 is available in [1] In the future it would be a good practice, to retain all the webrevs for sometime.

Re: OpenJDK11u: Backward incompatible behavior

2020-02-25 Thread Kumar Srinivasan
Hi Alexey, Good catch, this kinda answers my question wrt. "Escape from Alcatraz” comment. I vaguely remembered some discussions around this in the Mantis/Tiger era in the Deployment team. https://bugs.openjdk.java.net/browse/JDK-4836493 The reason I was asking for a regression test, are all t

Re: OpenJDK11u: Backward incompatible behavior

2020-02-24 Thread Kumar Srinivasan
v-requ...@openjdk.java.net<mailto:security-dev-requ...@openjdk.java.net> wrote: I will look into the issue. BTW, I closed JDK-8239788 as duplicate of JDK-8239798. Thanks, Xuelei On 2/21/2020 9:24 AM, Kumar Srinivasan wrote: Hi security-folk, At VMware while upgrading our application to OpenJDK

OpenJDK11u: Backward incompatible behavior

2020-02-21 Thread Kumar Srinivasan
an you please evaluate this at the earliest, this is a serious show stopper for VMware. Thank Kumar Srinivasan VMware

Re: RFR: [Updated] Update tables in java.base to be HTML5-friendly.

2017-05-08 Thread Kumar Srinivasan
Hi Jon, I looked at the stylesheet can the descriptive comments for each of the classes be moved closer to the class itself, ie. just before the definition ? Kumar This is an updated review for the changes to improve tables in java.base. The changes incorporate earlier review feedback, an

Re: RFR: 8178014: CryptoPolicyParser's API comment contains < and > characters

2017-05-01 Thread Kumar Srinivasan
+1 Kumar On 5/1/2017 1:55 PM, Sean Mullan wrote: Looks good to me. --Sean On 5/1/17 4:19 PM, Brad R. Wetmore wrote: Kumar (+ anyone else), Simple review for fixing two errors when building javadocs with -private (non-default option). Also, the 'name' attribute is no longer supported in HT

Re: Review Request: 8074428, 8074429, 8074430 jdk.pack200, jdk.jartool, jdk.policytool modules

2015-03-10 Thread Kumar Srinivasan
The changes look ok to me, however I am wondering if the module could be called jdk.unpack200 and not jdk.pack200 ? since it contains only the unpacker, and the bin utilities are pack200 and unpack200. Kumar On 3/4/2015 5:13 PM, Mandy Chung wrote: As listed in an open issue in JEP 200: The jdk

Re: RFR [8044342] build failure on Windows noticed with recent smartcardio fix.

2014-05-29 Thread Kumar Srinivasan
Thanks for fixing this so quickly, the build appears to be fine now. Kumar On 5/29/2014 3:09 PM, Valerie (Yu-Ching) Peng wrote: Changes look good. Thanks, Valerie On 05/29/14 13:39, Ivan Gerasimov wrote: Thanks Valerie! On 30.05.2014 0:09, Valerie (Yu-Ching) Peng wrote: 1) Since we are rol

Re: Request for review: 7084245: Update usages of InternalError to use exception chaining

2011-08-29 Thread Kumar Srinivasan
Hi, Sorry for the delay, was on vacation...comment inlined. Hi, here is a webrev[1] for some cleanup that i want to integrated in tl-repositories. Alan Bateman had scanned the changes and gave me some good input[3] for further discussion here: The changes to java.util.concurrent should go t

[security-dev 01419]: hg: jdk7/tl/jdk: 6367077: Purge LD_LIBRARY_PATH usage from the launcher; ...

2009-11-30 Thread kumar . srinivasan
Changeset: de45eac5670e Author:ksrini Date: 2009-11-20 11:01 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/de45eac5670e 6367077: Purge LD_LIBRARY_PATH usage from the launcher 6899834: (launcher) remove the solaris libjvm.so symlink Summary: Fixes other related issues as well