Re: RFR: 8218021: jarsigner strips the execute permission when signing a .zip file

2020-06-12 Thread Lance Andersen
.net/pipermail/security-dev/2020-January/021141.html > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-1

Re: RFR: 8218021: jarsigner strips the execute permission when signing a .zip file

2020-01-17 Thread Lance Andersen
e.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781

Re: RFR 8220598: Malformed copyright year range in a few files in java.base

2019-03-13 Thread Lance Andersen
LTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > > -Chris. <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <ht

Re: RFR 8213031: (zipfs) Add support for POSIX file permissions

2019-02-13 Thread Lance Andersen
r Please see http://openjdk.java.net/jtreg/tag-spec.html for the system properties. I do not see test.dir there. — I would just do: — Path foo = Path.of("test.zip"); System.out.println("test.zip path=" + foo.toAbsolutePath()); -- which resu

Re: RFR 8213031: (zipfs) Add support for POSIX file permissions

2019-02-13 Thread Lance Andersen
s an own view that offers dynamic, not type safe >> access to "zip:permissions" and we'll document this. If a user of zipfs wants >> to see full PosixFileAttributeView support with default values, then we >> should allow for a creation attribute for the zipfs that can control this. >> Maybe >> we can even allow specifying default values for user, group and permissions >> via zipfs attributes. >> >> I'll work to develop the patch into this direction unless you tell me that >> this >> idea is bogus (if so, then I hope it be soon 😊) >> >> Thanks >> Christoph >> >> > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR 8213031: (zipfs) Add support for POSIX file permissions

2019-01-12 Thread Lance Andersen
e a >>>> file has no external file attributes. So it seems we have to resort to >>>> throwing an IOE? >>>> >>> Maybe although it would be a bit awkward to deal with. The issues around >>> this remind me a bit about mounting fat32 file systems on Linux or Unix >>> systems where the fields in the stat structure are populated with >>> default values. PosixFileAttributeView::readAttributes is essentially >>> the equivalent of a stat call. This might be something to look at for >>> the file owner at least. >>> >>> -Alan <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR (XS) 8200381 : Typos in javadoc - missing verb "be" and alike

2018-10-01 Thread Lance Andersen
s/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: JDK 12 RFR of JDK-8209024: Use SuppressWarnings on serialVersionUID fields in interfaces

2018-08-06 Thread Lance Andersen
{ > > /** indicate compatibility with JDK 1.1.x version of class. */ > +@SuppressWarnings("serial") // serialVersionUID in an interface is > ineffectual > static final long serialVersionUID = 3632638527362204081L; > > /** > --- old/src/java.rmi/share/classes/java/rmi/server/ServerRef.java 2018-08-06 > 12:04:54.494000999 -0700 > +++ new/src/java.rmi/share/classes/java/rmi/server/ServerRef.java 2018-08-06 > 12:04:54.338000999 -0700 > @@ -39,6 +39,7 @@ > public interface ServerRef extends RemoteRef { > > /** indicate compatibility with JDK 1.1.x version of class. */ > +@SuppressWarnings("serial") // serialVersionUID in an interface is > ineffectual > static final long serialVersionUID = -4557750989390278438L; > > /** > > > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR 8198645 Use System.lineSeparator() instead of getProperty("line.separator")

2018-02-23 Thread Lance Andersen
5/ > > Thanks, Roger > > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lan

Re: RFR: 8184208: update class="striped" tables for accessibility

2017-07-12 Thread Lance Andersen
rev: http://cr.openjdk.java.net/~jjg/8184208/webrev.00/ > API: http://cr.openjdk.java.net/~jjg/8184208/api.00/ > > -- Jon > > > > > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http:

Re: JDK 10 RFR of JDK-8173903: Update various tests to pass under JDK 10

2017-02-03 Thread Lance Andersen
/multiRelease/MVJarSigningTest.java > Fri Feb 03 11:18:23 2017 -0800 > @@ -74,7 +74,8 @@ > private static final String KEYPASS = "changeit"; > private static final String SIGNED_JAR = "Signed.jar"; > private static final String POLICY_FILE = "Sig

Re: JDK 9 RFR of JDK-8039854: Broken link in java.lang.RuntimePermission

2016-09-08 Thread Lance Andersen
manageProcess > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR [9] 8081517: minor cleanup for docs

2015-06-05 Thread Lance Andersen
llo, > > Could you please review the fix > http://cr.openjdk.java.net/~avstepan/8081517/webrev.00/ > for > https://bugs.openjdk.java.net/browse/JDK-8081517 > > Just some cleanup for docs. > > Thanks, > Alexander Lance Andersen| Principal Member of Technical St

Re: RFR 80044461: Cleanup new Boolean and single character strings

2014-05-30 Thread Lance Andersen
iple classes in the jdk9-dev repo (except client > packages). > > webrev: http://cr.openjdk.java.net/~rriggs/webrev-8044461-cleanup/ > Issue: https://bugs.openjdk.java.net/browse/JDK-8044461 > > Thanks, Roger > Lance Andersen| Principal Member of Technical Staff | +1.781

Re: JDK 9 RFR of JDK-8027063 SecurityManger.getClassContext returns a raw type

2014-01-06 Thread Lance Andersen - Oracle
> A clean build succeeds and the SecurityManager tests pass after this change. > > Thanks, > > -Joe <> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com

hg: jdk8/tl/jdk: 8029417: JDBC 4.2 javadoc updates

2013-12-02 Thread lance . andersen
Changeset: bcf5fa5e9509 Author:lancea Date: 2013-12-02 16:06 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bcf5fa5e9509 8029417: JDBC 4.2 javadoc updates Reviewed-by: darcy ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/sql/DriverManager.java !

hg: jdk8/tl/jdk: 8028149: Clean-up javac -Xlint warnings in com.sun.rowset and com.sun.rowset.internal

2013-11-11 Thread lance . andersen
Changeset: 59ff7957c26f Author:lancea Date: 2013-11-11 14:22 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/59ff7957c26f 8028149: Clean-up javac -Xlint warnings in com.sun.rowset and com.sun.rowset.internal Reviewed-by: darcy ! src/share/classes/com/sun/rowset/CachedRowSetI

hg: jdk8/tl/jdk: 8026812: doclint clean up for java.sql and javax.sql

2013-10-17 Thread lance . andersen
Changeset: 64c0ac7cd936 Author:lancea Date: 2013-10-17 15:14 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/64c0ac7cd936 8026812: doclint clean up for java.sql and javax.sql Reviewed-by: mduigou ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/sql

hg: jdk8/tl/jdk: 7097386: Correct error in Predicate javadoc example

2013-09-17 Thread lance . andersen
Changeset: 657482758408 Author:lancea Date: 2013-09-17 07:56 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/657482758408 7097386: Correct error in Predicate javadoc example Reviewed-by: alanb, shade ! src/share/classes/javax/sql/rowset/Predicate.java

hg: jdk8/tl/jdk: 8014967: EBehavior of DriverManager.registerDriver(dr) is unspecified if driver is null

2013-09-13 Thread lance . andersen
Changeset: 5c7690923663 Author:lancea Date: 2013-09-13 19:10 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5c7690923663 8014967: EBehavior of DriverManager.registerDriver(dr) is unspecified if driver is null Reviewed-by: alanb ! src/share/classes/java/sql/DriverManager.jav

hg: jdk8/tl/jdk: 8015340: remove erroneous @since tag

2013-09-12 Thread lance . andersen
Changeset: 60d6f60416ca Author:lancea Date: 2013-09-12 13:20 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60d6f60416ca 8015340: remove erroneous @since tag Reviewed-by: darcy ! src/share/classes/java/sql/PreparedStatement.java

hg: jdk8/tl/jdk: 8022753: SQLXML javadoc example typo

2013-08-12 Thread lance . andersen
Changeset: cc64a05836a7 Author:lancea Date: 2013-08-12 16:09 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cc64a05836a7 8022753: SQLXML javadoc example typo Reviewed-by: alanb, mchung ! src/share/classes/java/sql/SQLXML.java

hg: jdk8/tl/jdk: 8019286: Fix javadoc typo in ResultSet.next

2013-06-29 Thread lance . andersen
Changeset: a4eb59bffb60 Author:lancea Date: 2013-06-29 06:12 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a4eb59bffb60 8019286: Fix javadoc typo in ResultSet.next Reviewed-by: darcy, mchung ! src/share/classes/java/sql/ResultSet.java

hg: jdk8/tl/jdk: 8017471: Fix JDBC -Xdoclint public errors

2013-06-27 Thread lance . andersen
Changeset: b9ba04dc210f Author:lancea Date: 2013-06-27 15:07 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b9ba04dc210f 8017471: Fix JDBC -Xdoclint public errors Reviewed-by: darcy ! src/share/classes/java/sql/Blob.java ! src/share/classes/java/sql/CallableStatement.java !

hg: jdk8/tl/jdk: 8016101: Fix typo in SerialRef and missing @param in SerialStruct

2013-06-07 Thread lance . andersen
Changeset: e2333bd8514a Author:lancea Date: 2013-06-07 14:13 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e2333bd8514a 8016101: Fix typo in SerialRef and missing @param in SerialStruct Reviewed-by: darcy ! src/share/classes/javax/sql/rowset/serial/SerialRef.java ! src/shar

hg: jdk8/tl/jdk: 8010416: Add a way for java.sql.Driver to be notified when it is deregistered

2013-04-30 Thread lance . andersen
Changeset: ac3e189c9099 Author:lancea Date: 2013-04-30 14:44 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ac3e189c9099 8010416: Add a way for java.sql.Driver to be notified when it is deregistered Reviewed-by: alanb, ulfzibis ! src/share/classes/java/sql/Driver.java + src/

hg: jdk8/tl/jdk: 8011620: adding free form netbeans project for jdbc to jdk/make/netbeans

2013-04-23 Thread lance . andersen
Changeset: b456f25c2075 Author:lancea Date: 2013-04-23 11:17 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b456f25c2075 8011620: adding free form netbeans project for jdbc to jdk/make/netbeans Reviewed-by: chegar ! make/netbeans/common/shared.xml + make/netbeans/jdbc/README

hg: jdk8/tl/jdk: 8006036: (process) cleanup code in java/lang/Runtime/exec/WinCommand.java

2013-04-08 Thread lance . andersen
Changeset: 04617e462512 Author:lancea Date: 2013-04-08 15:29 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/04617e462512 8006036: (process) cleanup code in java/lang/Runtime/exec/WinCommand.java Reviewed-by: lancea Contributed-by: Jim Gish ! test/java/lang/Runtime/exec/WinC

hg: jdk8/tl/jdk: 2 new changesets

2013-02-22 Thread lance . andersen
Changeset: 9f9dac5a9e74 Author:lancea Date: 2013-02-22 09:29 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9f9dac5a9e74 8008716: address typo in CallableStatement javadocs Reviewed-by: chegar ! src/share/classes/java/sql/CallableStatement.java Changeset: 8d8a35ac7d40 Autho

Re: 8008662: Add @jdk.Supported to JDK-specific/supported API

2013-02-21 Thread Lance Andersen - Oracle
arcy might have suggestions on that. > > Otherwise this is mostly mechanical and the patch file is easier to review > that the webrev. > > -Alan > > [1] http://hg.openjdk.java.net/jdk8/tl/langtools/rev/55cca2f38ee6 <> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com

hg: jdk8/tl/jdk: 8006505: additional changes for JSR 310 support

2013-02-06 Thread lance . andersen
Changeset: 1574fa3df1c0 Author:lancea Date: 2013-02-06 14:15 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1574fa3df1c0 8006505: additional changes for JSR 310 support Reviewed-by: naoto, ulfzibis ! src/share/classes/java/sql/JDBCType.java ! src/share/classes/java/sql/SQLIn

hg: jdk8/tl/jdk: 8006642: Fix javadoc warnings due to Integer.MAX_VALUE

2013-01-21 Thread lance . andersen
Changeset: de30e46250c5 Author:lancea Date: 2013-01-21 14:08 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/de30e46250c5 8006642: Fix javadoc warnings due to Integer.MAX_VALUE Reviewed-by: alanb ! src/share/classes/java/sql/BatchUpdateException.java ! src/share/classes/java/

hg: jdk8/tl/jdk: 8005080: JDBC 4.2 Core changes

2013-01-19 Thread lance . andersen
Changeset: d3da0d29d7cd Author:lancea Date: 2013-01-19 10:53 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d3da0d29d7cd 8005080: JDBC 4.2 Core changes Reviewed-by: naoto ! src/share/classes/java/sql/BatchUpdateException.java ! src/share/classes/java/sql/CallableStatement.ja

hg: jdk8/tl/jdk: 8006139: add missing methods to javax.sql.rowset.serial.SQLInputImpl, SQLOutputImpl

2013-01-19 Thread lance . andersen
Changeset: 78514544980d Author:lancea Date: 2013-01-19 10:11 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/78514544980d 8006139: add missing methods to javax.sql.rowset.serial.SQLInputImpl, SQLOutputImpl Reviewed-by: naoto, ulfzibis, alanb ! src/share/classes/javax/sql/row

hg: jdk8/tl/jdk: 8004357: Implement various methods in SerialBlob/Clob/Array and specify Thread Safety

2012-12-12 Thread lance . andersen
Changeset: 7a8978a5bb6e Author:lancea Date: 2012-12-12 20:57 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7a8978a5bb6e 8004357: Implement various methods in SerialBlob/Clob/Array and specify Thread Safety Reviewed-by: naoto ! src/share/classes/javax/sql/rowset/serial/Seri

hg: jdk8/tl/jdk: 8004374: CachedRowSetSwriter.writeData reports wrong number of conflicts in SyncProviderException

2012-12-06 Thread lance . andersen
Changeset: 41a1b110f34d Author:lancea Date: 2012-12-06 15:51 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41a1b110f34d 8004374: CachedRowSetSwriter.writeData reports wrong number of conflicts in SyncProviderException Reviewed-by: naoto ! src/share/classes/com/sun/rowset/i

hg: jdk8/tl/jdk: 8001536: Added readObject, writeObject, clone, equals, hashcode to SerialXLob

2012-11-01 Thread lance . andersen
Changeset: 8748331f63cf Author:lancea Date: 2012-11-01 17:35 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8748331f63cf 8001536: Added readObject,writeObject,clone, equals, hashcode to SerialXLob Reviewed-by: alanb, forax ! src/share/classes/javax/sql/rowset/serial/SerialBl

hg: jdk8/tl/jdk: 8000712: Remove unused fields in SyncFactory

2012-10-10 Thread lance . andersen
Changeset: 734ca9f4719c Author:lancea Date: 2012-10-10 17:34 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/734ca9f4719c 8000712: Remove unused fields in SyncFactory Reviewed-by: mchung ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java

hg: jdk8/tl/jdk: 8000687: Correct javadoc typo for getLogWriter and setLogWriter

2012-10-10 Thread lance . andersen
Changeset: 3c4be36de073 Author:lancea Date: 2012-10-10 11:15 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c4be36de073 8000687: Correct javadoc typo for getLogWriter and setLogWriter Reviewed-by: alanb ! src/share/classes/java/sql/DriverManager.java

hg: jdk8/tl/jdk: 7197395: Add @Deprecated to all deprecated methods to eliminate compiler warnings in JDBC

2012-10-09 Thread lance . andersen
Changeset: 036c55976cef Author:lancea Date: 2012-10-09 08:58 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/036c55976cef 7197395: Add @Deprecated to all deprecated methods to eliminate compiler warnings in JDBC Reviewed-by: alanb, smarks ! src/share/classes/com/sun/rowset/C

hg: jdk8/tl/jdk: 7192302: Remove JDBCRowSetImpl dependency on java.beans

2012-09-06 Thread lance . andersen
Changeset: 8c6895afe204 Author:lancea Date: 2012-09-06 13:16 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8c6895afe204 7192302: Remove JDBCRowSetImpl dependency on java.beans Reviewed-by: alanb, mchung ! src/share/classes/com/sun/rowset/JdbcRowSetImpl.java

hg: jdk8/tl/jdk: 7193683: DriverManager Iterator Warning cleanup

2012-08-30 Thread lance . andersen
Changeset: 11bfec75d333 Author:lancea Date: 2012-08-30 13:38 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11bfec75d333 7193683: DriverManager Iterator Warning cleanup Reviewed-by: lancea Contributed-by: Dan Xu ! src/share/classes/java/sql/DriverManager.java

hg: jdk8/tl/jdk: 7145913: CachedRowSetSwriter.insertNewRow() throws SQLException

2012-06-14 Thread lance . andersen
Changeset: 28588ace1fb9 Author:lancea Date: 2012-06-14 15:05 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/28588ace1fb9 7145913: CachedRowSetSwriter.insertNewRow() throws SQLException Reviewed-by: joehw, naoto, psandoz, forax ! src/share/classes/com/sun/rowset/internal/Cach

hg: jdk8/tl/jdk: 7171918: XmlReaderContentHandler.endElement does not handle a Delete Tag properly

2012-06-12 Thread lance . andersen
Changeset: 6b6a73e8c036 Author:lancea Date: 2012-06-12 17:32 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6b6a73e8c036 7171918: XmlReaderContentHandler.endElement does not handle a Delete Tag properly Reviewed-by: joehw ! src/share/classes/com/sun/rowset/internal/XmlReade

hg: jdk8/tl/jdk: 7171917: CachedRowSetImpl.populate does not handle map properly

2012-06-11 Thread lance . andersen
Changeset: 46ff1b63b0c3 Author:lancea Date: 2012-06-11 07:10 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46ff1b63b0c3 7171917: CachedRowSetImpl.populate does not handle map properly Reviewed-by: joehw ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java

hg: jdk8/tl/jdk: 2 new changesets

2012-06-08 Thread lance . andersen
Changeset: 8305ddc88a5a Author:lancea Date: 2012-06-07 20:11 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8305ddc88a5a 7172551: Remove Native calls from DriverManager for jigsaw Reviewed-by: alanb, chegar, darcy, mchung ! make/java/java/FILES_c.gmk ! make/java/java/mapfile

hg: jdk8/tl/jdk: 7166598: FilteredRowSetImpl can result in Invalid Cursor Position

2012-05-04 Thread lance . andersen
Changeset: 4580652d9828 Author:lancea Date: 2012-05-04 16:00 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4580652d9828 7166598: FilteredRowSetImpl can result in Invalid Cursor Position Reviewed-by: lancea Contributed-by: Knut Anders Hatlen ! src/share/classes/com/sun/rows

hg: jdk8/tl/jdk: 7133815: address the findbug errors in CachedRowSetImpl, SerialStruct, BaseRow, SerialInputImpl, SerialOutputImpl

2012-01-26 Thread lance . andersen
Changeset: b518b160607f Author:lancea Date: 2012-01-26 19:41 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b518b160607f 7133815: address the findbug errors in CachedRowSetImpl, SerialStruct, BaseRow, SerialInputImpl, SerialOutputImpl Reviewed-by: forax ! src/share/classes

hg: jdk8/tl/jdk: 7132879: address Findbugs issue in WebRowSetXmlWriter

2012-01-24 Thread lance . andersen
Changeset: 303b67074666 Author:lancea Date: 2012-01-24 15:13 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/303b67074666 7132879: address Findbugs issue in WebRowSetXmlWriter Reviewed-by: forax ! src/share/classes/com/sun/rowset/internal/WebRowSetXmlWriter.java

hg: jdk8/tl/jdk: 7116445: Miscellaneous warnings in the JDBC/RowSet classes

2011-12-02 Thread lance . andersen
Changeset: 3c524deb8431 Author:lancea Date: 2011-12-02 19:33 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c524deb8431 7116445: Miscellaneous warnings in the JDBC/RowSet classes Reviewed-by: smarks, chegar ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/shar

hg: jdk8/tl/jdk: 7110111: Minor Java SE javadoc & Constructor clean up

2011-11-10 Thread lance . andersen
Changeset: 830d2e46023a Author:lancea Date: 2011-11-10 11:41 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/830d2e46023a 7110111: Minor Java SE javadoc & Constructor clean up Reviewed-by: alanb, darcy Contributed-by: Martin Desruisseaux ! src/share/classes/java/io/Writer.j

hg: jdk8/tl/jdk: 7077451: SerialLob, SerialClob have the wrong checks for setStream methods

2011-08-10 Thread lance . andersen
Changeset: 7676670d1e97 Author:lancea Date: 2011-08-10 16:23 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7676670d1e97 7077451: SerialLob, SerialClob have the wrong checks for setStream methods Reviewed-by: alanb Contributed-by: Patrick Reinhart ! src/share/classes/javax/

hg: jdk7/tl/jdk: 7049107: Cannot call initCause() on BatchUpdateException

2011-06-02 Thread lance . andersen
Changeset: a00f48c96345 Author:lancea Date: 2011-06-02 12:02 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a00f48c96345 7049107: Cannot call initCause() on BatchUpdateException Reviewed-by: darcy ! src/share/classes/java/sql/BatchUpdateException.java

hg: jdk7/tl/jdk: 7043443: address missed reason initialization in BatchUpdateException

2011-05-10 Thread lance . andersen
Changeset: 6a3a41e0af88 Author:lancea Date: 2011-05-10 14:41 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6a3a41e0af88 7043443: address missed reason initialization in BatchUpdateException Reviewed-by: alanb ! src/share/classes/java/sql/BatchUpdateException.java

hg: jdk7/tl/jdk: 7040150: Indexing Error in CachedRowSetImpl.removeCurrentRow

2011-04-29 Thread lance . andersen
Changeset: 0b1354ecf5a3 Author:lancea Date: 2011-04-29 09:04 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0b1354ecf5a3 7040150: Indexing Error in CachedRowSetImpl.removeCurrentRow Reviewed-by: smarks ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java

hg: jdk7/tl/jdk: 7038565: address Findbugs issue in BatchUpdateException

2011-04-28 Thread lance . andersen
Changeset: 28caa191884a Author:lancea Date: 2011-04-28 09:46 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/28caa191884a 7038565: address Findbugs issue in BatchUpdateException Reviewed-by: alanb, forax ! src/share/classes/java/sql/BatchUpdateException.java

hg: jdk7/tl/jdk: 7037085: Add hashCode() to Timestamp to address Findbugs warning

2011-04-18 Thread lance . andersen
Changeset: 9b3e6baad033 Author:lancea Date: 2011-04-18 12:07 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9b3e6baad033 7037085: Add hashCode() to Timestamp to address Findbugs warning Reviewed-by: darcy, alanb, emcmanus ! src/share/classes/java/sql/Timestamp.java

hg: jdk7/tl/jdk: 7036251: Correct SQLPermission constructor javadocs for permission target names

2011-04-13 Thread lance . andersen
Changeset: d9248245a88c Author:lancea Date: 2011-04-13 11:21 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d9248245a88c 7036251: Correct SQLPermission constructor javadocs for permission target names Reviewed-by: alanb ! src/share/classes/java/sql/SQLPermission.java

hg: jdk7/tl/jdk: 7007772: Address typos in javadoc for ResultSet

2011-04-12 Thread lance . andersen
Changeset: 0bae251b548b Author:lancea Date: 2011-04-12 14:32 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0bae251b548b 7007772: Address typos in javadoc for ResultSet Reviewed-by: ohair, smarks ! src/share/classes/java/sql/ResultSet.java

hg: jdk7/tl/jdk: 7035615: Address lint warnings for javax.sql.rowset & com.sun.rowset

2011-04-12 Thread lance . andersen
Changeset: 1bb95f6ac753 Author:lancea Date: 2011-04-12 12:25 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1bb95f6ac753 7035615: Address lint warnings for javax.sql.rowset & com.sun.rowset Reviewed-by: alanb, darcy ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java !

hg: jdk7/tl/jdk: 7034656: Address lint warnings for DriverManager

2011-04-07 Thread lance . andersen
Changeset: 5137806a3e34 Author:lancea Date: 2011-04-07 11:25 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5137806a3e34 7034656: Address lint warnings for DriverManager Reviewed-by: alanb, forax, ohair ! src/share/classes/java/sql/DriverManager.java

hg: jdk7/tl/jdk: 7034471: Wrap registeredDrivers in DriverManager

2011-04-06 Thread lance . andersen
Changeset: d5bc10b1aa2c Author:lancea Date: 2011-04-06 17:37 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d5bc10b1aa2c 7034471: Wrap registeredDrivers in DriverManager Reviewed-by: alanb, briangoetz ! src/share/classes/java/sql/DriverManager.java

hg: jdk7/tl/jdk: 7026898: DriverManager to now use CopyOnWriteArrayList

2011-03-17 Thread lance . andersen
Changeset: df9991dc1f0d Author:lancea Date: 2011-03-17 11:37 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/df9991dc1f0d 7026898: DriverManager to now use CopyOnWriteArrayList Reviewed-by: alanb, briangoetz ! src/share/classes/java/sql/DriverManager.java

hg: jdk7/tl/jdk: 7014095: Broken link in java.sql package specification

2011-02-04 Thread lance . andersen
Changeset: 9599534b1727 Author:lancea Date: 2011-02-04 09:07 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9599534b1727 7014095: Broken link in java.sql package specification Reviewed-by: alanb ! src/share/classes/java/sql/package.html

hg: jdk7/tl/jdk: 7000693: java.sql.Timestamp compareTo() issues using low values

2011-01-11 Thread lance . andersen
Changeset: befe813e24d2 Author:lancea Date: 2011-01-11 12:36 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/befe813e24d2 7000693: java.sql.Timestamp compareTo() issues using low values Reviewed-by: okutsu ! src/share/classes/java/sql/Timestamp.java

hg: jdk7/tl/jdk: 6544224: Remove the need of sun.reflect.misc

2011-01-10 Thread lance . andersen
Changeset: f4d755bbdabe Author:lancea Date: 2011-01-10 14:43 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f4d755bbdabe 6544224: Remove the need of sun.reflect.misc Reviewed-by: alanb ! src/share/classes/javax/sql/rowset/serial/SerialJavaObject.java

hg: jdk7/tl/jdk: 7006454: Typo in javadocs typo for Statement.executeBatch @since

2010-12-14 Thread lance . andersen
Changeset: a72e7147816f Author:lancea Date: 2010-12-14 16:08 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a72e7147816f 7006454: Typo in javadocs typo for Statement.executeBatch @since Reviewed-by: alanb ! src/share/classes/java/sql/Statement.java

hg: jdk7/tl/jdk: 6659234: Incorrect check in SerialBlob.getBytes

2010-12-09 Thread lance . andersen
Changeset: 1bf378034d39 Author:lancea Date: 2010-12-09 13:01 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1bf378034d39 6659234: Incorrect check in SerialBlob.getBytes Reviewed-by: darcy ! src/share/classes/javax/sql/rowset/serial/SerialBlob.java

hg: jdk7/tl/jdk: 2 new changesets

2010-11-19 Thread lance . andersen
Changeset: ff619988afac Author:lancea Date: 2010-11-19 17:15 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ff619988afac 7000752: Duplicate entry in RowSetResourceBundles.properties Reviewed-by: alanb ! src/share/classes/com/sun/rowset/RowSetResourceBundle.properties ! src/s

hg: jdk7/tl/jdk: 6999086: Clarify that SyncFactory.setLogger can throw an NullPointerException

2010-11-12 Thread lance . andersen
Changeset: c4a38022fdc1 Author:lancea Date: 2010-11-12 08:41 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c4a38022fdc1 6999086: Clarify that SyncFactory.setLogger can throw an NullPointerException Reviewed-by: alanb ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java

hg: jdk7/tl/jdk: 6982530: javadoc update to SyncFactory & JdbcResource bundle for synchronization issues

2010-11-12 Thread lance . andersen
Changeset: af2de4de1076 Author:lancea Date: 2010-11-12 07:15 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/af2de4de1076 6982530: javadoc update to SyncFactory & JdbcResource bundle for synchronization issues Reviewed-by: alanb ! src/share/classes/com/sun/rowset/JdbcRowSet

hg: jdk7/tl/jdk: 2 new changesets

2010-10-06 Thread lance . andersen
Changeset: 0f23a139e819 Author:lancea Date: 2010-10-06 10:09 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0f23a139e819 6988310: SyncFactory.setLogger(Logger,Level) requires unspecified security permission Reviewed-by: darcy ! src/share/classes/javax/sql/rowset/spi/SyncFac

hg: jdk7/tl/jdk: 6989139: Address JDBC Findbugs where Number type Constructor are used

2010-10-04 Thread lance . andersen
Changeset: ffaf6a35b895 Author:lancea Date: 2010-10-04 13:04 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ffaf6a35b895 6989139: Address JDBC Findbugs where Number type Constructor are used Reviewed-by: ohair ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/sh

hg: jdk7/tl/jdk: 6988993: Address Findbugs warnings for the use of String Constructor

2010-10-01 Thread lance . andersen
Changeset: 9a8022905f6a Author:lancea Date: 2010-10-01 14:36 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9a8022905f6a 6988993: Address Findbugs warnings for the use of String Constructor Reviewed-by: ohair ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/sha

hg: jdk7/tl/jdk: 6987638: javadoc update to RowSetProvider and Statement

2010-09-27 Thread lance . andersen
Changeset: 7b2b0131fa61 Author:lancea Date: 2010-09-27 18:05 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7b2b0131fa61 6987638: javadoc update to RowSetProvider and Statement Reviewed-by: darcy, alanb ! src/share/classes/java/sql/Statement.java ! src/share/classes/javax/sq

hg: jdk7/tl/jdk: 6984044: RowSet source needs to rebrand vendor references

2010-09-18 Thread lance . andersen
Changeset: 0d78b3eedecc Author:lancea Date: 2010-09-18 06:09 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0d78b3eedecc 6984044: RowSet source needs to rebrand vendor references Reviewed-by: darcy, ohair ! src/share/classes/com/sun/rowset/internal/WebRowSetXmlWriter.java !

hg: jdk7/tl/jdk: 4 new changesets

2010-09-17 Thread lance . andersen
Changeset: 7794d718ffe2 Author:lancea Date: 2010-09-17 13:23 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7794d718ffe2 6983452: SyncProvider issue for JoinRowSet implementation Reviewed-by: darcy, ohair ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java Changeset: 1

Re: code review request: 6845220: Need to update Policytool for Rowset 1.1 and JDBC 4.1 MR added permissions

2010-09-11 Thread Lance Andersen
tion* > The JDBC 4.1 and Rowset 1.1 MRs will be adding two permissions which need to > be able to be set by policytool. The permissions will be > callAbort(Connection.abort()) and setSyncFactory > (SyncFactory.setLogger/J

hg: jdk7/tl/jdk: 6983984: Fixed typo in DatabaseMetaData.getPseudoColumns() javadocs

2010-09-10 Thread lance . andersen
Changeset: 73872b992aab Author:lancea Date: 2010-09-10 18:51 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/73872b992aab 6983984: Fixed typo in DatabaseMetaData.getPseudoColumns() javadocs Reviewed-by: darcy ! src/share/classes/java/sql/DatabaseMetaData.java

hg: jdk7/tl/jdk: 6589685: JDBC 4.1 updates

2010-09-10 Thread lance . andersen
Changeset: c786a9c927fd Author:lancea Date: 2010-09-10 15:26 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c786a9c927fd 6589685: JDBC 4.1 updates Reviewed-by: darcy ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/JdbcRowSetImpl.ja

hg: jdk7/tl/jdk: 6982510: Updated SQLException subclasses from the outback for 6861385 so that the copyrights only have 2 years

2010-09-04 Thread lance . andersen
Changeset: 5cf79568f0b9 Author:lancea Date: 2010-09-04 15:37 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5cf79568f0b9 6982510: Updated SQLException subclasses from the outback for 6861385 so that the copyrights only have 2 years Reviewed-by: alanb ! src/share/classes/ja

hg: jdk7/tl/jdk: 6680198: UnmarshalException caused by incompatible serialVersionUID

2010-09-04 Thread lance . andersen
Changeset: c4defe31c94a Author:lancea Date: 2010-09-04 15:30 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c4defe31c94a 6680198: UnmarshalException caused by incompatible serialVersionUID Reviewed-by: sherman ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/sh

hg: jdk7/tl/jdk: 6843995: RowSet 1.1 updates

2010-09-04 Thread lance . andersen
Changeset: d44696691445 Author:lancea Date: 2010-09-04 13:56 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d44696691445 6843995: RowSet 1.1 updates Reviewed-by: darcy, valeriep + src/share/classes/com/sun/rowset/RowSetFactoryImpl.java ! src/share/classes/javax/sql/rowset/Ca

hg: jdk7/tl/jdk: 6861385: Updated SQLException subclasses to clarify that they may be thrown for vendor specific conditions

2010-09-04 Thread lance . andersen
Changeset: 1f99ad63eb9e Author:lancea Date: 2010-09-04 12:21 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1f99ad63eb9e 6861385: Updated SQLException subclasses to clarify that they may be thrown for vendor specific conditions Reviewed-by: alanb ! src/share/classes/java/sq

hg: jdk7/tl/jdk: 6898593: java.sql.Date.valueOf no exception if date given is not in the JDBC date escape syntax

2010-08-10 Thread lance . andersen
Changeset: 3e239fe92832 Author:lancea Date: 2010-08-10 10:07 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3e239fe92832 6898593: java.sql.Date.valueOf no exception if date given is not in the JDBC date escape syntax Reviewed-by: minqi ! src/share/classes/java/sql/Date.java

[security-dev 01196]: hg: jdk7/tl/jdk: 6737212: Fixed javadoc warning messages in RowSet classes

2009-09-09 Thread lance . andersen
Changeset: f1eb4c28b313 Author:lancea Date: 2009-09-09 20:15 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f1eb4c28b313 6737212: Fixed javadoc warning messages in RowSet classes Reviewed-by: darcy ! src/share/classes/com/sun/rowset/JdbcRowSetResourceBundle.java ! src/share/

[security-dev 01102]: hg: jdk7/tl/jdk: 6843995: Added RowsetFactory and Deprecate COMMIT_ON_ACCEPT_CHANGES, make constants final that needed to be. (also reviewed by ksaks, ryano)

2009-08-20 Thread lance . andersen
Changeset: 4ec7d1890538 Author:lancea Date: 2009-08-20 19:21 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4ec7d1890538 6843995: Added RowsetFactory and Deprecate COMMIT_ON_ACCEPT_CHANGES, make constants final that needed to be. (also reviewed by ksaks, ryano) Reviewed-by:

<    1   2