Re: Review request for CR 8049039 Need new tests for sun.securiy.x509 classes

Hi Vincent / Jason, Please find the updated webrev with minor changes like re-using println method , possible NPE fixes etc. http://cr.openjdk.java.net/~rhalade/8049039/webrev.05/ Thanks, Raghu Nair On 9/11/2014 10:28 PM, raghu k.nair wrote: Hi Jason, I have removed those lines from

Re: Review request for CR 8049039 Need new tests for sun.securiy.x509 classes

hose lines is meant for source files, not for test files. If you look at other tests, you'll see that this final sentence isn't there. Thanks, Jason On 9/4/14 6:54 AM, raghu k.nair wrote: Hi Jason, Please review the updated webrev . I have addressed your comments. http://cr.openjdk.

Re: Review request for CR 8049039 Need new tests for sun.securiy.x509 classes

e lines is meant for source files, not for test files. If you look at other tests, you'll see that this final sentence isn't there. Thanks, Jason On 9/4/14 6:54 AM, raghu k.nair wrote: Hi Jason, Please review the updated webrev . I have addressed your comments. http://cr.openjdk.java.net

Re: Review request for CR 8049039 Need new tests for sun.securiy.x509 classes

Hi Jason, Please review the updated webrev . I have addressed your comments. http://cr.openjdk.java.net/~tyan/raghu/8049039/webrev03/ <http://cr.openjdk.java.net/%7Etyan/raghu/8049039/webrev03/> Thanks, Raghu On 9/3/2014 12:47 AM, Jason Uh wrote: On 8/27/14 8:34 AM, raghu k.nair wrot

Please review CR 8048363 Implement Provider tests

Hi Brad, Could you please help me in reviewing the tests for CustomProvider and tests for various algorithms from the SUN and SunJCE providers. webrev: http://cr.openjdk.java.net/~tyan/raghu/8048363/webrev01/ Bug Id: JDK-8048363 Thanks, Raghu Nair

Please review CR 8050462 JAAS login tests for different LoginModule

Hi Max/ Andrew, Could you please help me in reviewing the tests to check for JAAS login module with different combinations of JAAS LoginModule methods (REQUIRED, REQUISITE, SUFFICIENT and OPTIONAL). webrev: http://cr.openjdk.java.net/~tyan/raghu/8050462/webrev01/ Bug Id : JDK-8050462 Th

Re: Please review CR 8049429 tests for java client server communications with various TLS/SSL combinations.

/javax/net/ssl/TLSv12/ShortRSAKey512.java Xuelei On 8/28/2014 1:27 PM, raghu k.nair wrote: Hi Andrew, Could you please help in me in reviewing the following tests. Thanks, Raghu Nair On 8/22/2014 2:58 PM, raghu k.nair wrote: Hello, Please help to review the tests for java client

Re: Please review CR 8049429 tests for java client server communications with various TLS/SSL combinations.

the PKCS12 binary file to nested stream in the test code? Here is an example about how to avoid the use of binary key store file. test/javax/net/ssl/TLSv12/ShortRSAKey512.java Xuelei On 8/28/2014 1:27 PM, raghu k.nair wrote: Hi Andrew, Could you please help in me in reviewing the

Re: Review request for CR 8048832 Implement tests for domain key store

. Although I know about the concept but I've never really used it. --Max On Aug 28, 2014, at 13:22, raghu k.nair wrote: Hi Max, Could you please help me in reviewing the following Domain Keystore tests. Thanks, Raghu Nair On 8/22/2014 1:21 PM, raghu k.nair wrote: Hello, Please he

Re: Please review CR 8049429 tests for java client server communications with various TLS/SSL combinations.

Hi Andrew, Could you please help in me in reviewing the following tests. Thanks, Raghu Nair On 8/22/2014 2:58 PM, raghu k.nair wrote: Hello, Please help to review the tests for java client server communications with various TLS/SSL combinations. Bug - https://bugs.openjdk.java.net

Re: Review request for CR 8048832 Implement tests for domain key store

Hi Max, Could you please help me in reviewing the following Domain Keystore tests. Thanks, Raghu Nair On 8/22/2014 1:21 PM, raghu k.nair wrote: Hello, Please help to review the tests for Domain Keystore tests . Bug - https://bugs.openjdk.java.net/browse/JDK-8048832 webrev- http

Re: Review request for CR 8049039 Need new tests for sun.securiy.x509 classes

Hi Vincent / Jason, Please review the updated webrev based on Jason's comments. webrev: http://cr.openjdk.java.net/~tyan/raghu/8049039/webrev02/ <http://cr.openjdk.java.net/%7Etyan/raghu/8049039/webrev02/> Thanks, Raghu Nair On 8/27/2014 9:43 AM, raghu k.nair wrote: Hi Jason,

Re: Please review CR 8048356 Secure Random provider tests

Hi Brad, Could you please review the updated webrev : http://cr.openjdk.java.net/~tyan/raghu/8048356/webrev02/ <http://cr.openjdk.java.net/%7Etyan/raghu/8048356/webrev02/> Updates are based on Bernd's comments. Thanks, Raghu Nair On 8/27/2014 4:02 PM, raghu k.nair wrote

Re: Please review CR 8048356 Secure Random provider tests

Von: raghu k.nair <mailto:raghu.k.n...@oracle.com> Gesendet: ‎27.‎08.‎2014 11:00 An: Bradford Wetmore <mailto:bradford.wetm...@oracle.com> Cc: security-dev@openjdk.java.net <mailto:security-dev@openjdk.java.net> Betreff: Please review CR 8048356 Secu

Please review CR 8048356 Secure Random provider tests

Hi Brad, Could you please help in reviewing the following test. webrev: http://cr.openjdk.java.net/~tyan/raghu/8048356/webrev01/ Bug : JDK-8048356 Thanks, Raghu Nair

Re: Updated review request for CR 8048362 Test doPrivileged with accomplice

k.nair wrote: Hello, Please review the updated webrev : http://cr.openjdk.java.net/~tyan/raghu/8048362/webrev.04/ <http://cr.openjdk.java.net/%7Etyan/raghu/8048362/webrev.04/> I have updated the path of JavaToolUtils in DoPrivAccompliceTest.java. Thanks, Raghu On 8/12/2014 11:06 PM, raghu

Re: Review request for CR 8049039 Need new tests for sun.securiy.x509 classes

again, I'm not a Reviewer, so you still need an official review. Thanks, Jason On 08/25/2014 03:59 AM, raghu k.nair wrote: Hi Vincent / Jason, Could you please help in reviewing the following test. Thanks, Raghu Nair On 8/12/2014 10:28 AM, raghu k.nair wrote: Hello, Please rev

Re: Review request for CR 8049233 Need new tests for testing openssl created certificate

Hi Vincent, Could you help in reviewing the following webrev. Thanks, Raghu On 8/4/2014 12:51 PM, raghu k.nair wrote: Hello , Please review the tests for openssl generated certificates and CRLS. Changes made : CustomCertificateFactory.java is made thread safe. Here is the new webrev

Re: Review request for CR 8049039 Need new tests for sun.securiy.x509 classes

Hi Vincent / Jason, Could you please help in reviewing the following test. Thanks, Raghu Nair On 8/12/2014 10:28 AM, raghu k.nair wrote: Hello, Please review the tests for sun.security.x509 classes. These cover tests for GeneralName, GeneralNames, GeneralSubtree, GeneralSubtrees

Please review CR 8049429 tests for java client server communications with various TLS/SSL combinations.

Hello, Please help to review the tests for java client server communications with various TLS/SSL combinations. Bug - https://bugs.openjdk.java.net/browse/JDK-8049429 webrev-http://cr.openjdk.java.net/~tyan/raghu/8049429/webrev01/

Review request for CR 8048832 Implement tests for domain key store

Hello, Please help to review the tests for Domain Keystore tests . Bug - https://bugs.openjdk.java.net/browse/JDK-8048832 webrev- http://cr.openjdk.java.net/~tyan/raghu/8048832/webrev01/ Thanks Raghu Nair

Re: Updated review request for CR 8048362 Test doPrivileged with accomplice

Hello, Please review the updated webrev : http://cr.openjdk.java.net/~tyan/raghu/8048362/webrev.04/ <http://cr.openjdk.java.net/%7Etyan/raghu/8048362/webrev.04/> I have updated the path of JavaToolUtils in DoPrivAccompliceTest.java. Thanks, Raghu On 8/12/2014 11:06 PM, raghu k.nair

Re: Updated review request for CR 8048362 Test doPrivileged with accomplice

iced a few typos: DoPrivTest.java l.26 and DoPrivAccompliceTest.java l.34-38 On 4 Aug 2014, at 08:11, raghu k.nair wrote: Hello , Please review the updated tests for doPrivilaged with accomplice. Updated the test to use @compile tag rather than compiling using API. Bug

Review request for CR 8049039 Need new tests for sun.securiy.x509 classes

Hello, Please review the tests for sun.security.x509 classes. These cover tests for GeneralName, GeneralNames, GeneralSubtree, GeneralSubtrees, IPAddressName and IssuerAlternativeNameExtension. webrev: http://cr.openjdk.java.net/~rhalade/8049039/webrev.00/ Bug: https://bugs.openjdk.java.net/

Re: Updated review request for CR 8048362 Test doPrivileged with accomplice

Hello , Please find the updated the webrev . http://cr.openjdk.java.net/~rhalade/8048362/webrev.02/ Thanks, Raghu On 8/8/2014 7:21 PM, Vincent Ryan wrote: Code looks fine. I noticed a few typos: DoPrivTest.java l.26 and DoPrivAccompliceTest.java l.34-38 On 4 Aug 2014, at 08:11, raghu

Re: Review request for CR 8049233 Need new tests for testing openssl created certificate

.01/> Thanks, Raghu On 7/28/2014 11:50 AM, raghu k.nair wrote: Hello, Please review the tests for openssl generated certificates and CRLS. This tests java.security.cert.Certificate.verify() method and behaviors of the following classes java.security.X509CRL, java.security.X509CRLSe

Updated review request for CR 8048362 Test doPrivileged with accomplice

Hello , Please review the updated tests for doPrivilaged with accomplice. Updated the test to use @compile tag rather than compiling using API. Bug -https://bugs.openjdk.java.net/browse/JDK-8048362 webrev - http://cr.openjdk.java.net/~rhalade/8048362/webrev.01/

Review request for CR 8049233 Need new tests for testing openssl created certificate

Hello, Please review the tests for openssl generated certificates and CRLS. This tests java.security.cert.Certificate.verify() method and behaviors of the following classes java.security.X509CRL, java.security.X509CRLSelector, java.security.X509CRLRevocationReason and java.security.X50

Review request for CR 8049233 Need new tests for testing openssl created certificate

Hello, Please review the tests for openssl generated certificates and CRLS. This tests java.security.cert.Certificate.verify() method and behaviors of the following classes java.security.X509CRL, java.security.X509CRLSelector, java.security.X509CRLRevocationReason and java.security.X50

Review request for CR 8048362 Test doPrivileged with accomplice

Hello, Please review the test for doPrivliaged with accomplice. Bug - https://bugs.openjdk.java.net/browse/JDK-8048362 webrev- http://cr.openjdk.java.net/~rhalade/8048362/webrev.00/ Thanks, Raghu Nair