Re: RFR: 8255546: Missing coverage for javax.smartcardio.CardPermission and ResponseAPDU

So you have converted the Test to use JUnit other than adding few new Test cases. It looks fine to me. Thanks, Siba > On 06-Nov-2020, at 6:08 PM, Fernando Guallini > wrote: > > This patch is to add code coverage to the following methods > - javax.smartcardio.CardPermission::**implies** (1)

[16] RFR: 8247968: test/jdk/javax/crypto/SecretKeyFactory/security.properties has wrong header

Hi, Please review a minor fix for the following patch, JBS: https://bugs.openjdk.java.net/browse/JDK-8247968 Diff: diff -r 5f90d52615de test/jdk/javax/crypto/SecretKeyFactory/security.properties --- a/test/jdk/javax/crypto/SecretKeyFactory/secur

Re: [15] RFR: 8209632: Develop new tests for EdDSA API

It’s a typo issue. I can add missing character “d” before pushing the change. Thanks, Siba > On 14-May-2020, at 9:00 AM, Anthony Scarpino > wrote: > > On 5/13/20 2:55 AM, sibabrata.sa...@oracle.com wrote: >> Hi Tony, >> Please review the patch of new Tests developed

[15] RFR: 8209632: Develop new tests for EdDSA API

Hi Tony, Please review the patch of new Tests developed for EdDSA, JBS: https://bugs.openjdk.java.net/browse/JDK-8209632 Webrev: http://cr.openjdk.java.net/~ssahoo/8209632/webrev.00/ Than

Re: [15] RFR: 8242335: Additional Tests for RSASSA-PSS

#x27;t seem too > useful. The code path should be exactly the same as the non-reflection one. > Maybe just remove it. > > Rest looks fine. > > Thanks, > Valerie > On 4/28/2020 12:38 AM, sibabrata.sa...@oracle.com > <mailto:sibabrata.sa...@oracle

[15] RFR: 8242335: Additional Tests for RSASSA-PSS

Hi Valerie, Please review the patch for, JBS: https://bugs.openjdk.java.net/browse/JDK-8242335 Webrev: http://cr.openjdk.java.net/~ssahoo/8242335/webrev.00/ These are additional Tests deve

[15] RFR: 8242929: The values of jdk.tls.namedGroups should not be case-sensitive

Hi Xuelei, Please review the patch for, JBS: https://bugs.openjdk.java.net/browse/JDK-8242929 Webrev: http://cr.openjdk.java.net/~ssahoo/8242929/webrev.00/ This is a small fix to make name

[14]:RFR:8235874: The ordering of Cipher Suites is not maintained provided through “jdk.tls.client.cipherSuites” and “jdk.tls.server.cipherSuites” system property.

Hi, Please review the patch for, JBS: https://bugs.openjdk.java.net/browse/JDK-8235874 Webrev: http://cr.openjdk.java.net/~ssahoo/8235874/webrev.00/ This is a small fix to maintain the ord

[14]RFR: 8234728: Some security tests should support TLSv1.3

Hi Xuelei, Please review the patch for, JBS: https://bugs.openjdk.java.net/browse/JDK-8234728 Webrev: http://cr.openjdk.java.net/~ssahoo/8234728/webrev.00/ Change: The change it to support

[14]RFR: 8234723: javax/net/ssl/TLS tests support TLSv1.3

Hi Xuelei, Please review the patch for, JBS: https://bugs.openjdk.java.net/browse/JDK-8234723 Webrev: http://cr.openjdk.java.net/~ssahoo/8234723/webrev.00/ Change: This is a small change t

[14]RFR: 8234725: sun/security/ssl/SSLContextImpl tests support TLSv1.3

Hi Xuelei, Please review the patch for, JBS: https://bugs.openjdk.java.net/browse/JDK-8234725 Webrev: http://cr.openjdk.java.net/~ssahoo/8234725/webrev.00/ Change: This is a small change t