Re: [11] RFR 8206189: sun/security/pkcs12/EmptyPassword.java fails with Sequence tag error

2018-07-11 Thread Xuelei Fan
Looks fine to me. Thanks, Xuelei On 7/9/2018 8:39 AM, Weijun Wang wrote: Please take a review at http://cr.openjdk.java.net/~weijun/8206189/webrev.00/ When the password is empty, some pkcs12 implementations actually use "new char[1]" internally. Therefore PKCS12KeyStore tries both "new

[11] RFR 8206189: sun/security/pkcs12/EmptyPassword.java fails with Sequence tag error

2018-07-09 Thread Weijun Wang
Please take a review at http://cr.openjdk.java.net/~weijun/8206189/webrev.00/ When the password is empty, some pkcs12 implementations actually use "new char[1]" internally. Therefore PKCS12KeyStore tries both "new char[0]" and "new char[1]". Occasionally, an encrypted block can be decrypted