Re: [14] RFR 8228659: Record which Java methods are called by native codes in JGSS and JAAS

I've changed all method calls to "called by" and keep field references as "used by". I also removed the periods. Pushed to https://hg.openjdk.java.net/jdk/jdk/rev/e4ce29f6094e. Thanks, Max > On Sep 24, 2019, at 8:21 PM, Sean Mullan wrote: > > Just a couple of minor comments: > > 1. For comm

Re: [14] RFR 8228659: Record which Java methods are called by native codes in JGSS and JAAS

Just a couple of minor comments: 1. For comments like this: // Warning: Used by NativeCreds.c and nativeccache.c I think not capitalizing "Used" would be better. Also, would "called by" be more appropriate? Result: // Warning: called by NativeCreds.c and nativeccache.c 2. Sometimes you end

Re: [14] RFR 8228659: Record which Java methods are called by native codes in JGSS and JAAS

Ping again. > On Jul 26, 2019, at 11:24 PM, Weijun Wang wrote: > > Please review the change at > > http://cr.openjdk.java.net/~weijun/8228659/webrev.00/ > > Most of the change is new comments on internal Java methods called by native > code. I also take this chance to simply Ticket creation

[14] RFR 8228659: Record which Java methods are called by native codes in JGSS and JAAS

Please review the change at http://cr.openjdk.java.net/~weijun/8228659/webrev.00/ Most of the change is new comments on internal Java methods called by native code. I also take this chance to simply Ticket creation in nativeccache.c and NativeCreds.c. There is no need to call `new Ticket(new