Re: [8] 8008171: Refactor KeyStore.DomainLoadStoreParameter as a standalone class

2013-10-09 Thread Vincent Ryan
Thanks. On 8 Oct 2013, at 19:33, Sean Mullan wrote: Looks good to me. --Sean On 10/08/2013 02:14 PM, Vincent Ryan wrote: Please review the following change - it's a simple re-factoring to promote a nested class to a stand-alone class: Bug:

Re: [8] 8008171: Refactor KeyStore.DomainLoadStoreParameter as a standalone class

2013-10-09 Thread Vincent Ryan
Thanks Max. On 9 Oct 2013, at 01:51, Weijun Wang wrote: The code change looks fine. Do we need a CCC for it? Yes. CCC has been approved. Thanks Max p.s. I would use the bugs.openjdk.java.net URL. Right. My webrev generates the old URL by default. I've changed it to use OpenJDK in

[8] 8008171: Refactor KeyStore.DomainLoadStoreParameter as a standalone class

2013-10-08 Thread Vincent Ryan
Please review the following change - it's a simple re-factoring to promote a nested class to a stand-alone class: Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008171 Webrev: http://cr.openjdk.java.net/~vinnie/8008171/webrev.00/ Thanks.

Re: [8] 8008171: Refactor KeyStore.DomainLoadStoreParameter as a standalone class

2013-10-08 Thread Sean Mullan
Looks good to me. --Sean On 10/08/2013 02:14 PM, Vincent Ryan wrote: Please review the following change - it's a simple re-factoring to promote a nested class to a stand-alone class: Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008171 Webrev:

Re: [8] 8008171: Refactor KeyStore.DomainLoadStoreParameter as a standalone class

2013-10-08 Thread Weijun Wang
The code change looks fine. Do we need a CCC for it? Thanks Max p.s. I would use the bugs.openjdk.java.net URL. On 10/9/13 2:14 AM, Vincent Ryan wrote: Please review the following change - it's a simple re-factoring to promote a nested class to a stand-alone class: Bug: