On 08/07/2013 04:49 PM, Weijun Wang wrote:
On 8/8/13 7:13 AM, Jason Uh wrote:
On 8/6/13 6:30 PM, Weijun Wang wrote:
One question:
In src/share/classes/sun/security/x509/X509Key.java, two fields are now
not recommended:
@Deprecated
protected byte[] key = null;
/*
*
Joe, Sean,
Could I please get a review of this changeset? This change fixes
deprecation warnings in:
sun.security.provider
sun.security.rsa
sun.security.x509
In sun.security.provider and sun.security.rsa, I change the use of
sun.security.x509.X509Key's key bytes to the BitArray form of
Change looks fine.
Minor issue:
Extra parenthesis in
src/share/classes/sun/security/rsa/RSAPublicKeyImpl.java:
+byte[] keyArray =
+(new DerValue(DerValue.tag_Sequence,
+ out.toByteArray())).toByteArray();
One question:
In
Looks fine to me.
BTW, I was wondering whether we can remove the deprecated attributes in
X509Key after this fix. And as only the encodedKey is serialized, I
think we can use the @serial tag and transient fields to make the code
more friendly.
Xuelei
On 8/7/2013 7:46 AM, Jason Uh wrote:
Joe,