gt; Artem
>>>
>>>
>>> On 08/12/2016 02:38 PM, Jamil Nimeh wrote:
>>>> Thank you Artem. The fix looks good. You just need a +1 from an
>>>> official reviewer.
>>>>
>>>>
>>>>
>>>> --Jamil
>>&g
good. You just need a +1 from an
official reviewer.
--Jamil
Original message
From: Artem Smotrakov
Date: 8/12/16 1:07 PM (GMT-08:00)
To: Jamil Nimeh , Security Dev OpenJDK
Subject: Re: [9] RFR: 8162484:
javax/net/ssl/Stapling/SSLSocketWithStapling.java test fails
intermitt
;> Original message
>> From: Artem Smotrakov
>> Date: 8/12/16 1:07 PM (GMT-08:00)
>> To: Jamil Nimeh , Security Dev OpenJDK
>>
>> Subject: Re: [9] RFR: 8162484:
>> javax/net/ssl/Stapling/SSLSocketWithStapling.java test fails
>>
PM (GMT-08:00)
To: Jamil Nimeh , Security Dev OpenJDK
Subject: Re: [9] RFR: 8162484:
javax/net/ssl/Stapling/SSLSocketWithStapling.java test fails
intermittently with "Address already in use" error
No problem.
http://cr.openjdk.java.net/~asmotrak/8162484/webrev.02/
Artem
On 08/12/
/SSLSocketWithStapling.java test fails intermittently
with "Address already in use" error
No problem.
http://cr.openjdk.java.net/~asmotrak/8162484/webrev.02/
Artem
On 08/12/2016 12:02 PM, Jamil Nimeh wrote:
> For the tests as we use them today we don't intend the server to
> re
No problem.
http://cr.openjdk.java.net/~asmotrak/8162484/webrev.02/
Artem
On 08/12/2016 12:02 PM, Jamil Nimeh wrote:
For the tests as we use them today we don't intend the server to
restart. The intent of SimpleOCSPServer was to be of use for a
variety of testing purposes. I don't know tha
For the tests as we use them today we don't intend the server to
restart. The intent of SimpleOCSPServer was to be of use for a variety
of testing purposes. I don't know that we can say for all intended uses
that we'll *never* need to restart it. That's why I'd like to keep the
unbound socke
Hi Jamil,
There was no any specific reason to remove ServerSocket.bind() call.
ServerSocket(0) constructor creates a server socket, automatically bound
to a random free port. If I am not missing something, it doesn't look
necessary to set the SO_REUSEADDR socket options if the server is not
g
Hi Artem, more comments in-line
On 8/11/2016 11:46 AM, Artem Smotrakov wrote:
Hi Jamil,
Thank you for review. Please see inline.
On 08/10/2016 04:16 PM, Jamil Nimeh wrote:
Hi Artem,
I'm not an official reviewer but the solution for making the servers
reject connections rather than stop an
Hi Jamil,
Thank you for review. Please see inline.
On 08/10/2016 04:16 PM, Jamil Nimeh wrote:
Hi Artem,
I'm not an official reviewer but the solution for making the servers
reject connections rather than stop and start looks pretty fair to me
and seems like a nice way to simulate a downed O
Hi Artem,
I'm not an official reviewer but the solution for making the servers
reject connections rather than stop and start looks pretty fair to me
and seems like a nice way to simulate a downed OCSP responder instead of
having to bounce it. A couple comments/questions:
I'm a bit surprised
Hello,
Please review this update for OCSP stapling tests.
The tests use test/java/security/testlibrary/SimpleOCSPServer.java which
try to re-use a server port if the server restarted. Looks like
sometimes it may cause "Address already in use" error.
The patch updates OCSP stapling tests with
12 matches
Mail list logo
