On 08/09/2016 10:00 PM, Valerie Peng wrote:
OracleUcrypto provider already separates them in two classes: The
cloneable libMD digest impls are encapsulated by a class which
implements Cloneable and the new un-cloneable Ucrypto digest impls are
in a class which does not.
I wasn't sure if we can s
OracleUcrypto provider already separates them in two classes: The
cloneable libMD digest impls are encapsulated by a class which
implements Cloneable and the new un-cloneable Ucrypto digest impls are
in a class which does not.
I wasn't sure if we can safely assume that an instance supports clo
Thanks for the review~
Your point is valid for default configuration. But in the rare case
where the new jdk.security.provider.preferred property is set, the most
preferred provider may not be the one which supplied the digest object
for the generic getInstance() call.
So, instead of removin
Or better yet, just change the ucrypto impl to not implement Cloneable
regardless what Solaris version you are on. Then you can just check each
MessageDigest impl to see if it is an instanceof Cloneable rather than
calling clone on each.
--Sean
On 08/09/2016 09:38 AM, Sean Mullan wrote:
Is t
Is there any way to split the Ucrypto MessageDigest implementation into
2 classes, one that implements Cloneable and the other which doesn't,
and use the appropriate one depending on which OS version you are on?
This way, instead of calling clone and catching
CloneNotSupportedException, you co
Your fix looks good. One comment is that you could trim the Provider[] to
exclude the most-preferred provider (at index=0).
Thanks.
> On 5 Aug 2016, at 03:01, Valerie Peng wrote:
>
>
> Anyone has time to review this fix? The code change is in only one file and
> straightforward if you agree
Anyone has time to review this fix? The code change is in only one file
and straightforward if you agree with the approach.
Starting S11.3 and S12, OracleUcrypto provider switched to new Ucrypto
APIs for message digest operations and there is no clone support.
This affects the MAC impls of SunJ
