Re: [9] RFR 8171443: (spec) An ALPN callback function may also ignore ALPN

2016-12-22 Thread Bradford Wetmore
+1. Brad On 12/22/2016 8:58 AM, Xuelei Fan wrote: Looks fine to me. Thanks, Xuelei On 12/22/2016 2:38 AM, Vincent Ryan wrote: Please review this spec change to allow an ALPN callback function to also disable ALPN usage and return no ALPN extension value during a TLS handshake. Thanks. Bu

Re: [9] RFR 8171443: (spec) An ALPN callback function may also ignore ALPN

2016-12-22 Thread Xuelei Fan
Looks fine to me. Thanks, Xuelei On 12/22/2016 2:38 AM, Vincent Ryan wrote: Please review this spec change to allow an ALPN callback function to also disable ALPN usage and return no ALPN extension value during a TLS handshake. Thanks. Bug: https://bugs.openjdk.java.net/browse/JDK-8171443 W

Re: [9] RFR 8171443: (spec) An ALPN callback function may also ignore ALPN

2016-12-22 Thread Vincent Ryan
Hello Simone, Throwing an exception is certainly another option but we chose these 3 specific return values for the callback so that they match the existing behaviour of SSLEngine.getApplicationProtocol / SSLEngine.getHandshakeApplicationProtocol and the SSLSocket equivalents. http://download.j

Re: [9] RFR 8171443: (spec) An ALPN callback function may also ignore ALPN

2016-12-22 Thread Simone Bordet
Vincent, On Thu, Dec 22, 2016 at 11:38 AM, Vincent Ryan wrote: > Please review this spec change to allow an ALPN callback function to also > disable ALPN usage > and return no ALPN extension value during a TLS handshake. As I understand it, the callback needs to convey 3 results: 1. a success -

[9] RFR 8171443: (spec) An ALPN callback function may also ignore ALPN

2016-12-22 Thread Vincent Ryan
Please review this spec change to allow an ALPN callback function to also disable ALPN usage and return no ALPN extension value during a TLS handshake. Thanks. Bug: https://bugs.openjdk.java.net/browse/JDK-8171443 Webrev: http://cr.openjdk.java.net/~vinnie/8171443/webrev.01/