Re: [9] Request for Review: 8021804: Certpath validation fails if validity period of root cert does not include validity period of intermediate cert

Looks good. Thanks, Sean On 03/11/2014 08:26 PM, Jason Uh wrote: Hi Sean, After taking another look at the test, I wanted to make one minor simplification. I've removed the CRL from the test and disabled revocation because they weren't adding anything important to the test (which still passes)

Re: [9] Request for Review: 8021804: Certpath validation fails if validity period of root cert does not include validity period of intermediate cert

Hi Sean, After taking another look at the test, I wanted to make one minor simplification. I've removed the CRL from the test and disabled revocation because they weren't adding anything important to the test (which still passes). I'll push if you're okay with that. If you want to take a loo

Re: [9] Request for Review: 8021804: Certpath validation fails if validity period of root cert does not include validity period of intermediate cert

Thanks, Sean. I'll push with a set date. On 3/11/14 2:59 PM, Sean Mullan wrote: In the test, you should probably call PKIXParameters.setValidity with a fixed date so that the test won't start failing in 2024. Yes, I know that's a long time away! Check out other tests to see examples. Otherwise,

Re: [9] Request for Review: 8021804: Certpath validation fails if validity period of root cert does not include validity period of intermediate cert

In the test, you should probably call PKIXParameters.setValidity with a fixed date so that the test won't start failing in 2024. Yes, I know that's a long time away! Check out other tests to see examples. Otherwise, fix looks good and you can push without a re-review. --Sean On 03/10/2014 08:

Re: [9] Request for Review: 8021804: Certpath validation fails if validity period of root cert does not include validity period of intermediate cert

Thanks, Sean. I've simplified my changes to only removing the call to setValidityPeriod. http://cr.openjdk.java.net/~juh/8021804/webrev.01 Jason On 3/10/14 12:00 PM, Sean Mullan wrote: Hi Jason, Sorry for the delay in reviewing this. On 02/28/2014 02:54 PM, Jason Uh wrote: Hi Sean, Could

Re: [9] Request for Review: 8021804: Certpath validation fails if validity period of root cert does not include validity period of intermediate cert

Hi Jason, Sorry for the delay in reviewing this. On 02/28/2014 02:54 PM, Jason Uh wrote: Hi Sean, Could I please get a review of this change? This fix allows a certpath to be validated when a certificate issued by a version 1 trusted cert has a validity period that doesn't fall within the vali

[9] Request for Review: 8021804: Certpath validation fails if validity period of root cert does not include validity period of intermediate cert

Hi Sean, Could I please get a review of this change? This fix allows a certpath to be validated when a certificate issued by a version 1 trusted cert has a validity period that doesn't fall within the validity of the issuer. Trust anchors whose validity do contain the issued cert's validity p