Re: [PATCH] 8158517: Minor optimizations to ISO10126PADDING

2016-12-07 Thread Bernd Eckenfels
Thanks for committing, looks fine with me as well. Gruss Bernd On Wed, Dec 7, 2016 at 5:25 PM +0100, "Sean Mullan" wrote: Looks good. Minor comment - update the copyright to include 2016 as the last year it was updated, ex: * Copyright (c) 2003, 2016, Oracle and/or its affilia

Re: [PATCH] 8158517: Minor optimizations to ISO10126PADDING

2016-12-07 Thread Sean Mullan
Looks good. Minor comment - update the copyright to include 2016 as the last year it was updated, ex: * Copyright (c) 2003, 2016, Oracle and/or its affiliates. All rights reserved. Send me the updated diffs and I will push it for you. --Sean On 12/7/16 9:14 AM, Adam Petcher wrote: Minor

[PATCH] 8158517: Minor optimizations to ISO10126PADDING

2016-12-07 Thread Adam Petcher
Minor improvement/optimization to ISO10126Padding. Simplifies the code a bit and requests one fewer random byte. No regression test is provided because this is a code cleanup, and the functionality is covered by existing tests. Bug: https://bugs.openjdk.java.net/browse/JDK-8158517 Diff: di