subject:"\[Update\]\: webrev request\: JDK\-6996377"

Re: [Update]: webrev request: JDK-6996377

2014-05-09 Thread Sean Mullan

Looks good, very comprehensive test. My only comment is that it would be helpful to add the keytool command you used to create each certificate in a comment above the base64-encoded String. Thanks, Sean On 05/08/2014 09:23 PM, Jamil Nimeh wrote: Hello all, Updated webrev to account for Sean

Re: [Update]: webrev request: JDK-6996377

2014-05-08 Thread Xuelei Fan

test/sun/security/validator/ConstructorTest.java Missed a "," in the copyright date line. May only need 2014 as this is a new test. - * Copyright (c) 2010, 2014 Oracle and/or its affiliates. ... + * Copyright (c) 2010, 2014, Oracle and/or its aff

[Update]: webrev request: JDK-6996377

2014-05-08 Thread Jamil Nimeh

Hello all, Updated webrev to account for Sean and Xuelei's comments is here: http://cr.openjdk.java.net/~ascarpino/6996377/webrev.02/ Thank you, --Jamil On 05/07/2014 12:12 PM, Jamil Nimeh wrote: Please review the webrev for JDK-6