[Update] Re: RFR 6562449: LoginContext does not all allow overloading of login method in LoginModule

2014-08-21 Thread Jamil Nimeh
One more update, with Max's nits addressed: http://cr.openjdk.java.net/~weijun/6562449/webrev.03 --Jamil On 08/20/2014 02:38 PM, Jamil Nimeh wrote: Hello everyone, This is an updated review that addresses comments from the original webrev.

Re: [Update] Re: RFR 6562449: LoginContext does not all allow overloading of login method in LoginModule

2014-08-21 Thread Wang Weijun
Code change looks fine, but you will need to translate the file path to new module style. There are also 2 useless imports: import java.util.LinkedList; import java.security.AccessController; --Max On Aug 22, 2014, at 9:12, Jamil Nimeh jamil.j.ni...@oracle.com wrote: One more update, with

[Update] Re: RFR 6562449: LoginContext does not all allow overloading of login method in LoginModule

2014-08-20 Thread Jamil Nimeh
Hello everyone, This is an updated review that addresses comments from the original webrev. http://cr.openjdk.java.net/~ascarpino/6562449/webrev.02 Thank you, --Jamil On 08/11/2014 02:56 PM, Jamil Nimeh wrote: Hello all, This webrev covers a fix to LoginContext so it no longer selects the