Looks good to me.
At 08:40 AM 10/11/2011, Vincent Ryan wrote:
>Hello Michael,
>
>I agree with your preference for symmetric handling of the EC point
>encoding/decoding. So I've modified the decoder method in P11Key.java
>to use the security provider config attribute 'useEcX963Encoding' just
>like
Hello Michael,
I agree with your preference for symmetric handling of the EC point
encoding/decoding. So I've modified the decoder method in P11Key.java
to use the security provider config attribute 'useEcX963Encoding' just
like the encoder method in P11ECKeyFactory.java
The updated webrev is at:
At 04:13 PM 9/23/2011, Vincent Ryan wrote:
>On 09/23/11 05:41 PM, Michael StJohns wrote:
>> Heh - I thought this looked familiar.
>>
>> Please take a look at my comments in bug 6763530, especially the fix for
>> P11Key around line 1017.
>>
>
>I didn't see any comments from you in bug 6763530
On 09/23/11 05:41 PM, Michael StJohns wrote:
> Heh - I thought this looked familiar.
>
> Please take a look at my comments in bug 6763530, especially the fix for
> P11Key around line 1017.
>
I didn't see any comments from you in bug 6763530?
> Would it make sense to back out the fix that
Heh - I thought this looked familiar.
Please take a look at my comments in bug 6763530, especially the fix for P11Key
around line 1017.
Would it make sense to back out the fix that was put into P11Key to fix that
bug in favor of a provider based solution (e.g. same boolean check)?
Other
Thanks for your feedback Michael. I agree that your provider-based solution is
preferable. Here's a revised webrev:
http://cr.openjdk.java.net/~vinnie/7054637/webrev.01/
On 09/22/11 11:18 PM, Michael StJohns wrote:
> Hi Vincent -
>
> Sorry - it took me a few days to look at this. I can't supp
Hi Vincent -
Sorry - it took me a few days to look at this. I can't support it.
I think this the wrong way to do things - specifically the dependence on the
presence of a PKCS11 attribute in the Vendor space.
You've got a value in PKCS11Constants
+/* Only the raw encoding for an EC
On 09/14/11 09:30 PM, Valerie (Yu-Ching) Peng wrote:
>
> As long as Solaris supports both key formats after fixing 6830224, then it'd
> be
> fine, I guess.
>
> Oh, are you gonna change the synopsis to describe the cause of the problem?
> I'd
> also prefer it that way.
I've fixed that:
http:
As long as Solaris supports both key formats after fixing 6830224, then
it'd be fine, I guess.
Oh, are you gonna change the synopsis to describe the cause of the
problem? I'd also prefer it that way.
Thanks,
Valerie
On 09/14/11 11:17, Vincent Ryan wrote:
Please review the following fix to
Please review the following fix to the SunPKCS11 JCE provider:
http://cr.openjdk.java.net/~vinnie/7054637/webrev.00/
The problem is that some older PKCS11 tokens support only the raw encoding for
EC point in Elliptic Curve public keys. This fix introduces a configuration
attribute that controls w
10 matches
Mail list logo
