Re: 7094155 Code Review Request

2011-10-27 Thread Xuelei Fan
On 10/27/2011 9:43 PM, Sean Mullan wrote: > On 10/26/11 10:50 PM, Xuelei Fan wrote: >> Looks fine to me. >> >> I also look at some other places that use the Node.getLocalName(). As >> this method may return null, I was wondering it would be nice if we also >> make changes to >> com/sun/org/apache/x

Re: 7094155 Code Review Request

2011-10-27 Thread Sean Mullan
On 10/26/11 10:50 PM, Xuelei Fan wrote: > Looks fine to me. > > I also look at some other places that use the Node.getLocalName(). As > this method may return null, I was wondering it would be nice if we also > make changes to > com/sun/org/apache/xml/internal/security/utils/ElementCheckerImpl.jav

Re: 7094155 Code Review Request

2011-10-26 Thread Xuelei Fan
Looks fine to me. I also look at some other places that use the Node.getLocalName(). As this method may return null, I was wondering it would be nice if we also make changes to com/sun/org/apache/xml/internal/security/utils/ElementCheckerImpl.java, line 10: 9 if ((el == null) || 10 ns!=el.getN

7094155 Code Review Request

2011-10-26 Thread Sean Mullan
Hi Xuelei, Could you please review my fix for 7094155 (JSR105 code throws javax.xml.crypto.URIReference when running into Java 7 VM)? webrev: http://cr.openjdk.java.net/~mullan/webrevs/7094155/webrev.00/ Thanks, Sean