Looks fine. The bug description is a bit dramatic though :) I would
change it to not mention the Java version (which is already in the
affectsVersion/Introduced in fields) and more descriptive of what is
being changed, ex: "Revert TLS 1.3 change that wrapped IOExceptions".
--Sean
On 12/3/19 3
Hi,
Could I get the following update reviewed?
http://cr.openjdk.java.net/~xuelei/8235263/webrev.00/
In the SunJSSE provider, IOExceptions in application output stream was
updated to be wrapped into SSLException so as to close underlying
connections automatically. However, there are compat
Thank you, Michael! I will go ahead for OpenJDK code review.
Xuelei
On 12/3/2019 5:45 AM, Michael Osipov wrote:
Am 2019-12-02 um 19:34 schrieb Xuelei Fan:
Hi,
Could someone please help to verify if the attached patch (JDK 14) works
HttpComponents?
The patch has been confirmed by the commun
Am 2019-12-02 um 19:34 schrieb Xuelei Fan:
Hi,
Could someone please help to verify if the attached patch (JDK 14) works
HttpComponents?
The patch has been confirmed by the community. Can you go ahead and
apply it and as well as port back to 11u?
Michael
On 01/12/2019 13:37, Michael Osipov wrote:
Hi folks,
I am one of the Apache HttpComponents committers and we get these nags
once in a while:
-
https://github.com/apache/httpcomponents-client/pull/178#discussion_r351492056
- https://issues.apache.org/jira/browse/HTTPCLIENT-2032
- https://st
Hi,
On Mon, Dec 2, 2019 at 7:36 PM Xuelei Fan wrote:
>
> Hi,
>
> Could someone please help to verify if the attached patch (JDK 14) works
> HttpComponents?
I'm not sure I see the difference between a generic IOException and
SSLHandshakeException.
If a client is connecting to a busy proxy that s
Am 2019-12-02 um 19:34 schrieb Xuelei Fan:
Hi,
Could someone please help to verify if the attached patch (JDK 14) works
HttpComponents?
Requested a review of the patch and will try myself.
I see also other spots where IOException is wrapped inside an SSLException:
*
https://github.com/AdoptOp
Hi,
Could someone please help to verify if the attached patch (JDK 14) works
HttpComponents?
Thanks & Regards,
Xuelei
On 12/1/2019 5:37 AM, Michael Osipov wrote:
Hi folks,
I am one of the Apache HttpComponents committers and we get these nags
once in a while:
-
https://github.com/apache/ht
Hi folks,
I am one of the Apache HttpComponents committers and we get these nags
once in a while:
-
https://github.com/apache/httpcomponents-client/pull/178#discussion_r351492056
- https://issues.apache.org/jira/browse/HTTPCLIENT-2032
- https://stackoverflow.com/q/56306216/696632
It all boils d
