Re: Allow configure to detect if EC implementation is present

2013-03-18 Thread Omair Majid
Hi, On 03/15/2013 07:15 AM, David Holmes wrote: > On 15/03/2013 7:04 PM, Erik Joelsson wrote: >> And as David pointed out, please notify me and Tim Bell when you push > > If I am added to that list we will have global timezone coverage :) > Though we should all see the push notifications anyway,

Re: Allow configure to detect if EC implementation is present

2013-03-15 Thread Vincent Ryan
You're correct Omar. That target directory is not always present as I had indicated below. The new and old builds are indeed consistent in the way they handle that. Thanks. On 14 Mar 2013, at 19:50, Omair Majid wrote: > On 03/14/2013 03:14 PM, Vincent Ryan wrote: >> The DISABLE_INTREE_EC flag

Re: Allow configure to detect if EC implementation is present

2013-03-15 Thread David Holmes
On 15/03/2013 7:04 PM, Erik Joelsson wrote: And as David pointed out, please notify me and Tim Bell when you push If I am added to that list we will have global timezone coverage :) Though we should all see the push notifications anyway, it should minimize the window of potential breakage.

Re: Allow configure to detect if EC implementation is present

2013-03-15 Thread Erik Joelsson
On 2013-03-14 20:37, Omair Majid wrote: Andrew Hughes wrote the original changeset in the old build system [1] and I believe this is exactly what he wanted out of the changeset. I am CC'ing Erik, who wrote the TODO [2] so he can clarify what he meant. I didn't actually create that comment in

Re: Allow configure to detect if EC implementation is present

2013-03-14 Thread Andrew Hughes
- Original Message - > On 15/03/2013 12:55 PM, Andrew Hughes wrote: > > - Original Message - > >> On 15/03/2013 5:37 AM, Omair Majid wrote: > >>> Hi, > >>> > >>> Updated webrev at: > >>> http://cr.openjdk.java.net/~omajid/webrevs/intree-ec/01/ > >>> > >>> I switched from DISABLE_INT

Re: Allow configure to detect if EC implementation is present

2013-03-14 Thread David Holmes
On 15/03/2013 12:55 PM, Andrew Hughes wrote: - Original Message - On 15/03/2013 5:37 AM, Omair Majid wrote: Hi, Updated webrev at: http://cr.openjdk.java.net/~omajid/webrevs/intree-ec/01/ I switched from DISABLE_INTREE_EC to ENABLE_INTREE_EC to avoid the confusion with double negative

Re: Allow configure to detect if EC implementation is present

2013-03-14 Thread Andrew Hughes
- Original Message - > On 15/03/2013 5:37 AM, Omair Majid wrote: > > Hi, > > > > Updated webrev at: > > http://cr.openjdk.java.net/~omajid/webrevs/intree-ec/01/ > > > > I switched from DISABLE_INTREE_EC to ENABLE_INTREE_EC to avoid the > > confusion with double negatives. > > Looking just

Re: Allow configure to detect if EC implementation is present

2013-03-14 Thread David Holmes
On 15/03/2013 5:37 AM, Omair Majid wrote: Hi, Updated webrev at: http://cr.openjdk.java.net/~omajid/webrevs/intree-ec/01/ I switched from DISABLE_INTREE_EC to ENABLE_INTREE_EC to avoid the confusion with double negatives. Looking just at the mechanics of this it looks fine to me. This needs t

Re: Allow configure to detect if EC implementation is present

2013-03-14 Thread Omair Majid
On 03/14/2013 03:14 PM, Vincent Ryan wrote: > The DISABLE_INTREE_EC flag is designed to control whether the Elliptic Curve > support in the > JDK source tree is skipped during a build. It is used to avoid the > duplication of EC libraries on > platforms where an EC library is already present. >

Re: Allow configure to detect if EC implementation is present

2013-03-14 Thread Omair Majid
Hi, Updated webrev at: http://cr.openjdk.java.net/~omajid/webrevs/intree-ec/01/ I switched from DISABLE_INTREE_EC to ENABLE_INTREE_EC to avoid the confusion with double negatives. Note that because of the ifeq comparison, if you use the new build system and just update the jdk tree, the ifeq ($E

Re: Allow configure to detect if EC implementation is present

2013-03-14 Thread Vincent Ryan
The DISABLE_INTREE_EC flag is designed to control whether the Elliptic Curve support in the JDK source tree is skipped during a build. It is used to avoid the duplication of EC libraries on platforms where an EC library is already present. In the old build it was a build option. In the new build

Re: Allow configure to detect if EC implementation is present

2013-03-14 Thread David Holmes
On 14/03/2013 3:12 PM, David Holmes wrote: Note that this isn't changing any functionality simply exposing an existing make variable at configure time. Correction. I misunderstood what was being done here. This forcibly set/clears the make variable based solely on the existence of a directory:

Re: Allow configure to detect if EC implementation is present

2013-03-13 Thread David Holmes
Note that this isn't changing any functionality simply exposing an existing make variable at configure time. David On 14/03/2013 2:38 PM, Brad Wetmore wrote: CC'ing security-dev. Vinnie, As owner of ECC, you should probably look at this. Brad On 3/13/2013 7:02 PM, David Holmes wrote: On

Re: Allow configure to detect if EC implementation is present

2013-03-13 Thread Brad Wetmore
CC'ing security-dev. Vinnie, As owner of ECC, you should probably look at this. Brad On 3/13/2013 7:02 PM, David Holmes wrote: On 14/03/2013 6:09 AM, Omair Majid wrote: Hi, jdk/makefiles/CompileNativeLibraries.gmk has a little note: TODO Set DISABLE_INTREE_EC in configure if src/share/nat