Re: CSR Review Request JDK-816826, Use server cipher suites preference by default

2019-03-12 Thread Sean Mullan
On 3/12/19 1:12 PM, Xuelei Fan wrote: On 3/12/2019 6:05 AM, Sean Mullan wrote: Looks good, but a couple of comments: In the Solution section, it says: "Applications can change the behavior with the existing SSLParameters.setUseCipherSuitesOrder​() method." I think you should be more clear t

Re: CSR Review Request JDK-816826, Use server cipher suites preference by default

2019-03-12 Thread Xuelei Fan
On 3/12/2019 6:05 AM, Sean Mullan wrote: Looks good, but a couple of comments: In the Solution section, it says: "Applications can change the behavior with the existing SSLParameters.setUseCipherSuitesOrder​() method." I think you should be more clear that this means applications can change

Re: CSR Review Request JDK-816826, Use server cipher suites preference by default

2019-03-12 Thread Sean Mullan
Looks good, but a couple of comments: In the Solution section, it says: "Applications can change the behavior with the existing SSLParameters.setUseCipherSuitesOrder​() method." I think you should be more clear that this means applications can change the order of the server's preferred cipher

CSR Review Request JDK-816826, Use server cipher suites preference by default

2019-02-25 Thread Xuelei Fan
Hi, Could I have the following CSR reviewed? https://bugs.openjdk.java.net/browse/JDK-8219657 It is proposing to use server cipher suite preference by default for TLS connections in JDK. In the current implementation, the server honors the client cipher suite preference by default. It is ea