Re: CSR Review for 8159544: Remove deprecated classes in com.sun.security.auth.**

2017-08-16 Thread Sean Mullan
Thanks, can you also review the corresponding webrev: http://cr.openjdk.java.net/~mullan/webrevs/8159544/ I'm also copying build-dev as there is one Makefile change in jdk.webrev.00. --Sean On 8/10/17 9:38 PM, Weijun Wang wrote: Done. Thanks Max On Aug 10, 2017, at 11:36 PM, Sean Mullan

Re: CSR Review for 8159544: Remove deprecated classes in com.sun.security.auth.**

2017-08-10 Thread Weijun Wang
Done. Thanks Max > On Aug 10, 2017, at 11:36 PM, Sean Mullan wrote: > > On 8/9/17 8:02 PM, Weijun Wang wrote: >> Looks fine. Should the specification part be formatted with and fixed >> fonts? > > Fixed. Can you add your name as Reviewer (you need to edit the CSR and add > your name to the

Re: CSR Review for 8159544: Remove deprecated classes in com.sun.security.auth.**

2017-08-10 Thread Sean Mullan
On 8/9/17 8:02 PM, Weijun Wang wrote: Looks fine. Should the specification part be formatted with and fixed fonts? Fixed. Can you add your name as Reviewer (you need to edit the CSR and add your name to the "Reviewed By" box). Thanks, Sean Thanks Max On Aug 10, 2017, at 3:15 AM, Sean

Re: CSR Review for 8159544: Remove deprecated classes in com.sun.security.auth.**

2017-08-09 Thread Weijun Wang
Looks fine. Should the specification part be formatted with and fixed fonts? Thanks Max > On Aug 10, 2017, at 3:15 AM, Sean Mullan wrote: > > Max, > > Could you please review the following CSR: > > https://bugs.openjdk.java.net/browse/JDK-8186047 > > Thanks, > Sean

CSR Review for 8159544: Remove deprecated classes in com.sun.security.auth.**

2017-08-09 Thread Sean Mullan
Max, Could you please review the following CSR: https://bugs.openjdk.java.net/browse/JDK-8186047 Thanks, Sean