Re: CertificateExtensions

On 03/30/2015 11:57 PM, Wang Weijun wrote: Hi Sean Are you OK with this? CertificateExtensions.java == Since we don't use names as keys, CertificateExtensions is not a typical CertAttrSet now. Remove the implements clause. Almost every class in the x509 packa

CertificateExtensions

Hi Sean Are you OK with this? > CertificateExtensions.java > == > > Since we don't use names as keys, CertificateExtensions is not a typical > CertAttrSet now. Remove the implements clause. Almost every class in the x509 package is built around the

Re: [9] RFR: 7145757: CertificateExtensions uses non-consistent key names

Known extensions which is unparseable and not critical will be stored in an unparseableExtensions map. Since we don't use names as keys, CertificateExtensions is not a typical CertAttrSet now. Remove the implements clause. OtherName.java == ExtensionMap will not support OtherName a

Re: [9] RFR: 7145757: CertificateExtensions uses non-consistent key names

> On Mar 28, 2015, at 05:19, Jason Uh wrote: > > > > On 03/27/2015 03:53 AM, Wang Weijun wrote: >> >>> On Mar 27, 2015, at 06:37, Jason Uh wrote: >>> >>> Please review this revision: >>> http://cr.openjdk.java.net/~juh/7145757/01/ >>> >>> * a global nameCache is maintained in OIDMap as sug

Re: [9] RFR: 7145757: CertificateExtensions uses non-consistent key names

On 03/27/2015 03:53 AM, Wang Weijun wrote: On Mar 27, 2015, at 06:37, Jason Uh wrote: Please review this revision: http://cr.openjdk.java.net/~juh/7145757/01/ * a global nameCache is maintained in OIDMap as suggested Can you just use the existing OIDMap.getId() method? It looks like your

Re: [9] RFR: 7145757: CertificateExtensions uses non-consistent key names

> On Mar 27, 2015, at 06:37, Jason Uh wrote: > > Please review this revision: > http://cr.openjdk.java.net/~juh/7145757/01/ > > * a global nameCache is maintained in OIDMap as suggested Can you just use the existing OIDMap.getId() method? It looks like your getCachedOid(name) is the same as g

Re: [9] RFR: 7145757: CertificateExtensions uses non-consistent key names

Please review this revision: http://cr.openjdk.java.net/~juh/7145757/01/ * all get()/set() calls to CertificateExtensions and CRLExtensions is by OID * get()/set() from X509CertImpl/Info continue to work by name. ex: X509CertImpl.get("x509.info.extensions.") * a global na

Re: [9] RFR: 7145757: CertificateExtensions uses non-consistent key names

s not. --Max > On Mar 19, 2015, at 07:40, Jason Uh wrote: > > Hi Max, > > On 03/18/2015 04:09 PM, Wang Weijun wrote: >> Hi Jason >> >> I was thinking about changing all set/get calls to using OID so inside >> CertificateExtensions and CRLExtensions you w

Re: [9] RFR: 7145757: CertificateExtensions uses non-consistent key names

Hi Max, On 03/18/2015 04:09 PM, Wang Weijun wrote: Hi Jason I was thinking about changing all set/get calls to using OID so inside CertificateExtensions and CRLExtensions you won't need to care about name conversions. Is that possible? It might be, but it'd call for more extensi

Re: [9] RFR: 7145757: CertificateExtensions uses non-consistent key names

Hi Jason I was thinking about changing all set/get calls to using OID so inside CertificateExtensions and CRLExtensions you won't need to care about name conversions. Is that possible? Also I see you adding some IOException throwing and catching. Is there any case you actually see th

[9] RFR: 7145757: CertificateExtensions uses non-consistent key names

Please review this fix, which changes the internal map in sun.security.x509.CertificateExtensions and CRLExtensions to always use the OID as the key. As stated in the JBS issue: The sun.security.x509.CertificateExtensions class maintains a Map map field to store all the extensions it manages