Re: Code Review Request, 8146197 SignatureAlgorithms.java after push of JDK-8146192

2015-12-27 Thread Sean Mullan
Looks fine to me. > On Dec 25, 2015, at 10:53 AM, Xuelei Fan wrote: > > Hi, > > Anyone available for a quick review? > > http://cr.openjdk.java.net/~xuelei/8146197/webrev.00/ > > A test failure caused by the removal of BASE64Decoder. Updated to use > java.util.Base64. > > Thanks, > Xuele

Re: Code Review Request, 8146197 SignatureAlgorithms.java after push of JDK-8146192

2015-12-25 Thread Henry Jen
Not an official reviewer, but the change look good to me. Cheers, Henry > On Dec 25, 2015, at 7:53 AM, Xuelei Fan wrote: > > Hi, > > Anyone available for a quick review? > > http://cr.openjdk.java.net/~xuelei/8146197/webrev.00/ > > A test failure caused by the removal of BASE64Decoder. U

Code Review Request, 8146197 SignatureAlgorithms.java after push of JDK-8146192

2015-12-25 Thread Xuelei Fan
Hi, Anyone available for a quick review? http://cr.openjdk.java.net/~xuelei/8146197/webrev.00/ A test failure caused by the removal of BASE64Decoder. Updated to use java.util.Base64. Thanks, Xuelei