The updated webrev looks good.
--Sean
On 12/19/2015 11:06 AM, Xuelei Fan wrote:
new webrev: http://cr.openjdk.java.net/~xuelei/8133070/webrev.01/
Updates to webrev.00:
Re-org the get methods of SSLContextImpl so as to avoid repeated
initialization of instance fields.
On 12/18/2015 11:35 PM, S
new webrev: http://cr.openjdk.java.net/~xuelei/8133070/webrev.01/
Updates to webrev.00:
Re-org the get methods of SSLContextImpl so as to avoid repeated
initialization of instance fields.
On 12/18/2015 11:35 PM, Sean Mullan wrote:
> Here are a few other other comments on the code:
>
> SSLContext
Here are a few other other comments on the code:
SSLContextImpl:
- I noticed that SSLContext.init does not specify how it handles
empty arrays, and you have changed the code so that an empty
TrustManager array is treated like they are null - is this change in
behavior a compatibility issue a
On 12/15/2015 4:24 AM, Sean Mullan wrote:
> Hi Xuelei,
>
> For JDK 9, the EC impl is defined to be in its own module
> (jdk.crypto.ec). How does it affect this fix if that module is not
> available/installed?
>
The SunJSSE provider would not support dynamically loading of crypto
providers/modules
Hi Xuelei,
For JDK 9, the EC impl is defined to be in its own module
(jdk.crypto.ec). How does it affect this fix if that module is not
available/installed?
--Sean
On 12/01/2015 07:49 AM, Xuelei Fan wrote:
Hi,
Please review the fix for JDK-8133070:
http://cr.openjdk.java.net/~xuelei/8
Ping ...
On 12/1/2015 8:49 PM, Xuelei Fan wrote:
> Hi,
>
> Please review the fix for JDK-8133070:
>
>http://cr.openjdk.java.net/~xuelei/8133070/webrev.00/
>
> In (Open)JDK 6, EC cipher suites get supported by Java. However, there
> is no default EC provider in JDK 6 at that time. In order
Hi,
Please review the fix for JDK-8133070:
http://cr.openjdk.java.net/~xuelei/8133070/webrev.00/
In (Open)JDK 6, EC cipher suites get supported by Java. However, there
is no default EC provider in JDK 6 at that time. In order to support
third part's EC algorithm JCE provider dynamically, it
