Thanks for the code review. I will wrap up the updates in the next webrev.
I plan to close the code review for the new handshaking implementation
by the end of January (Jan. 31, 2018). Please let me know if you need
more time.
Thanks,
Xuelei
On 1/18/2018 7:26 AM, Adam Petcher wrote:
Discl
Disclaimer: I am not a Reviewer. This is not a Review.
I looked through all of the code and I didn't find any significant
issues. In general, I think this is a nice improvement, and it makes the
code easier to understand. Below are a few minor comments:
SupportedGroups.java: There are (draft)
Hello Xuelei,
Here are a few more comments from some of the new files, maybe one or
two existing ones that I missed the first time around. I still need to
do the final two big ones (SSLSocketImpl and SSLEngineImpl), but I think
I've gone through every other file in the webrev at this point.
Nice catches! The updated will present in the next webrev.
For the comment out ClientKeyExchangeService blocks, they're placeholder
for KRB5 cipher suites. If no objections to remove KRB5 cipher suites,
I will clear up these blocks in a future webrev.
Thanks,
Xuelei
On 1/3/2018 4:04 PM, J
Hi Xuelei, I'm only part way through this but I wanted to give you what
I had so far. I'm working on the new files now so hopefully I'll have
the rest of them done tomorrow.
* CipherBox.java
o 146: Were you intending to leave that commented protocol version
line in there in the s
Hi,
Please review the change:
http://cr.openjdk.java.net/~xuelei/8185576/webrev.00/
This fix is trying to re-org the TLS handshaking implementation in the
SunJSSE provider.
The handshaking process in TLS 1.3 is lot different from that of TLS
1.2. For TLS 1.3 implementation, it is not str
