Re: Code Review Request, JDK-8213782: NullPointerException in sun.security.ssl.OutputRecord.changeWriteCiphers

2018-12-14 Thread Xue-Lei Fan
On 12/14/2018 12:26 PM, Anthony Scarpino wrote: Other than my nit about the “make the compiler happy”, this all looks fine. It makes sense to me. I will remove the comment while pushing. For KeyUpdate, shouldn’t it never be null given the suite and protocol are already known good? I have n

Re: Code Review Request, JDK-8213782: NullPointerException in sun.security.ssl.OutputRecord.changeWriteCiphers

2018-12-14 Thread Anthony Scarpino
Other than my nit about the “make the compiler happy”, this all looks fine. For KeyUpdate, shouldn’t it never be null given the suite and protocol are already known good? I have not problem with the check to be cautious even if it should never happen. Tony > On Dec 14, 2018, at 9:00 AM, Xue

Code Review Request, JDK-8213782: NullPointerException in sun.security.ssl.OutputRecord.changeWriteCiphers

2018-12-14 Thread Xue-Lei Fan
Hi, Could I have the fix reviewed? http://cr.openjdk.java.net/~xuelei/8213782/webrev.00/ The SSLCipher.createReadCipher() and createWriteCipher() could return null if the cipher is not supported or the cipher is not available for a certain protocol version. The caller should check the null