Re: Code Review Request, JDK-8216045 The size of key_exchange may be wrong on FFDHE

2019-01-16 Thread Jamil Nimeh
Hi Xuelei, this looks good to me. --Jamil On 1/15/2019 7:45 AM, Xue-Lei Fan wrote: Hi, Could I have the update reviewed?    http://cr.openjdk.java.net/~xuelei/8216045/webrev.00/ While getting the encoded public key for DH key exchange,  the leading zeros of the key are not trimmed and the

Code Review Request, JDK-8216045 The size of key_exchange may be wrong on FFDHE

2019-01-15 Thread Xue-Lei Fan
Hi, Could I have the update reviewed? http://cr.openjdk.java.net/~xuelei/8216045/webrev.00/ While getting the encoded public key for DH key exchange, the leading zeros of the key are not trimmed and the key bit size is used for byte size. John helped to verify the fix with the infra