This explanation makes sense to me and the fix looks fine.
--Sean
On 12/17/2015 01:51 AM, Xuelei Fan wrote:
On 12/17/2015 7:52 AM, Bradford Wetmore wrote:
On 12/16/2015 3:22 PM, Xuelei Fan wrote:
On 12/17/2015 3:14 AM, Bradford Wetmore wrote:
The change itself looks ok, but a question on t
On 12/17/2015 7:52 AM, Bradford Wetmore wrote:
>
>
> On 12/16/2015 3:22 PM, Xuelei Fan wrote:
>> On 12/17/2015 3:14 AM, Bradford Wetmore wrote:
>>> The change itself looks ok, but a question on the previous code.
>>>
>>> 420: Why is SHA224 disabled when SunMSCAPI is present? Or
>>> alternativel
On 12/16/2015 3:22 PM, Xuelei Fan wrote:
On 12/17/2015 3:14 AM, Bradford Wetmore wrote:
The change itself looks ok, but a question on the previous code.
420: Why is SHA224 disabled when SunMSCAPI is present? Or
alternatively, why is SHA224 enabled when SunMSCAPI not present?
SunMSCAPI does
On 12/17/2015 3:14 AM, Bradford Wetmore wrote:
> The change itself looks ok, but a question on the previous code.
>
> 420: Why is SHA224 disabled when SunMSCAPI is present? Or
> alternatively, why is SHA224 enabled when SunMSCAPI not present?
SunMSCAPI does not support SHA-224 yet.
> Shouldn't
On 12/16/2015 11:14 AM, Bradford Wetmore wrote:
The synopsis should probably be:
Support SHA224withDSA/SHA256withDSA in TLSv1.2 \
signature_algorithms extension
Also, note the case of the "W" in "SHA256WithDSA".
Ignore these last two points, they've already been updated in the bug
The change itself looks ok, but a question on the previous code.
420: Why is SHA224 disabled when SunMSCAPI is present? Or
alternatively, why is SHA224 enabled when SunMSCAPI not present?
Shouldn't this be based on whether there is a SHA224 implementation
available? And if so, why are we no
On 12/15/2015 1:40 PM, Xuelei Fan wrote:
> Hi,
>
> Please this enhancement to the JSSE implementation:
>
Please review this enhancement to the JSSE implementation:
>http://cr.openjdk.java.net/~xuelei/8049321/webrev.00/
>
> This change will add support for the SHA224withDSA and SHA256withDSA
Hi,
Please this enhancement to the JSSE implementation:
http://cr.openjdk.java.net/~xuelei/8049321/webrev.00/
This change will add support for the SHA224withDSA and SHA256withDSA
algorithms in the TLS "signature_algorithms" extension in the SunJSSE
provider. Note that this extension does not
