Everything looks fine now.
Thanks
Max
> On Dec 2, 2015, at 10:48 AM, Xuelei Fan wrote:
>
> On 12/2/2015 10:20 AM, Wang Weijun wrote:
>>
>>> On Dec 2, 2015, at 9:12 AM, Xuelei Fan wrote:
>>>
>>> On 12/2/2015 9:05 AM, Wang Weijun wrote:
Socket is a Closeable, so you can
try (S
On 12/2/2015 10:20 AM, Wang Weijun wrote:
>
>> On Dec 2, 2015, at 9:12 AM, Xuelei Fan wrote:
>>
>> On 12/2/2015 9:05 AM, Wang Weijun wrote:
>>> Socket is a Closeable, so you can
>>>
>>> try (Socket sock = ) { ... }
>>>
>> Yes. Better coding. Updated in the same webrev.
>
> Same sslSocket
> On Dec 2, 2015, at 9:12 AM, Xuelei Fan wrote:
>
> On 12/2/2015 9:05 AM, Wang Weijun wrote:
>> Socket is a Closeable, so you can
>>
>> try (Socket sock = ) { ... }
>>
> Yes. Better coding. Updated in the same webrev.
Same sslSocket declared twice. Have you compiled the test?
You can
On 12/2/2015 9:05 AM, Wang Weijun wrote:
> Socket is a Closeable, so you can
>
> try (Socket sock = ) { ... }
>
Yes. Better coding. Updated in the same webrev.
> If you want more debug messages, why not e.printStackTrace()? Message is
> enough?
>
I was wondering, the cached connection
Socket is a Closeable, so you can
try (Socket sock = ) { ... }
If you want more debug messages, why not e.printStackTrace()? Message is enough?
Thanks
Max
> On Dec 2, 2015, at 8:55 AM, Xuelei Fan wrote:
>
> Hi,
>
> Please review the test fix for JDK-8143298:
>
> http://cr.openjdk.j
Hi,
Please review the test fix for JDK-8143298:
http://cr.openjdk.java.net/~xuelei/8143298/webrev.00/
The root cause of the intermittent test failure is still unclear to me.
I updated the test with more output messages, and clear the resources
in finally blocks. Hope the update can expose t
