Updated webrev looks fine to me.
--Sean
On 04/20/2016 11:18 AM, Xuelei Fan wrote:
Thanks for the comments, all looks reasonable to me.
Updated webrev: http://cr.openjdk.java.net/~xuelei/8144566/webrev.02/
Thanks,
Xuelei
On 4/20/2016 9:10 PM, Sean Mullan wrote:
* SSLSocketImpl.java
2100
Thanks for the comments, all looks reasonable to me.
Updated webrev: http://cr.openjdk.java.net/~xuelei/8144566/webrev.02/
Thanks,
Xuelei
On 4/20/2016 9:10 PM, Sean Mullan wrote:
> * SSLSocketImpl.java
>
> 2100 // ONLY used by ClientHandshaker for the server hostname during
> handshaling
>
* SSLSocketImpl.java
2100 // ONLY used by ClientHandshaker for the server hostname during
handshaling
typo: handshaking
2114 synchronized private void useImplicitHost(boolean noSniUpdate) {
the modifier order should be "private synchronized ..."
See: http://cr.openjdk.java.net/~alund
Ping ...
On 1/20/2016 9:14 AM, Xuelei Fan wrote:
> Ping ...
>
> On 12/8/2015 8:12 PM, Xuelei Fan wrote:
>> Good catch!
>>
>> I copied the comment here:
>>
>> --
>> SocketFactory sslsf = SSLSocketFactory.getDefault();
>> SSLSocket ssls = (SSLSocket) sslsf.createSocket();
>> s
Ping ...
On 12/8/2015 8:12 PM, Xuelei Fan wrote:
> Good catch!
>
> I copied the comment here:
>
> --
> SocketFactory sslsf = SSLSocketFactory.getDefault();
> SSLSocket ssls = (SSLSocket) sslsf.createSocket();
> ssls.connect(new InetSocketAddress(
> "bugs.openjdk
Good catch!
I copied the comment here:
--
SocketFactory sslsf = SSLSocketFactory.getDefault();
SSLSocket ssls = (SSLSocket) sslsf.createSocket();
ssls.connect(new InetSocketAddress(
"bugs.openjdk.java.net", 443), 0);
ssls.startHandshake();
No SNI is sent
., 08 Dez. 2015 2:51
Subject: Re: Code Review Request 8144566, Custom HostnameVerifier disables SNI
extension
Please see my comment in the bug. I haven't verified this, but it seems
the problem might be generic to the codepath through SSLSocket, not just
Https.
Brad
On 12/6/2015 4:
Please see my comment in the bug. I haven't verified this, but it seems
the problem might be generic to the codepath through SSLSocket, not just
Https.
Brad
On 12/6/2015 4:32 AM, Xuelei Fan wrote:
Hi,
Please review the update for JDK-8144566:
http://cr.openjdk.java.net/~xuelei/81
Hi,
Please review the update for JDK-8144566:
http://cr.openjdk.java.net/~xuelei/8144566/webrev.00/
For HttpsURLConnection, the server name may be set after the TLS
connection and handshake has been initialized. As may result in that
the server name does not present at TLS ClientHello messag
