Re: Code review request: 8015274, 8015276 and 8016158: policytool manual test problems

2013-06-11 Thread Sean Mullan
On 06/11/2013 09:51 AM, Weijun Wang wrote: It is because of 8015274: TEST_BUG: Step2: After selecting 'View Warning Log', it is empty instead of FileNotFound. Policytool automatically loads ~/.java.policy when it's started. The test expects the file does not exist and a warning should be cr

Re: Code review request: 8015274, 8015276 and 8016158: policytool manual test problems

2013-06-11 Thread Weijun Wang
It is because of 8015274: TEST_BUG: Step2: After selecting 'View Warning Log', it is empty instead of FileNotFound. Policytool automatically loads ~/.java.policy when it's started. The test expects the file does not exist and a warning should be created. -Max On 6/11/13 9:16 PM, Sean M

Re: Code review request: 8015274, 8015276 and 8016158: policytool manual test problems

2013-06-11 Thread Sean Mullan
Why did you need to check for a $HOME/.java.policy file in i18n.sh? Can you explain that? Otherwise, changes look good to me. --Sean On 06/08/2013 09:32 PM, Weijun Wang wrote: Updated at http://cr.openjdk.java.net/~weijun/8015274/webrev.01/ A new bug 8016158 is added. The changes inclu

Re: Code review request: 8015274, 8015276 and 8016158: policytool manual test problems

2013-06-10 Thread Weijun Wang
Updated at http://cr.openjdk.java.net/~weijun/8015274/webrev.01/ A new bug 8016158 is added. The changes include: 1. Add CYGWIN* as a case for uname in all tests 2. Add description about temp directory in all tests 3. i18.sh now checks for ~/.java.policy and creates a keystore 4. Many chang