Re: Code review request: 8025123: SNI support in Kerberos cipher suites

2013-10-01 Thread Xuelei Fan
Looks fine to me. Xuelei On 10/1/2013 5:45 PM, Artem wrote: > Hi Max, > > I updated the fix according to your comments: > > http://cr.openjdk.java.net/~kshefov/8025123/webrev.02/ > > > Artem > > On 09/30/2013 06:54 PM, Weijun Wang wro

Re: Code review request: 8025123: SNI support in Kerberos cipher suites

2013-10-01 Thread Artem
Hi Max, I updated the fix according to your comments: http://cr.openjdk.java.net/~kshefov/8025123/webrev.02/ Artem On 09/30/2013 06:54 PM, Weijun Wang wrote: Now that we only check "localhost" and "localhost.localdomain", the follow

Re: Code review request: 8025123: SNI support in Kerberos cipher suites

2013-09-30 Thread Xuelei Fan
Looks fine to me. BTW, you may also want to consider Weijun's comments. Thanks, Xuelei On 9/30/2013 10:32 PM, Artem wrote: > Updated webrev: http://cr.openjdk.java.net/~kshefov/8025123/webrev.01/ > > > - broke lines exceed 80 characters

Re: Code review request: 8025123: SNI support in Kerberos cipher suites

2013-09-30 Thread Weijun Wang
Now that we only check "localhost" and "localhost.localdomain", the following hack in the SSL.java test is not necessary any more: 92 // Run this after KDC, so our own DNS service can be started 93 try { 94 server = InetAddress.getLocalHost().getHostName().toLo

Re: Code review request: 8025123: SNI support in Kerberos cipher suites

2013-09-30 Thread Artem
Updated webrev: http://cr.openjdk.java.net/~kshefov/8025123/webrev.01/ - broke lines exceed 80 characters - the code updated accrding to http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-142311.html#449 - upda

Re: Code review request: 8025123: SNI support in Kerberos cipher suites

2013-09-30 Thread Xuelei Fan
It's a good catch and wonderful fix. Thanks, Artem! The fix looks fine to me, except three very minor coding style comments. 1. we used to have only 80 characters in each line. I think there might some lines exceed 80 characters, would you mind break these lines to keep the style consistent?

Code review request: 8025123: SNI support in Kerberos cipher suites

2013-09-30 Thread Artem
Hello, please review this fix for 8: http://cr.openjdk.java.net/~kshefov/8025123/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8025123 SNI APIs were introduced in JDK 8, but TLS Kerberos client implementation does not take into