Looks good.
Thanks,
Sean
On 11/10/2015 03:36 AM, Tim Du wrote:
Hi Sean:
Thanks for reviewing the codes. Updated them follow your comments, see
http://cr.openjdk.java.net/~fyuan/tim/8076359/webrev.02/ ,please help to
review them again.
Regards
Tim
On 11/10/2015 8:18 AM, Sean Mullan wrote:
Cou
Hi Sean:
Thanks for reviewing the codes. Updated them follow your comments, see
http://cr.openjdk.java.net/~fyuan/tim/8076359/webrev.02/ ,please help to
review them again.
Regards
Tim
On 11/10/2015 8:18 AM, Sean Mullan wrote:
Couple of comments:
- SolarisProviderTest is too generic for me.
Couple of comments:
- SolarisProviderTest is too generic for me. I would call this
"PreferredProviderTest". Also, that way it can be enhanced over time if
we add preferred providers for other OSes.
- In the error messages:
s/Get/Got/
s/Return/Returned/
- Similarly, "SecurityPropertyNegative
