Hi Sean,
Amended as requested before pushing; thanks,
-Joe
On 10/8/2019 2:12 PM, Sean Mullan wrote:
I would change "asn1" to "ASN.1" in the comment as that is the more
common usage of the acronym, otherwise looks good.
Thanks,
Sean
On 10/8/19 1:36 PM, Joe Darcy wrote:
PS And a revised webre
I would change "asn1" to "ASN.1" in the comment as that is the more
common usage of the acronym, otherwise looks good.
Thanks,
Sean
On 10/8/19 1:36 PM, Joe Darcy wrote:
PS And a revised webrev acting on comments from the JDK-8231262 to use a
single class-level @SuppressWarnings when an alterna
PS And a revised webrev acting on comments from the JDK-8231262 to use a
single class-level @SuppressWarnings when an alternative serial form is
implicitly being used:
http://cr.openjdk.java.net/~darcy/8231368.1/
Thanks,
-Joe
On 10/8/2019 10:11 AM, Joe Darcy wrote:
Hi Sean,
Returning t
Hi Sean,
Returning to this review
On 9/26/2019 12:35 PM, Sean Mullan wrote:
- Krb5Context.java
1394 @SuppressWarnings("serial") // Not statically typed as
Serializable
1395 private final EncryptionKey key;
EncryptionKey is Serializable (it derives from java.security.Key
On 9/26/19 3:41 PM, Roger Riggs wrote:
Sean,
I think that's the other EncryptionKey.
The one in
src/java.security.jgss/share/classes/sun/security/krb5/EncryptionKey.java isn't.
Right you are! Ok, never mind about my comment.
--Sean
Roger
On 9/26/19 3:35 PM, Sean Mullan wrote:
- Krb5C
Sean,
I think that's the other EncryptionKey.
The one in
src/java.security.jgss/share/classes/sun/security/krb5/EncryptionKey.java
isn't.
Roger
On 9/26/19 3:35 PM, Sean Mullan wrote:
- Krb5Context.java
1394 @SuppressWarnings("serial") // Not statically typed as
Serializable
1395
- Krb5Context.java
1394 @SuppressWarnings("serial") // Not statically typed as
Serializable
1395 private final EncryptionKey key;
EncryptionKey is Serializable (it derives from java.security.Key which
is Serializable). I was wondering why we needed to suppress the warning
her
Looks fine Joe.
regards,
Sean.
On 23/09/2019 17:15, Joe Darcy wrote:
Hello,
Another module, another review request as part of making serial
warnings more robust:
JDK-8231368: Suppress warnings on non-serializable non-transient
instance fields in java.security.jgss
http://cr.openjd
Hello,
Another module, another review request as part of making serial warnings
more robust:
JDK-8231368: Suppress warnings on non-serializable non-transient
instance fields in java.security.jgss
http://cr.openjdk.java.net/~darcy/8231368.0/
(Related earlier review
https://mail.open
