Re: JDK 8 Code Review Request for 7152564 and 7155693

2012-04-06 Thread Chris Hegarty
On 06/04/12 15:16, Sean Mullan wrote: On 4/6/12 10:13 AM, Sean Mullan wrote: On 4/6/12 9:59 AM, Seán Coffey wrote: Looks good Sean. Thanks for taking care of jdk 8 changes. Hopefully someone else can also review since I'm not an official jdk 8 reviewer. Ok. Copying Chris to see if he could a

Re: JDK 8 Code Review Request for 7152564 and 7155693

2012-04-06 Thread Sean Mullan
On 4/6/12 10:13 AM, Sean Mullan wrote: > On 4/6/12 9:59 AM, Seán Coffey wrote: >> Looks good Sean. Thanks for taking care of jdk 8 changes. >> >> Hopefully someone else can also review since I'm not an official jdk 8 >> reviewer. > > Ok. Copying Chris to see if he could also review. Oops, missed

Re: JDK 8 Code Review Request for 7152564 and 7155693

2012-04-06 Thread Sean Mullan
On 4/6/12 9:59 AM, Seán Coffey wrote: > Looks good Sean. Thanks for taking care of jdk 8 changes. > > Hopefully someone else can also review since I'm not an official jdk 8 > reviewer. Ok. Copying Chris to see if he could also review. Thanks, Sean > > regards, > Sean. > > On 06/04/12 14:40,

Re: JDK 8 Code Review Request for 7152564 and 7155693

2012-04-06 Thread Seán Coffey
Looks good Sean. Thanks for taking care of jdk 8 changes. Hopefully someone else can also review since I'm not an official jdk 8 reviewer. regards, Sean. On 06/04/12 14:40, Sean Mullan wrote: Hi Sean, Can you please review the code changes for the following bugs: 7152564: Improve CodeSourc

JDK 8 Code Review Request for 7152564 and 7155693

2012-04-06 Thread Sean Mullan
Hi Sean, Can you please review the code changes for the following bugs: 7152564: Improve CodeSource.matchLocation(CodeSource) performance 7155693: CodeSource.matchLocation getPort test can be improved webrev: http://cr.openjdk.java.net/~mullan/webrevs/7152564_7155693/webrev.00/ I will finalize