Re: JEP Review Request: SHA-3 Hash Algorithm

2016-03-03 Thread Michael StJohns
On 2/29/2016 3:44 PM, Valerie Peng wrote: Thanks for the comments, there are only < 3 months left for this to be implemented. Besides just assigning the mech numbers, we need the underlying PKCS11 library (Solaris or NSS) to support SHA-3. Once we have that, enhancing SunPKCS11 provider is

Re: JEP Review Request: SHA-3 Hash Algorithm

2016-02-29 Thread Valerie Peng
Thanks for the comments, there are only < 3 months left for this to be implemented. Besides just assigning the mech numbers, we need the underlying PKCS11 library (Solaris or NSS) to support SHA-3. Once we have that, enhancing SunPKCS11 provider is fairly trivial and can be done via an RFE. I

Re: JEP Review Request: SHA-3 Hash Algorithm

2016-02-26 Thread Valerie Peng
Hi Sean, Thanks for the comments. I have updated the JEP accordingly and added a link for the KAT. Valerie On 2/23/2016 10:09 AM, Sean Mullan wrote: This looks good. One suggestion, in the Description section, I think we should state what the standard algorithm names are for the 4 new

Re: JEP Review Request: SHA-3 Hash Algorithm

2016-02-23 Thread Michael StJohns
On 2/17/2016 7:49 PM, Valerie Peng wrote: Please review this drafted JEP for adding SHA-3 Hash Algorithm support to JDK 9: https://bugs.openjdk.java.net/browse/JDK-8064399 Thanks, Valerie This looks pretty good. However, I wouldn't throw PKCS11 to the side of the road.

Re: JEP Review Request: SHA-3 Hash Algorithm

2016-02-23 Thread Sean Mullan
This looks good. One suggestion, in the Description section, I think we should state what the standard algorithm names are for the 4 new MessageDigest algorithms. It is sort of implied, but I think we should be more specific. Perhaps after the "These can be implemented ..." sentence, add:

JEP Review Request: SHA-3 Hash Algorithm

2016-02-17 Thread Valerie Peng
Please review this drafted JEP for adding SHA-3 Hash Algorithm support to JDK 9: https://bugs.openjdk.java.net/browse/JDK-8064399 Thanks, Valerie