Re: Null-check-in-finally pattern in javax/security documentation

2011-06-17 Thread Sean Mullan
Bug has been filed. See: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7054969 --Sean On 6/14/11 9:45 AM, Sean Mullan wrote: I was thinking the same thing. I'll file a bug to have this fixed in JDK 8. --Sean On 06/14/2011 08:43 AM, Chris Hegarty wrote: In fact this looks like a good ca

Re: Null-check-in-finally pattern in javax/security documentation

2011-06-14 Thread Sean Mullan
I was thinking the same thing. I'll file a bug to have this fixed in JDK 8. --Sean On 06/14/2011 08:43 AM, Chris Hegarty wrote: In fact this looks like a good candidate for try-with-resources. -Chris. On 06/14/11 12:26 PM, Florian Weimer wrote: It seems to me this incorrect advice should be

Re: Null-check-in-finally pattern in javax/security documentation

2011-06-14 Thread Chris Hegarty
In fact this looks like a good candidate for try-with-resources. -Chris. On 06/14/11 12:26 PM, Florian Weimer wrote: It seems to me this incorrect advice should be removed from the documentation, like this: diff -r 7a341c412ea9 -r 77b101812a2e src/share/classes/java/security/KeyStore.java ---

Null-check-in-finally pattern in javax/security documentation

2011-06-14 Thread Florian Weimer
It seems to me this incorrect advice should be removed from the documentation, like this: diff -r 7a341c412ea9 -r 77b101812a2e src/share/classes/java/security/KeyStore.java --- a/src/share/classes/java/security/KeyStore.java Tue Jun 07 14:01:12 2011 -0700 +++ b/src/share/classes/java/securit