Re: Please review fix for 6951599 (Rename package of security tools for modularization)

2010-05-14 Thread Mandy Chung
Weijun Wang wrote: On May 14, 2010, at 2:40 PM, Mandy Chung wrote: The main reason for this fix is to separate the dependency of each tool. jdk.policytool -> jdk.desktop jdk.keytool -> jdk.jsse Why must "keytool -> jsse". Is it about the HostVerifier and TrustManager reference? It's

Re: Please review fix for 6951599 (Rename package of security tools for modularization)

2010-05-14 Thread Weijun Wang
On May 14, 2010, at 2:40 PM, Mandy Chung wrote: > Hi Max, > > Wang Weijun wrote: >> Hi Mandy >> >> Sorry for late comment. My email client on Nokia E71 keeps crashing. (Hope >> it's good this time). >> > > It's good. Thanks for the comment. > >> I'm quite sure there are people out there ca

Re: Please review fix for 6951599 (Rename package of security tools for modularization)

2010-05-13 Thread Mandy Chung
Hi Max, Wang Weijun wrote: Hi Mandy Sorry for late comment. My email client on Nokia E71 keeps crashing. (Hope it's good this time). It's good. Thanks for the comment. I'm quite sure there are people out there calling KeyTool the same way. Also, I feel a little weird that one tool is tr

Re: Please review fix for 6951599 (Rename package of security tools for modularization)

2010-05-13 Thread Wang Weijun
Hi Mandy Sorry for late comment. My email client on Nokia E71 keeps crashing. (Hope it's good this time). I'm quite sure there are people out there calling KeyTool the same way. Also, I feel a little weird that one tool is treated diffrently from others. Is it possible to leave all current

Re: Please review fix for 6951599 (Rename package of security tools for modularization)

2010-05-13 Thread Mandy Chung
I revised the fix to rename the package of keytool instead of jarsigner. Apparently, there are customers who depend on the jarsigner class. Webrev at: http://cr.openjdk.java.net/~mchung/6951599/webrev.01/ I also updated the copyright year (thanks Brad for pointing that out). Thanks Mandy

Please review fix for 6951599 (Rename package of security tools for modularization)

2010-05-11 Thread Mandy Chung
Hi, Please review the fix for: 6951599: Rename package of security tools for modularization Webrev: http://cr.openjdk.java.net/~mchung/6951599/webrev.00/ Move KeyTool, PolicyTool and JarSigner classes to its own package so that the classes can be placed in its own module while eliminating