Re: Questions on deprivileging a module

2016-07-05 Thread Remi Forax
> Cc: "jigsaw-dev" , "OpenJDK" > > Envoyé: Mardi 5 Juillet 2016 09:56:35 > Objet: Re: Questions on deprivileging a module > > On 05/07/2016 08:15, Wang Weijun wrote: > > > : > > It's a runtime error. > > > > @CallerSensitive &g

Re: Questions on deprivileging a module

2016-07-05 Thread Mandy Chung
> On Jul 5, 2016, at 12:15 AM, Wang Weijun wrote: > >>> 1. How does updating /make/common/Modules.gmk affect an exploded build? >> The mappings are used for both exploded and images build so the >> configuration in this make file is for both. > > I see. BTW, which file contain the mappings? I

Re: Questions on deprivileging a module

2016-07-05 Thread Alan Bateman
On 05/07/2016 09:03, Remi Forax wrote: The other solution is to use a VarHandle instead of Unsafe for setting the final field, i don't think that letting unprivileged module to access to Unsafe is a good idea. Very true, I wasn't paying attending to why it is using Unsafe in the first place.

Re: Questions on deprivileging a module

2016-07-05 Thread Alan Bateman
On 05/07/2016 08:15, Wang Weijun wrote: : It's a runtime error. @CallerSensitive public static Unsafe getUnsafe() { Class caller = Reflection.getCallerClass(); if (!VM.isSystemDomainLoader(caller.getClassLoader())) throw new SecurityException("Unsafe"); << The exception t

Re: Questions on deprivileging a module

2016-07-05 Thread Wang Weijun
> On Jul 5, 2016, at 2:52 PM, Alan Bateman wrote: > > On 04/07/2016 07:03, Wang Weijun wrote: > >> I am working on >> >>JDK-8159528 Deprivilege java.security.jgss, jdk.security.jgss and >> jdk.security.auth >>https://bugs.openjdk.java.net/browse/JDK-8159528 >> >> Several questions: >

Re: Questions on deprivileging a module

2016-07-04 Thread Alan Bateman
On 04/07/2016 07:03, Wang Weijun wrote: I am working on JDK-8159528 Deprivilege java.security.jgss, jdk.security.jgss and jdk.security.auth https://bugs.openjdk.java.net/browse/JDK-8159528 Several questions: 1. How does updating /make/common/Modules.gmk affect an exploded build? The

Questions on deprivileging a module

2016-07-03 Thread Wang Weijun
I am working on JDK-8159528 Deprivilege java.security.jgss, jdk.security.jgss and jdk.security.auth https://bugs.openjdk.java.net/browse/JDK-8159528 Several questions: 1. How does updating /make/common/Modules.gmk affect an exploded build? 2. I am using Unsafe in two places, once to rewr