: RE: RFR(S): 8220348: [ntintel] asserts about copying unalinged array
Hi Martin,
I can see that both places already include headers from
src/java.base/share/native/libjava/. I suggest adding the define in jni_util.h.
WindowsPreferences.c already includes it.
Best regards
Christoph
From: Doerr
penjdk.java.net>>;
Lindenmaier, Goetz mailto:goetz.lindenma...@sap.com>>
Subject: RE: RFR(S): 8220348: [ntintel] asserts about copying unalinged array
Hi Thomas and Christoph,
thanks for the reviews.
Other code in java.security.jgss also uses these #defined checks:
src/java.security.jgss/s
: Thomas Stüfe
Sent: Mittwoch, 4. Dezember 2019 17:56
To: Doerr, Martin
Cc: core-libs-...@openjdk.java.net; security-dev
; Lindenmaier, Goetz
Subject: Re: RFR(S): 8220348: [ntintel] asserts about copying unalinged array
Hi Martin,
this makes sense. This is the right way to force alignment. I do
; Langer, Christoph
Cc: core-libs-...@openjdk.java.net; security-dev
; Lindenmaier, Goetz
Subject: RE: RFR(S): 8220348: [ntintel] asserts about copying unalinged array
Hi Thomas and Christoph,
thanks for the reviews.
Other code in java.security.jgss also uses these #defined checks:
src
Hi Martin,
this makes sense. This is the right way to force alignment. I do not like
the platform code in the shared file but do not think this is a big deal.
+#if defined (_WIN32) && defined (_MSC_VER)
Why do you think we need _MSC_VER too? Is OpenJDK on Windows even buildable
with anything
ier, Goetz
> Subject: [CAUTION] RFR(S): 8220348: [ntintel] asserts about copying
> unalinged array
>
> Hi,
>
> I'd like to propose a fix for an old issue on 32 bit Windows (also for an 11u
> backport):
> https://bugs.openjdk.java.net/browse/JDK-8220348
>
> So
Hi,
I'd like to propose a fix for an old issue on 32 bit Windows (also for an 11u
backport):
https://bugs.openjdk.java.net/browse/JDK-8220348
Some jdk native methods use jni_SetLongArrayRegion with a stack allocated
buffer.
jni_SetLongArrayRegion uses Copy::conjoint_jlongs_atomic which
